Commit graph

11568 commits

Author SHA1 Message Date
chimp1984
67723fa1a7
Do not pass over xmrAutoConfirmationManager to ProcessModel but use a
getter from tradeManager. Avoids boilerplate code (I know there is more
in the existing code to optimize here ;-))
2020-08-30 16:43:32 -05:00
chimp1984
219094e9d1
Merge branch 'add-xmr-tx-key-service-2' into add-xmr-tx-key-service-3 2020-08-30 16:11:12 -05:00
chimp1984
77c203e87e
No functional change, pure refactoring
Move to convertToRawHex CryptoNoteUtils as well as the classes inside
the validator.
2020-08-30 16:08:07 -05:00
chimp1984
5143b1ed59
Apply suggested changes from code analysis 2020-08-30 15:56:44 -05:00
chimp1984
bfab6ffc2e
Replace success/failure with booleans 2020-08-30 15:51:43 -05:00
chimp1984
e5aee1ca07
No functionality has been changed by that refactoring, just moved
classes and renamed package and adjusted access modifiers.
2020-08-30 15:50:15 -05:00
chimp1984
ed5078c0f1
Add abstract AutoConfirmResult class to get better support if we want
to add auto confirm for other currencies in the future. The generic part
is only used where we would have issues with backward compatibility like
in the protobuf objects. Most of the current classes are kept XMR
specific and could be generalized once we add other assets, but that
would be an internal refactoring without breaking any network or
storage data. I think it would be premature to go further here as we
don't know the details of other use cases. I added the methods used from
clients to AutoConfirmResult, not sure if the API is well defined by
that, but as said that could become subject of a future refactoring once
another auto confirm feature gets added. Goal of that refactoring was
to avoid that we need more fields for trade and the the UI would have to
deal with lots of switch cases based on currency.

Sorry that is a larger commit, would have been hard to break up...
2020-08-30 15:45:47 -05:00
chimp1984
2f1566bb06
Add NO_MATCH_FOUND in comment 2020-08-30 14:48:15 -05:00
chimp1984
2f7b24d1c8
- Add @Nullable
- Add curly brackets to one liners
- Log improvements
2020-08-30 14:46:04 -05:00
chimp1984
07a761255d
- Make REPEAT_REQUEST_PERIOD and MAX_REQUEST_PERIOD static
- Replace httpClient.toString() with httpClient.getBaseUrl() as toString
would deliver too much for those use cases.
- Add @Nullable
- Log improvements
2020-08-30 14:45:05 -05:00
chimp1984
2dbc4645ec
- Change tolerance from 1 day to 2 hours.
- Add case if no match is found -> NO_MATCH_FOUND.
- Add test case for NO_MATCH_FOUND
- Add curley brackets to one liners
- Log improvements
2020-08-30 14:42:52 -05:00
chimp1984
008ae93b88
Add null check for name 2020-08-30 14:40:21 -05:00
chimp1984
3e728c69f7
- Remove AutoConfirmResult enum from protobuf and add a AutoConfirmResult
instead which stores the stateName. [1]

- Adjust protobuf methods

- Add UNDEFINED to AutoConfirmResult.State to support cases where we
get no data to set the enum.

- Add NO_MATCH_FOUND (used in follow up commits)

- Refactoring: Improve constructors

[1]
Enums in protobuf are not well supported. They are global so an enum
with name (e.g. State) inside Trade conflicts with another enum inside
Message with the same name. So they do not reflect encapsulation in the
class like in java.
We moved over time to the strategy to use strings (from enum.name())
instead of the enum, avoiding also cumbersome fromProto and toProto
code and being more flexible with updates.
The autoConfirmResultState enum inside Trade was a bit confusing to me
as it was a different structure as in the java code. We try to mirror
the structure as far as possible.
2020-08-30 14:39:44 -05:00
James Cox
ca9f61ecde
Update core/src/main/resources/i18n/displayStrings.properties
Co-authored-by: m52go <mfiver@gmail.com>
2020-08-30 12:39:23 -05:00
James Cox
36e2f71f1b
Update core/src/main/resources/i18n/displayStrings.properties
Co-authored-by: m52go <mfiver@gmail.com>
2020-08-30 12:39:05 -05:00
jmacxx
d9d0814064
Re-word the XMR account creation message per @m52go 2020-08-30 11:52:04 -05:00
chimp1984
5501822128
Merge branch 'master_upstream' into xmr 2020-08-29 23:03:13 -05:00
Christoph Atteneder
ecb8db3a4e
Merge pull request #4440 from jmacxx/fix_low_bsq_offer
Improve warning message regarding insufficient BSQ
2020-08-29 20:03:03 +02:00
Christoph Atteneder
835c511cf5
Merge pull request #4448 from wiz/revert-4398-header-tweaks
Revert "Header and other visual tweaks"
2020-08-29 20:01:15 +02:00
Christoph Atteneder
589266966c
Merge pull request #4450 from chimp1984/fix-getMinRefundAtMediatedDispute
Fix null pointer in case if selectedMarketPrice is null
2020-08-29 19:57:55 +02:00
chimp1984
ef11e2ad89
Fix comment 2020-08-29 12:29:07 -05:00
chimp1984
8253957cb2
Fix null pointer in case if selectedMarketPrice is null 2020-08-29 12:19:36 -05:00
sqrrm
38f9d251ae
Merge pull request #4435 from chimp1984/improve-network-statistics
Add more detailed network statistics
2020-08-29 19:01:43 +02:00
jmacxx
cccc6de595
Default to clearnet XMR proof providers when in dev mode 2020-08-29 10:21:03 -05:00
sqrrm
591d68a6fd
Merge pull request #4445 from chimp1984/restart-seednodes-deterministically
Use the index of a seed node address in the list of nodes at the
2020-08-29 15:20:03 +02:00
sqrrm
79a26aa95d
Merge pull request #4446 from chimp1984/add-report-button-for-dispute-views
Improve dispute views
2020-08-29 14:18:21 +02:00
wiz
997a2a5e55
Revert "Header and other visual tweaks" 2020-08-29 18:12:23 +09:00
chimp1984
b5c8bae1fa
Enable check for lock time on mainnet and add a 3 block tolerance. 2020-08-28 22:16:04 -05:00
chimp1984
f52beadc47
Improve dispute views
Add re-open dispute button to mediation views (not refund agent as
there it might be dangerous if he would close 2 times and pay out twice.

If a dispute was reopened and a message was sent afterwards the receiver
will auto-reopen the dispute as well and the UI shows the number
indicator.

Add search field to traders dispute views.

Fix DisputeMsgEvents which was handling only legacy arbitration cases
and now uses mediation and refund agent. Used to update state in case
the UI is not selected.

Add "send private notification" button for mediators and refund agents.

Add report button for mediators and refund agents
Generates report text of all disputes with more detailed information
which should be used for reporting.

Add "Dump text of all disputes" button for getting a text representation
of all disputes including the messages for mediators and refund agents.
This is not used for report but might be useful for search, etc.

Do not show legacy arbitration tabs (for traders as well for
arbitrators) if no cases available.

Add 5 new enum entries for Reason for dispute:
OPTION_TRADE
SELLER_NOT_RESPONDING
WRONG_SENDER_ACCOUNT,
TRADE_ALREADY_SETTLED,
PEER_WAS_LATE

Hide NO_REPLY, SCAM and PROTOCOL_VIOLATION in UI (still in code if we still
need it and re-activate them).
2020-08-28 22:15:11 -05:00
chimp1984
97ec45c173
Merge branch 'reenable-chat-on-dispute-reopen' into add-report-button-for-dispute-views 2020-08-28 14:23:36 -05:00
chimp1984
a148850685
Merge branch 'master_upstream' into reenable-chat-on-dispute-reopen 2020-08-28 14:11:59 -05:00
chimp1984
fa9f799186
Improve dispute views
Add report button:
Generates report text of all disputes with more detailed information
which should be used for reporting.

Add "Dump text of all disputes" button for getting a text representation
of all disputes including the messages. This is not used for report but
might be useful for search, etc.

Do not show legacy arbitration tabs (for traders as well for
arbitrators) if no cases available.

Add 3 new enum entries for Reason for dispute:
OPTION_TRADE
SELLER_NOT_RESPONDING
WRONG_SENDER_ACCOUNT
Hide NO_REPLY and PROTOCOL_VIOLATION in UI (still in code if we still
need it and re-activate them)
2020-08-28 13:48:28 -05:00
jmacxx
e3bf0735f7
Persist the auto confirm state of Trade object
Auto confirmed trades will be indicated as such on Trade details.
2020-08-28 12:13:50 -05:00
sqrrm
d1a1cc52fe
Merge pull request #4410 from chimp1984/optimize-shutdown-routines
Optimize application shutdown
2020-08-28 17:17:01 +02:00
chimp1984
5ac1f6e05c
Merge branch 'master_upstream' into improve-network-statistics 2020-08-28 09:48:14 -05:00
chimp1984
5f7cfd2dc8
Improve logging of initial data requests 2020-08-28 09:39:33 -05:00
Christoph Atteneder
3599355e4a
Merge pull request #4442 from cd2357/patch-1
Exclude spot price provider tests by default
2020-08-28 14:57:14 +02:00
chimp1984
c218b28755
Satistfy codacy 2020-08-28 07:39:23 -05:00
chimp1984
fa5a58d41a
Use the index of a seed node address in the list of nodes at the
repository to determine the hour to restart.
2020-08-28 02:30:45 -05:00
jmacxx
967e0538d6
Rename XmrProofResult to AutoConfirmResult 2020-08-27 21:15:24 -05:00
jmacxx
ac10d71f78
Add XMR proof result status code TRADE_LIMIT_EXCEEDED 2020-08-27 16:44:32 -05:00
chimp1984
8c619530a4
Remove display of data from last second 2020-08-27 15:43:13 -05:00
cd2357
43cd6e9bf5
Exclude spot price provider tests by default
Exclude these tests from the default gradle test task. However, allow the option of having them included by specifying an optional gradle parameter (-Dtest.pricenode.includeSpotProviderTests=true).
2020-08-27 14:10:37 +02:00
Christoph Atteneder
a6a38a1ac1
Merge pull request #4437 from devinbileck/add-mempool.bisq.services
Add mempool.bisq.services explorer and mempool fee estimation provider
2020-08-27 11:06:41 +02:00
jmacxx
c6f1e5274f
Merge remote-tracking branch 'origin/master' into add-xmr-tx-key-service-2 2020-08-26 22:17:58 -05:00
jmacxx
ca8f53c2c2
Implement XMR tx proof autoconfirm feature
* XMR seller is prompted to enter txId and viewkey.
* looks up the XMR transaction to verify that it has confirmed
* user can run their own validating service, or use the ones provided
* 100% agreement of all chosen services is necessary for confirmation
* feature can be configured and turned on/off from settings screen
* feature can be globally turned off via admin filter
* two code review passes from chimp1984
* one text review from m52go
2020-08-26 21:51:14 -05:00
jmacxx
8cb716b802
Improve warning message regarding insufficient BSQ
Improve the warning message to explain why BSQ balances
close to 5.46 are not sufficient to be used for trade fees,
due to dust limits in the Bitcoin protocol.

Fixes #4439
2020-08-26 20:49:38 -05:00
sqrrm
2cc0e4134b
Reload dispute layout on reopen
When a dispute is reopened it now shows the chat text entry field.
2020-08-26 13:40:49 +02:00
Devin Bileck
51f318d47f
Add mempool.bisq.services explorer and mempool fee estimation provider 2020-08-26 00:01:22 -07:00
chimp1984
a88e8f88fa
Don't use full toString result for thread name 2020-08-26 00:02:57 -05:00