ghubstan
65fb8e8225
Add CliMain.main(args) tests
...
There are no asserts, but helpful for looking at affects of CLI commands
from terminal because apitest cases use gRPC service stubs instead of terminal.
2021-12-02 19:17:03 -03:00
ghubstan
743ef93750
Test API XMR support
2021-12-02 19:11:29 -03:00
ghubstan
a45c5fa61f
Adjust CLI opts parsers & opt parsing test for XMR support
2021-12-02 19:09:54 -03:00
ghubstan
03b57916a5
Make altcoin offer sorting method names more generic
2021-12-02 19:07:49 -03:00
ghubstan
54f815eb4f
Adjust API cli-side CryptoCurrencyUtil & OffersServiceRequest for XMR support
2021-12-02 19:04:28 -03:00
ghubstan
742a6f441e
Allow mkt price lookup for any altcoin from API
2021-12-02 19:02:03 -03:00
ghubstan
ce8b6df9c5
Adjust API CorePaymentAccountsService for creating XMR accts
2021-12-02 19:00:22 -03:00
ghubstan
b85459d7c6
Refactor api.core side editoffer validation & fix bug
...
The editoffer validation bug fixes:
- A trigger-price edit forced offer.price-margin=0.00.
This needs to be checked in new apitest case asserts.
- An activate state (only) edit forced offer.isUseMarketBasedPrice=true.
The CLI does not have the offer instance, and cannot know the correct
value of the isUseMarketBasedPrice param sent in the editoffer request.
The daemon has to figure this out. If the editType parameter value
sent to daemon is ACTIVATION_STATE_ONLY, use the current offer.isUseMarketBasedPrice.
The refactoring includes more useful and readable information in core's EditOfferValidator
and MutableOfferPayloadFields toString methods, for debugging with the daemon log. And some
adjustments for allowing edits to XMR offers.
2021-12-02 15:04:38 -03:00
ghubstan
095a49598c
Add more readable toString method to MutableOfferPayloadFields
...
This makes it easier to compare to EditOfferValidator.toString
2021-12-02 14:51:15 -03:00
ghubstan
33d976cf79
Calculate offer.makerFee if offer is bsq-swap
...
V1 offer instances have a makeFee value, but not BSQ swap offers.
This needs to be investigated.
See commit d57d6e9852
2021-12-01 19:06:01 -03:00
ghubstan
e3c40895fe
Use offer instance to determine ownership, not it's id
2021-12-01 16:05:30 -03:00
ghubstan
d57d6e9852
Use calculated offer maker fee, do not re-calculate it
2021-12-01 16:03:31 -03:00
ghubstan
946ca460ef
Merge branch 'master' into 5-api-bsqswap-simulation-n-docs-update
2021-11-30 12:46:34 -03:00
Christoph Atteneder
c4e18fedd9
Merge pull request #5878 from jmacxx/fix_dispute_reopen_issue
...
Bugfix: dispute ticket reopened by mailbox message
2021-11-30 10:27:52 +01:00
ghubstan
3015554f9a
Adjust API beta-test guide for BSQ swaps
2021-11-29 13:14:56 -03:00
ghubstan
a1db0d10b0
Update API docs for Bitcoin Core version v22.0
...
Plus some outdated JDK version compat comments.
2021-11-29 12:43:58 -03:00
ghubstan
b1dd20572c
Allow unrecognized options in OfferIdOptionParser where appropriate
...
The OfferIdOptionParser superclass reduces duplication for parsing
offer-id parameters, but it needs to let subclass parsers' other
options pass validation.
2021-11-29 12:30:13 -03:00
jmacxx
0025609375
Bugfix: dispute ticket reopened by mailbox message
2021-11-29 09:18:55 -06:00
ghubstan
6b89254588
Adjust core api method help docs for bsq swaps
2021-11-29 11:29:42 -03:00
ghubstan
8b2dec7a55
Remove unused function outputs
2021-11-28 16:37:41 -03:00
ghubstan
1b7e43a874
Add apitest/scripts/bsqswap-simulation.sh script
...
Some refactoring and typo corrections in existing scripts too.
2021-11-28 16:12:02 -03:00
ghubstan
66115f3d81
Revert "There is no --swap opt in editoffer command"
...
This reverts commit b5981b5b71
2021-11-28 14:56:57 -03:00
ghubstan
0d8559d0d2
Force rebuild after github action ECONNRESET
2021-11-27 20:58:05 -03:00
ghubstan
b5981b5b71
There is no --swap opt in editoffer command
...
BSQ swap offers cannot be edited
2021-11-27 14:17:52 -03:00
ghubstan
000fe9b991
Test blocking attempts to edit BsqSwap offers on server
2021-11-27 14:02:11 -03:00
ghubstan
b95e4b37b6
Block attempts to edit BsqSwap offers from CLI
2021-11-27 14:01:38 -03:00
ghubstan
64f228d872
Make rpc GetOfferCategory service work for my+avail offers
...
There are some use cases where the CLI needs to know what kind of offer
is being acted on before the request is made, For example:
There are differences between a BsqSwap 'takeoffer'request, and a v1
'takeoffer' request.
A BsqSwap offer cannot be edited by an 'editoffer' request, and an
attempt should be blocked by the CLI.
- Append isMyOffer GetOfferCategoryRequest rpc msg def.
- Adjust daemon.grpc services for new boolean GetOfferCategoryRequest param.
- Adjust core.api for new boolean GetOfferCategoryRequest param.
- Add validation check in core.api EditOfferValidator to block attempt to
edit a BsqSwap offer.
- Refactor CoreOffersService get*offer(id) methods to optionally throw
excpetions.
2021-11-27 14:01:14 -03:00
ghubstan
05d1916ae9
Fix help text typo
2021-11-26 10:54:28 -03:00
ghubstan
0aa0852407
Add CLI createoffer smoketest (for bsq swaps)
...
NEVER RUN ON MAINNET!
2021-11-25 18:21:06 -03:00
ghubstan
132ecc9ac3
Adjust CliMain's createoffer for BSQ swaps
2021-11-25 18:20:04 -03:00
ghubstan
15621d42a9
Re-@Disable method tests (don't run 2x from gradle)
2021-11-25 18:19:12 -03:00
ghubstan
eff10842b9
Tighten createoffer param validation (only bsq swaps supported)
2021-11-25 17:31:54 -03:00
ghubstan
35aeb61338
Adjust createoffer opt parser for bsq swaps
2021-11-25 17:10:19 -03:00
ghubstan
b1c872c515
Adjust createoffer opt parser/test for bsq swaps
2021-11-25 17:08:07 -03:00
ghubstan
3077be54f0
Remove API createoffer's paymentAcctId request param (BSQ swap)
2021-11-25 16:12:05 -03:00
ghubstan
00a5e2b650
Merge branch 'master' into 2-refactor-api-bsqswap-support
2021-11-25 14:33:48 -03:00
Christoph Atteneder
8fb8374721
Merge pull request #5864 from cd2357/add-java-15-as-supported-jdk
...
Update package.gradle: rely on local JDK 15
2021-11-25 11:05:26 +01:00
Christoph Atteneder
04c88223ad
Improve release build documentation
2021-11-25 10:50:05 +01:00
cd2357
3723dd32ef
Update package.gradle: rely on local JDK 15
...
Enforce the use of JDK 15 when packaging. This removes the need to download and unpack JDK 15 just for the use of jpackager.
2021-11-25 10:50:05 +01:00
Christoph Atteneder
55fc413ee0
Print dependency report if failure
2021-11-25 10:50:04 +01:00
Christoph Atteneder
9836c0fac2
Remove gradle cache
2021-11-25 10:50:04 +01:00
Christoph Atteneder
7727776453
Add official Java 15 support
2021-11-25 10:50:03 +01:00
Christoph Atteneder
ba6d5e2c73
Merge pull request #5842 from jmacxx/fix_exception_portfolio_history
...
Bug fixes: Locked Balance display; Portfolio History screen
2021-11-25 09:54:31 +01:00
ghubstan
c177b3b834
Merge branch 'master' into 2-api-bsq-swap-scratch
2021-11-24 13:14:13 -03:00
ghubstan
6403fc1f81
Adjust apitest cases to rpc BSQ wwap related changes
2021-11-24 13:12:48 -03:00
ghubstan
0c5c343fe0
Adjust CLI to support getting/taking BSQ swaps
...
Also refactored some of the opt parsers.
2021-11-24 13:10:34 -03:00
ghubstan
3aae052813
Refactor core.api trade service implemenentations for BSQ swaps
...
A minor refactoring to support serving TradeModel instances to CLI.
For example, the CLI 'gettrade' command must return a v1 Trade or
BSQ swap trade.
2021-11-24 13:05:09 -03:00
ghubstan
f88c1513ec
Refactor GrpcTradesService: use GetTrade & TakeOffer services for BSQ swaps
...
The rpc GetBsqSwapTrade and TakeBsqSwapOffer services were a quick hack
to help test BSQ swap feature development more quickly, using apitest
cases. Their gRPC service method implementations are removed here and
the GetTrade & TakeOffer service methods are refactored to support BSQ
swaps.
2021-11-24 13:00:30 -03:00
ghubstan
17277c4c67
Remove Get/Take BSQSwap Offer/Trade rpc service defs
...
The old GetTrade and TakeOffer rpc service defs will be used
for getting BSQ swap trades, and taking BSQ swap offers.
2021-11-24 12:52:58 -03:00
Christoph Atteneder
95577501a2
Merge pull request #5860 from ghubstan/gradle-java-src-n-target-compat
...
Set gradle java src & target compat = VERSION_11
2021-11-24 09:51:28 +01:00
