ghubstan
35a77be7e4
Redefine DisputeAgentType REFUNDAGENT as REFUND_AGENT
...
The CLI needs to be able to register a REFUND_AGENT using the
'refund_agent' or 'refundagent' parameter value (in any case),
so an alt-name mapping was added to the enum def.
2020-09-27 15:23:19 -03:00
ghubstan
96abda4e2d
Tidy up create offer using mkt price margin % test
2020-09-26 13:40:10 -03:00
ghubstan
de3105a62b
Add license comment
2020-09-25 20:56:48 -03:00
ghubstan
92042d70ad
Remove unused import
2020-09-25 20:56:25 -03:00
ghubstan
18df1e2fd4
Fix abs(dbl) comparison
2020-09-25 20:53:45 -03:00
ghubstan
2f3e3a31e1
Add simple mkt-price service & test calculated offer prices
...
A gRPC price service was added, and api create-offer tests can check
mkt based price margin calculations.
2020-09-25 20:48:26 -03:00
ghubstan
82ce864fda
Delete trailing spaces from blank line for codacy
2020-09-25 15:19:10 -03:00
ghubstan
3b518249d4
Do not reassign currencyCode parameter
2020-09-25 14:44:35 -03:00
ghubstan
6cf9bbbaa9
Minor createoffer test changes
2020-09-25 13:58:32 -03:00
ghubstan
995af0dd21
Convert mktPriceMargin to %, make createAndPlaceOffer private
...
And move createAndPlaceOffer to bottom of class file.
2020-09-25 13:50:50 -03:00
ghubstan
96278b9bab
Push currencyCode.toUpperCase conversion below CoreApi
2020-09-25 12:33:51 -03:00
ghubstan
6cdbc137c1
Move 'createoffer' price arg transform to server & test it
...
The CreateOfferRequest's price field type was changed from long to string,
so a CLI param like 10000.0055 can be passed to the server as is, to be
scaled and converted there. In general, we want to keep validation logic
on the CLI as simple as possible, and use existing core logic to
validate args and convert arg types when needed.
2020-09-24 18:13:19 -03:00
ghubstan
942a6f2203
Scale & convert (double) fixed price input to long
2020-09-24 14:56:27 -03:00
ghubstan
9999c95a9e
Change 'createoffer' argument order
...
And list the args in CLI --help outout.
2020-09-24 13:48:50 -03:00
ghubstan
ec9c1b0f10
Uppercase direction & ccy-code CLI arguments in core
...
Don't convert parameter case in CLI.
2020-09-24 09:18:13 -03:00
ghubstan
a6048a4f7d
Add comment to empty catch block for codacy
2020-09-23 20:43:56 -03:00
ghubstan
c8a7fe4b97
Print createoffer's reply in the CLI's console
2020-09-23 19:57:22 -03:00
ghubstan
d5b8800ba4
Add license comment and btc-string to satoshi converter
...
The converter is needed for CLI, which has no access to core or
common utils.
2020-09-23 19:52:37 -03:00
ghubstan
1431a076b2
Add license comment
2020-09-23 19:51:40 -03:00
ghubstan
adb175c21a
Add options helper for handling negative number CLI params
2020-09-23 19:50:04 -03:00
ghubstan
d190d09e2b
Fix unnecessary use of fully qualified name
2020-09-22 22:58:32 -03:00
ghubstan
fc1f0bac60
Fix imports
2020-09-22 22:56:08 -03:00
ghubstan
70e3be0032
Add API CreateOfferTest case
2020-09-22 22:16:55 -03:00
ghubstan
3c0c443680
Change API's createoffer return value from bool to Offer
2020-09-22 22:13:42 -03:00
ghubstan
2b68e57273
Stub out createoffer method in CLI
2020-09-22 22:09:58 -03:00
ghubstan
92f36ed03a
Add get default payment acct helper
2020-09-22 22:08:01 -03:00
ghubstan
e63a6c5771
Remove comment
2020-09-22 18:45:50 -03:00
ghubstan
c4dd041d97
Don't use static boilerplate helpers if not necessary
2020-09-22 18:20:23 -03:00
ghubstan
1d88d27330
Remove final modifiers
2020-09-22 18:11:55 -03:00
ghubstan
6a5040228e
Add simple create payment acct test
...
And make test dispute agent registration work from static fixture
setup methods.
2020-09-22 18:05:09 -03:00
ghubstan
1f307c8263
Fix indentation
2020-09-22 16:31:31 -03:00
ghubstan
8896372a0f
Move test dispute agent type constants to core
...
The string constants deleted from the test case are re-defined as enums,
but the test harness still passes around strings (enum.name()) because
the handling of invalid dispute agent type string args needs to be
tested. (Reminder: CLI does not accept any enum arguments.)
2020-09-22 15:31:38 -03:00
ghubstan
34cfe9532f
Remove comment
2020-09-22 14:51:31 -03:00
ghubstan
9132722bbf
Replace hardcoded version with Version.java value
...
Bats version check tests now use a bash script for parsing
the value from the Bisq class file, and these test cases
no longer need to be manually updated.
2020-09-22 14:45:21 -03:00
Christoph Atteneder
e3b3c625b3
Merge pull request #4548 from ghubstan/use-legacyaddress-frombase58
...
Remove unused, broken accessor
2020-09-22 16:32:50 +02:00
Christoph Atteneder
71373741da
Merge pull request #4547 from wiz/reduce-logging-for-statsnode
...
Set btcdcli4j loglevel to WARN for statsnode entrypoint, fixes #4537
2020-09-22 16:24:20 +02:00
Christoph Atteneder
44bf29b67e
Merge pull request #4546 from oscarguindzberg/code-cleanup
...
Minor code cleanup changes
2020-09-22 16:23:31 +02:00
Christoph Atteneder
64d4b9b136
Merge pull request #4544 from oscarguindzberg/removeListeners
...
Remove unnecessary listeners in TransactionsView
2020-09-22 16:22:37 +02:00
Christoph Atteneder
69d533d9ea
Merge pull request #4520 from cd2357/show-qubes-info-popup
...
Show info popup if Bisq started under Qubes OS
2020-09-22 16:21:03 +02:00
ghubstan
86c62c1333
Revert WalletService change (accessor breaks build)
...
The accessor added in commit e2bd89f
2020-09-22 11:16:53 -03:00
sqrrm
3d07c064e4
Merge pull request #4534 from ghubstan/daemon-status-scratch
...
Give core api a simple way to verify init status
2020-09-22 11:41:12 +02:00
sqrrm
c814e3b8ed
Merge pull request #4540 from ghubstan/remove-strings
...
Reduce apitest harness' dependency on string matching
2020-09-22 11:39:32 +02:00
sqrrm
dee92670c5
Merge pull request #4539 from ghubstan/refactor-bisqdaemonmain
...
Refactor API & add registerdisputeagent method to CLI
2020-09-22 11:37:18 +02:00
wiz
ca00433492
Set btcdcli4j loglevel to WARN for statsnode entrypoint, fixes #4537
2020-09-22 06:30:14 +09:00
Oscar Guindzberg
64dc4fbf84
Remove unused code from WalletConfig
2020-09-21 18:22:41 -03:00
Oscar Guindzberg
6cf7a9977a
Code cleanup
2020-09-21 17:32:47 -03:00
Oscar Guindzberg
c890d3c02a
Remove unused code
2020-09-21 17:19:01 -03:00
Oscar Guindzberg
992441b9b5
Remove unnecessary listeners
2020-09-21 16:52:16 -03:00
Christoph Atteneder
6af2a46e49
Merge pull request #4542 from chimp1984/refactor-regexvalidator
...
Refactor regexvalidator
2020-09-21 20:16:53 +02:00
Christoph Atteneder
0cb70da265
Merge pull request #4509 from oscarguindzberg/extract_to_segwit
...
Extract btc to segwit addresses
2020-09-21 19:54:31 +02:00
