ghubstan
2e9e51eb41
Remove GetTradeStatistics service from grpc.proto
...
This protobuf definition and service stub has been in place since
the start of work on the API, but was never fully implmented, nor
intended to be included in the API beta & v1 releases.
Its presence added a useless section to the gRPC API Reference doc.
https://ghubstan.github.io/slate
Based on branch `7-more-grpcproto-comments`,
PR https://github.com/bisq-network/bisq/pull/6068 .
2022-02-26 11:11:26 -03:00
ghubstan
c0631eb31f
Fix file/merge conflict
2022-02-25 20:51:55 -03:00
Stan
1499465c11
Merge branch 'master' into 7-more-grpcproto-comments
2022-02-25 20:46:05 -03:00
ghubstan
66c04134fc
Check offer exists before trying to take it
...
This was overlooked in tests, but client might use a bad offer-id param.
2022-02-25 18:51:07 -03:00
Christoph Atteneder
c0ab215388
Merge pull request #6078 from jmacxx/5396_privacy_enhancement
...
[1.8.3] Clear sensitive dispute data based on dispute opening date.
2022-02-25 17:29:02 +01:00
jmacxx
327ea680ac
Clear sensitive dispute data based on dispute opening date.
...
Change recommended setting for sensitive data clearing to 60 days.
2022-02-25 09:49:36 -06:00
Christoph Atteneder
5824c9cabb
Merge pull request #6076 from jmacxx/5396_privacy_enhancement
...
[1.8.3] Keep first dispute chat msg when clearing sensitive data.
2022-02-25 16:01:25 +01:00
jmacxx
f430243b5e
Keep first dispute chat msg when clearing sensitive data.
...
Fixes https://github.com/bisq-network/bisq/pull/6001#issuecomment-1049710029
2022-02-24 11:44:36 -06:00
ghubstan
5e754a25a1
Fix comment
2022-02-24 08:28:36 -03:00
Christoph Atteneder
4eada6fc76
Merge pull request #6055 from ghubstan/1-prep-for-offer-service-proto-changes
...
Prepare API Offers .proto defs for significant changes [#1 ]
2022-02-24 10:59:37 +01:00
Christoph Atteneder
7409b2b573
Merge pull request #6074 from ghubstan/fix-mistake-in-api-beta-guide
...
Fix BSQ swap description of BTC price for 1 BSQ
2022-02-24 09:53:06 +01:00
ghubstan
dd7d803053
Fix BSQ swap description of BTC price for 1 BSQ
2022-02-23 19:44:25 -03:00
Christoph Atteneder
07f0e70731
Merge pull request #6072 from jmacxx/5396_privacy_enhancement
...
[1.8.3 fix] Get payment method ID from offerPayload pt.II
2022-02-23 15:42:54 +01:00
jmacxx
70752a1ffd
Get payment method ID from offerPayload.
...
Another problem with closed trades older than v1.7.0.
The payment method ID can always be obtained from offerPayload.
2022-02-21 23:22:54 -06:00
Christoph Atteneder
da25c058a1
Merge pull request #6070 from jmacxx/fix_issue_6059
...
Disable roll over popups in combobox item renderers.
2022-02-21 20:23:55 +01:00
Christoph Atteneder
d12a13b1a1
Merge pull request #6069 from jmacxx/5396_privacy_enhancement
...
[1.8.3 fix] Get payment method ID from offerPayload
2022-02-21 20:22:59 +01:00
jmacxx
a9630feb19
Disable roll over popups in combobox item renderers.
...
Due to JFX bug https://bugs.openjdk.java.net/browse/JDK-8265835
2022-02-21 12:54:51 -06:00
jmacxx
f3dfc14779
Get payment method ID from offerPayload.
...
Was getting an NPE with closed trades older than v1.7.0.
makerPaymentMethodId was new at that point (null for older trades).
makerPaymentAccountPayload can be null for trades where we have
removed account info for privacy reasons (see #6001 ).
The payment method ID can always be obtained from offerPayload.
2022-02-21 10:59:32 -06:00
Christoph Atteneder
b739b4c347
Merge pull request #6063 from jmacxx/bsq_swap_improve_dao_errmsg
...
Improve BSQ swap error messaging & DAO resync popup.
2022-02-21 14:50:31 +01:00
Christoph Atteneder
737faa6443
Merge pull request #6064 from xyzmaker123/fix-parser
...
Fix bug with text rendering on trade step info
2022-02-21 14:49:46 +01:00
Christoph Atteneder
e293437826
Merge pull request #6067 from jmacxx/copy_popup_to_clipboard
...
Cosmetic cleanup for popup message copy function.
2022-02-21 14:49:11 +01:00
ghubstan
464c5a81c9
Be consistent in use of apostrophe
2022-02-21 08:13:13 -03:00
ghubstan
6e56660394
Fix comment error
2022-02-21 08:09:42 -03:00
ghubstan
9f013bd6c2
Fix errors in comments
2022-02-21 08:00:31 -03:00
ghubstan
fcd9c7e4d3
Finish 1st full pass of documenting grpc.proto for API reference site
2022-02-21 07:48:02 -03:00
jmacxx
b54a85dca9
Omit copy icon for popups without any textual message.
2022-02-20 21:29:09 -06:00
ghubstan
8271920943
New comments through "message TxInfo { ... }"
2022-02-20 20:20:33 -03:00
ghubstan
5acef133ab
Delete dead code
2022-02-20 19:01:50 -03:00
ghubstan
fade8bc0d9
Show CLI gettrades' Deviation col-value with precision=2 (do something)
2022-02-20 18:52:56 -03:00
ghubstan
23303187be
Change mktPriceMarginOpt name to mktPriceMarginPctOpt
...
And validate the opt value.
2022-02-20 18:14:47 -03:00
ghubstan
8f93c27deb
Fix CLI gettrades' Deviation column value format (do nothing)
2022-02-20 18:11:24 -03:00
ghubstan
2febe6b327
Adjust apitest cases to new .proto *Pct field names
2022-02-20 15:22:40 -03:00
ghubstan
d2ba39b28c
Adjust cli module to new .proto *Pct field names
2022-02-20 15:21:13 -03:00
ghubstan
66c04bdf3d
Adjust core.api to new .proto *Pct field names
2022-02-20 15:19:32 -03:00
ghubstan
8408c093e0
Adjust GrpcOffersService to new .proto *Pct field names
2022-02-20 15:18:37 -03:00
ghubstan
5cc928a7e5
Disambiguate grpc.proto offer pct literal field names
...
Rename double marketPriceMargin -> marketPriceMarginPct.
Rename double buyerSecurityDeposit -> buyerSecurityDepositPct.
2022-02-20 15:16:02 -03:00
xyzmaker123
3b966d8740
Fix bug with text rendering on trade step info
2022-02-20 10:13:56 +01:00
jmacxx
a302380e1e
Improve BSQ swap error messaging.
...
Re-enable popup warning indicating when DAO needs to be resynced.
2022-02-19 22:15:13 -06:00
ghubstan
543c573998
Adjust apitest cases to TradeInfo .proto's price & volume type change
2022-02-19 15:17:38 -03:00
ghubstan
e49ab16a7a
Adjust cli to TradeInfo .proto's price & volume type change
...
Quite a bit of refactoring. A lot of number-string formatting was removed.
2022-02-19 15:16:32 -03:00
ghubstan
a0b68bc756
Adjust .proto wrappers to price & volume type change
...
Some minor refactoring included.
2022-02-19 15:09:16 -03:00
ghubstan
3b22aeeb98
Change TradeInfo .proto's price & volume fields to string
2022-02-19 15:06:42 -03:00
ghubstan
1a3622b9ec
Merge branch 'master' into 4-change-grpc-proto-volume-to-string
2022-02-18 16:56:19 -03:00
ghubstan
15f75eea3d
Add some asserts on volume/min-volume strings from server
2022-02-18 16:49:51 -03:00
ghubstan
31c8fbb679
Remove some dead code
2022-02-18 16:48:32 -03:00
ghubstan
2056e26384
Adjust cli module to grpc.proto::volume field type change (string)
2022-02-18 16:45:37 -03:00
ghubstan
d42c58073f
Change OfferInfo proto's volume fields' type to string
2022-02-18 16:43:23 -03:00
Christoph Atteneder
aaac08202e
Merge pull request #6052 from ghubstan/alt-fix-feeservice-npe-in-api
...
Fix API FeeService NPE (Alternate)
2022-02-18 17:07:30 +01:00
Christoph Atteneder
d7e8cbdf15
Merge pull request #6058 from xyzmaker123/fix-npe
...
Fix NPE issue when edit fresh account
2022-02-18 17:06:20 +01:00
xyzmaker123
d70397214f
Fix NPE issue when edit fresh account
2022-02-18 16:24:58 +01:00