mirrors/bisq
1
0
Fork 0
mirror of https://github.com/bisq-network/bisq.git synced 2024-11-19 09:52:23 +01:00
Code Issues Packages Projects Releases Wiki Activity
17,872 Commits 4 Branches 148 Tags 4.3 GiB
1280aa0e57
Commit Graph

7170 Commits

Author SHA1 Message Date
jmacxx
c404eb1e91
Support UI improvements (per bisq project 67). 2023-03-11 22:06:07 -06:00
Alejandro García
fe30b21643
Merge pull request #6599 from yonson2023/bm_distribution_report 
Add report showing monthly BTC paid to BurningMen.
 2023-03-11 15:12:40 +00:00
yonson2023
289f546f7f
Add report showing monthly BTC paid to BurningMen. 2023-03-07 18:34:42 -06:00
jmacxx
8a41637b58
Limit offer min/max amount deviation to 50%. 2023-02-27 20:24:52 -06:00
yonson2023
030bb3f64c
Payout tx confidence should be after block height of deposit. 2023-02-19 16:21:54 -06:00
Alejandro García
71615824a8
Merge pull request #6585 from yonson2023/fix_payment_started_bug 
Fix NPE at trade payment started event.
 2023-02-18 18:12:04 +00:00
Alejandro García
3dc3464114
Merge pull request #6581 from alvasw/rename_network_filter_to_ban_filter 
Rename NetworkFilter to BanFilter
 2023-02-15 18:24:55 +00:00
jmacxx
6801ebfbd7
Fix exception due to missing read lock. 2023-02-15 10:48:59 -06:00
yonson2023
9d4d575739
Fix NPE at trade payment started event. 2023-02-13 21:29:41 -06:00
Alva Swanson
d411ae1252
Remove unused ConnectionListener.onError(...) method 2023-02-12 20:44:38 +02:00
Alva Swanson
f9a0e5d6d0
Rename NetworkFilter to BanFilter 2023-02-12 20:30:58 +02:00
Alejandro García
581fbd1d2d
Merge pull request #6579 from stejbac/further-speed-up-transactions-view-load 
Further speed up transactions view load
 2023-02-12 14:05:36 +00:00
yonson2023
baad09bfc8
Fix unhandled exception when empty txId passed. 2023-02-11 08:55:08 -06:00
Steven Barclay
37b6a4becf
Cache formatters to speed up DisplayUtils.formatDateTime 
Make 'FormattingUtils.formatDateTime(Date, boolean)' two or three times
faster by caching the 'java.text.DateFormat' objects used to format the
given date & time in either the local or UTC time zone. Since these
formatters are not thread safe (though they may be reused), use a
ThreadLocal to store them (as a tuple, along with the current locale to
make sure it hasn't changed since the last invocation).

This is a minor hotspot for the Transactions view load, since the date
strings in TransactionsListItem are formatted eagerly (via DisplayUtils)
for the purpose of filtering the items by substring match. (Other list
views seem to format dates lazily, though it's possible that there will
be speedups elsewhere in the UI.)
 2023-02-11 15:47:04 +08:00
Alejandro García
b1e2cb03ad
Merge pull request #6568 from alvasw/gradle_apply_central_bisq_java_conventions 
Gradle apply central bisq java conventions
 2023-02-05 22:43:48 +00:00
Alejandro García
c61bd70ead
Merge pull request #6562 from alvasw/move_get_single_thread_executor_to_own_utils 
Move SingleThreadExecutors to its own Utils class
 2023-02-05 22:42:02 +00:00
Alva Swanson
53837bf00b
Move SingleThreadExecutors to its own Utils class 2023-02-05 22:11:35 +01:00
Alva Swanson
b2870ccee3
Delagate thread pool shutdown to Guava MoreExecutors 2023-02-05 22:09:56 +01:00
Alva Swanson
c1c4caf87f
Gradle: Apply bisq.java-conventions to all projects 2023-02-05 22:02:13 +01:00
Alejandro García
e6f2703738
Merge pull request #6557 from alvasw/export_json_files_service_shutdown_executor 
ExportJsonFilesService: Shutdown Executor
 2023-02-05 18:58:00 +00:00
Alva Swanson
7665780ca4
ExportJsonFilesService: Shutdown Executor 2023-02-05 13:36:09 +01:00
Alva Swanson
5506443d54
ScryptUtil: Fix thread leak 
Each time someone called the static method
ScryptUtil.deriveKeyWithScrypt(...) a new worker pool was created. The
worker pool was never shutdown.
 2023-02-05 13:31:15 +01:00
Alva Swanson
4779c82d0b
Fix BurningManAccountingStore data races 
Multiple threads read and write to the accounting blocks list causing
data races. Luckily, the LinkedList threw a ConcurrentModificationException
to limit damage. Now, a ReadWriteLock protects the LinkedList against
data races. Multiple threads can read the list at the same time but only
one thread can write to it. Other writing threads wait until it's their
turn.

Fixes #6545
 2023-02-03 23:41:51 +01:00
Alejandro García
f24e0f231d
Merge pull request #6548 from alvasw/fix_dao_state_storage_service_shutdown_data_corruption_bug 
DaoStateStorageService: Fix shutdown data corruption bug
 2023-02-03 15:14:44 +00:00
Alejandro García
2239924225
Merge pull request #6552 from stejbac/speed-up-closed-trades-view-load 
Speed up loading and scrolling of trade history
 2023-02-03 15:13:58 +00:00
Alejandro García
27613de363
Merge pull request #6546 from jmacxx/offer_availability_dao_sync_check 
Maker check DAO health when handling OfferAvailabilityRequest.
 2023-02-03 15:10:57 +00:00
Steven Barclay
57b2b4b864
Add txs-by-id cache to WalletService to speed up trade history view 
Add a third cache to WalletService, cleared upon wallet change events,
which maps txIds to txs. This allows the speedup of repeated calls to
'WalletService.getConfidenceForTxId', by avoiding the need to copy and
scan the entire set of wallet txs to find the one with matching id,
for each method invocation.

This is mainly to provide a further speedup to the closed-trades-view
load, by making it much faster to filter the list of BSQ swap trades by
tx confirmation status in 'ClosedTradesDataModel.applyList' and
'ClosedTradesManager.getNumPastTrades'.
 2023-02-01 23:02:25 +08:00
Steven Barclay
42ea12f74c
Rename WalletService.getAddressToMatchingTxSetMultiset to multimap 
The return value is a (cached) SetMultimap, not a multiset.
 2023-02-01 20:48:32 +08:00
Steven Barclay
f02bc787d5
Optimize 'getNumPastTrades' to speed up trade history view 
Reduce a bottleneck in the closed-trades-view load & table scrolling,
caused by a call to 'ClosedTradesManager.getNumPastTrades' for each
list item displayed. This repeatedly scans the entire collection of
closed trades and BSQ swap trades, in order to count all those which
share a given peer node address. (Scanning the BSQ swap trades is
particularly slow due to their filtering by tx confirmation status.)

To this end, cache the counts of trades by peer node address with a
nullable Multiset field in ClosedTradesManager & BsqSwapTradeManager,
so that the trades are scanned at most once when the view loads. Add
listeners to clear the respective cache when the trade list changes or
the BSQ wallet txs change.
 2023-02-01 19:59:48 +08:00
Alva Swanson
d9372f3a4c
XmrTxProofRequest: Shutdown executor service in terminate() 2023-01-31 17:21:34 +02:00
Alva Swanson
1066e83a27
DaoStateStorageService: Fix shutdown data corruption bug 
The DaoStateStorageService submits tasks to a daemon thread executor
service. The JVM continues to execute threads until all non-daemon
threads have terminated. So the JVM will kill the DaoStateStorageService
during write requests leading to data corruption.

This change uses a non-daemon thread executor service at waits during
shutdown until all data is written to disk.
 2023-01-31 16:04:06 +02:00
jmacxx
d43a0e42cf
Maker check DAO health when handling OfferAvailabilityRequest. 2023-01-29 21:46:56 -06:00
Alejandro García
f43b5fe04b
Merge pull request #6544 from jmacxx/fix_withdrawal_fee_estimation 
Fix withdrawal fee calculation & the min relay fee problem.
 2023-01-28 19:25:06 +00:00
Alejandro García
71c05f6ac2
Merge pull request #6541 from alvasw/dao_state_storage_service_do_not_call_executor_service_shutdown_twice 
DaoStateStorageService: Don't call executorService.shutdown() twice
 2023-01-28 19:23:23 +00:00
jmacxx
efac12e8ce
Fix withdrawal fee calculation & the min relay fee problem. 2023-01-27 12:02:02 -06:00
Alva Swanson
eca9aedaa7
DaoStateStorageService: Don't call executorService.shutdown() twice 
MoreExecutors.shutdownAndAwaitTermination(executorService, ...) calls
executorService.shutdown() before starting its force shutdown timer.
 2023-01-27 16:28:44 +02:00
Alva Swanson
6a8fb05156
Centralize all ExecutorService creations in Utilities 2023-01-27 16:15:24 +02:00
Alejandro García
d682d956a1
Merge pull request #6539 from HenrikJannsen/improve_price_feed_service 
Improve price feed service
 2023-01-27 13:45:08 +00:00
HenrikJannsen
fa03f16917
Use auto-indexed thread name as prefix for thread name 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-26 12:27:30 +08:00
Alejandro García
74e1078318
Merge pull request #6527 from yonson2023/disk_space_warning 
Warn user when free disk space is too low.
 2023-01-24 16:17:11 +00:00
HenrikJannsen
2f36eadbca
Do not start new retry with new provider timer if one is still running. 
Change log level as it is an expected case at repeated requests.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-24 13:04:17 +08:00
yonson2023
f3a19b9d00
Apply code review suggestions. 2023-01-23 20:28:53 -06:00
Alejandro García
e9ea270908
Merge pull request #6528 from jmacxx/fix_issue_6517 
Refactor closing ticket logic.
 2023-01-23 14:52:43 +00:00
Alejandro García
29e0088032
Merge pull request #6533 from jmacxx/fee_reimbursement_message 
Fee reimbursement message ref to bisq.wiki.
 2023-01-22 21:15:27 +00:00
jmacxx
05273a7bdf
Fee reimbursement message ref to bisq.wiki. 2023-01-22 13:51:54 -06:00
Devin Bileck
18b65681f7
Remove clearnet address for BTC node "devinbtcyk" 
I switched hosts and currently do not have an accessible clearnet address.
 2023-01-20 15:24:53 -08:00
jmacxx
3dde7c6261
Refactor closing ticket logic to fix #6517. 2023-01-18 08:27:46 -06:00
yonson2023
fc2166e1a6
Warn when free disk space is too low. 2023-01-17 14:20:56 -06:00
Alejandro García
975210d228
Merge pull request #6515 from HenrikJannsen/distribute_evenly_restart_of_seed_nodes 
Distribute evenly restart time
 2023-01-12 16:34:47 +00:00
Alejandro García
d859f391bf
Merge pull request #6510 from HenrikJannsen/improve_connection_logs 
Improvements in connection and increase timeout
 2023-01-12 16:33:40 +00:00
Alejandro García
fda3c45008
Merge pull request #6501 from HenrikJannsen/always_include_high_prio_payload_in_get_data_response 
Always include high prio payload in get data response
 2023-01-12 16:33:08 +00:00
HenrikJannsen
116118a451
Distribute evenly restart time 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-10 11:55:27 -05:00
HenrikJannsen
7387b3ac2d
Increase timeout at RequestStateHashesHandler from 2 min. to 3 min 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-06 20:19:55 -05:00
HenrikJannsen
bc5045dd28
Force rebuild at CI 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-06 13:24:17 -05:00
HenrikJannsen
fa82990e6e
Handle DPT_MIN_REMAINDER_TO_LEGACY_BM with isHotfixActivated param 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-06 13:19:59 -05:00
HenrikJannsen
b872683b60
Use trade date for check if hotfix is activated at refund managers DPT verification 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-06 13:10:12 -05:00
HenrikJannsen
9dc79fdcd4
Add checks if hot fix is activated for 2 other changes made since 1.9.8 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-06 10:03:39 -05:00
Alejandro García
be1691ba0c
Merge pull request #6505 from HenrikJannsen/use_thread_for_processing_BM_AccountingBlocks 
Run processAccountingBlocks async in forkjoinpool thread
 2023-01-06 14:09:35 +00:00
Alejandro García
dda32c09ff
Merge pull request #6504 from HenrikJannsen/add_check_for_isInConflictWithSeedNode 
Add check for dao state hash conflict with seed node
 2023-01-06 14:09:01 +00:00
HenrikJannsen
7977c8670a
Cleanup 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-05 22:25:31 -05:00
HenrikJannsen
8b0f8fbead
Cleanup 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-05 22:18:10 -05:00
HenrikJannsen
41a63cc8a5
Add handling of miner fee in case there is only the legacy BM 
Use spendableAmount instead of inputAmount at maxOutputAmount

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-05 22:04:23 -05:00
HenrikJannsen
bb06f64049
Add complete call 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-05 22:04:23 -05:00
HenrikJannsen
bc91914cb0
Change log level 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-05 14:48:51 -05:00
HenrikJannsen
093e8f99f4
Remove unused methods 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-05 11:41:11 -05:00
HenrikJannsen
13180ddc30
Improve DaoPresentation and add handler for daoStateHash updates 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-05 11:21:01 -05:00
HenrikJannsen
1e2f48b9bc
Rename isDaoStateIsInSync to isDaoStateReadyAndInSync 
Add daoStateService.isParseBlockChainComplete() check

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-05 10:42:59 -05:00
HenrikJannsen
b33c610015
Add CheckIfDaoStateIsInSync task in trade protocol as first task 
Add ifDaoStateIsInSync method to DaoFacade
Add ifDaoStateIsInSync to logs if DPT verification fails
 2023-01-05 10:39:24 -05:00
HenrikJannsen
be33aa5236
Add chain heights to logs 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-05 10:22:50 -05:00
HenrikJannsen
f4d335b624
Improve logs 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-05 10:18:42 -05:00
HenrikJannsen
02093b986b
Improve log 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-05 10:06:49 -05:00
HenrikJannsen
ea285e6ad1
Run processAccountingBlocks async in forkjoinpool thread 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-04 20:52:22 -05:00
HenrikJannsen
819c6fb200
Combine nested if statements 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-04 19:30:02 -05:00
HenrikJannsen
5542ea23ec
Add custom getGetDataResponsePriority methods 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-04 18:25:17 -05:00
HenrikJannsen
5efd13a678
Check if setException returns false and if so, cancel future. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-04 18:09:04 -05:00
Alejandro García
9d820ba83e
Merge pull request #6495 from HenrikJannsen/fix_BM_collection_at_DPT 
Fix bug with calculating the miner fee for the DPT.
 2023-01-03 23:38:30 +00:00
HenrikJannsen
56377d8930
Reduce DPT_MIN_REMAINDER_TO_LEGACY_BM from 50k sat to 25k sat. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-03 17:32:10 -05:00
HenrikJannsen
a296887a73
Use getActiveBurningManCandidates for fee distribution 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-03 12:08:12 -05:00
HenrikJannsen
0c4199fef4
Fix but with calculating the miner fee for the DPT. 
Add activation date for hotfix.

We used all potential BM instead only the ones who have a positive cappedBurnAmountShare.
 2023-01-03 12:07:38 -05:00
HenrikJannsen
8bde140e3d
Add all addresses of all burningman who have burned BSQ to the list of addresses who are permitted to receive trade fees. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2023-01-02 17:01:38 -05:00
Alejandro García
1d669240d8
Merge pull request #6425 from jmacxx/fix_bsq_fee_validation 
Validate BSQ fee payment using DAO tx info.
 2022-12-29 20:12:38 +00:00
jmacxx
fa6beffa49
Apply code review changes. 2022-12-29 13:57:13 -06:00
Alejandro García
eef7846394
Merge pull request #6487 from HenrikJannsen/reset_pending_trade_protocol_of_same_offer 
Reset pending trade protocol of same offer
 2022-12-29 15:02:36 +00:00
HenrikJannsen
42dc0b5b79
Merge branch 'add_higher_capacity_for_write_to_json_thread_pool' into seednodes 2022-12-28 12:11:05 -05:00
HenrikJannsen
5ff7be9208
Increase capacity for thread pool queue at ExportJsonFilesService 
One seed node using the ExportJsonFilesService had RejectedExecutionExceptions as before we had only permitted a thread pool queue capacity of 1.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-28 12:09:59 -05:00
HenrikJannsen
5b38e5b83b
Allow to set fullNode if isBmFullNode and rpcDataSet is true even if BurningManService.isActivated() is false. 
This allows us to run the seed nodes already in BM mode before activation

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-27 18:40:38 -05:00
HenrikJannsen
9a31606fea
Make codacy happy 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-27 17:54:11 -05:00
HenrikJannsen
e1d8d0a6a0
Make codacy happy 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-27 17:54:11 -05:00
HenrikJannsen
7f16e874d2
Improve shutdown at dao nodes 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-27 17:54:10 -05:00
HenrikJannsen
0b33a12c19
Change visibility, make isShutdownInProgress volatile 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-27 17:54:09 -05:00
HenrikJannsen
d5b4ce275b
Add support for listeners when GetDataResponse and GetBlocksResponse are sent. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-27 17:54:08 -05:00
HenrikJannsen
3f4a069202
Add reset method to trade protocol. 
Add map for maintaining pending protocols by offerID.

Fixes a bug when the same taker got an early failure in a take offer attempt before the maker removes the offer and the taker did not persist the failed trade, thus the protection to not be permitted to take the same offer after a failure does not prevent another take offer attempt of the same taker. In such a case the maker has the old pending protocol listening for the trade messages and both the old and new protocol instance process those messages. In case the model data has changes (e.g. diff. inputs) this can cause a failed trade.
We do not remove the message listeners on failures to tolerate minor failures which can be recovered by resend routines.
There could be more solid fixes for that issue but this approach seems to carry less risks.
 2022-12-26 14:07:14 -05:00
HenrikJannsen
72b55f429a
Move log before super handler to maintain correct order of logs 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-26 12:30:07 -05:00
HenrikJannsen
4fb0420712
Remove price node and seed nodes of @miker and @mrosseel 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-20 19:40:59 +01:00
Christoph Atteneder
d99452c978
Not use additional -%d in name format because of refactoring 2022-12-20 11:36:42 +01:00
jmacxx
9f8b3df1ac
Base initial limit from users max past trade size if applicable. 2022-12-19 16:49:39 +01:00
HenrikJannsen
8eb555df8f
Add INVALID_SNAPSHOT_HEIGHT to AvailabilityResult. 
Use AvailabilityResult.INVALID_SNAPSHOT_HEIGHT instead of AckMessage with error.
Show description in error popup instead of enum name.
Return PRICE_CHECK_FAILED instead of UNKNOWN_FAILURE at error at price check also for non api users.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 09:32:00 +01:00
HenrikJannsen
0b849800f9
Fix test 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 09:32:00 +01:00
HenrikJannsen
bd85958c9e
Add sanity check for a min. block height for the snapshot height 
We don't allow to get further back than 767950 (the block height from Dec. 18th 2022)

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 09:32:00 +01:00
HenrikJannsen
f834fbdda6
Add sanity check that max share of a non-legacy BM is 20% over MAX_BURN_SHARE (taking into account potential increase due adjustment) 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 09:31:59 +01:00
HenrikJannsen
618e610f3e
Exclude legacy BM from DAO balance 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 09:31:59 +01:00
HenrikJannsen
109c200650
Add balance fields for DAO revenue with total burned BSQ and total distributed BTC/BSQ 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 09:31:59 +01:00
HenrikJannsen
2be5d2fbd8
Increase GENESIS_OUTPUT_AMOUNT_FACTOR and ISSUANCE_BOOST_FACTOR 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 09:31:59 +01:00
HenrikJannsen
c268cc46cb
Add new average bsq price after historical data 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 09:31:58 +01:00
HenrikJannsen
a76267b6f3
Use static fields for opReturnData instead of hardcoded mainnet hashes 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 09:31:58 +01:00
HenrikJannsen
16bfdd6154
Remove regtest value for DEFAULT_ESTIMATED_BTC_TRADE_FEE_REVENUE_PER_CYCLE 
Adjust reimbursement amounts as we do not reimburse 100% of the DPT

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 09:31:57 +01:00
HenrikJannsen
80063d735c
Add custom handling of legacy BM. 
Refactoring: rename variables

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 09:31:57 +01:00
HenrikJannsen
1aa5a9b17a
Don't allow the myBurnAmount to be larger than the upperBaseTarget 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 09:31:56 +01:00
HenrikJannsen
7eed7a4cda
In case we have capped burn shares we redistribute the share from the over-burned amount to the non capped candidates. 
This helps to avoid that the legacy BM would get the rest in case there are capped shares.
It still can be that a candidate exceeds the cap and by the adjustment becomes capped. We take that into account and the legacy BM would get some share in that case.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 09:31:56 +01:00
HenrikJannsen
709f0e1b85
Change burn target calculation. 
Left side is amount to burn to reach the max allowed receiver share based on the burned amount of all BM.
The right side is the amount to burn to reach the max allowed receiver share based the boosted max burn target.

Increase ISSUANCE_BOOST_FACTOR from 3 to 4.

Add help overlay to burn target table header.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 09:31:56 +01:00
jmacxx
9ce2964ff4
Fix divide by zero errors in Trade history summary. 2022-12-19 09:28:42 +01:00
sqrrm
1cf51be56c
Update sqrrm provided btc onion addresses 2022-12-19 09:28:21 +01:00
HenrikJannsen
ddf5239800
Increase timeouts from 3 to 4 min. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 09:27:44 +01:00
HenrikJannsen
6aad3a8dc5
Reduce getDataResponse size from 9 MB to 6 MB 
Reduce number of blocks at GetBlocksResponse from 4000 to 3000

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-19 09:27:27 +01:00
Christoph Atteneder
afba2f22b9
Update bitcoinj checkpoints for v1.9.7 2022-12-14 11:12:49 +01:00
Christoph Atteneder
72dea08473
Update translations for v1.9.7 2022-12-14 10:39:28 +01:00
Christoph Atteneder
5dea677644
Merge pull request #6459 from HenrikJannsen/handle_exception_at_send 
Handle exception at send
 2022-12-14 10:20:07 +01:00
Christoph Atteneder
71d6e126dd
Merge pull request #6423 from HenrikJannsen/add-burningman-accounting 
Add burningman accounting
 2022-12-14 10:17:38 +01:00
HenrikJannsen
8c65da9c85
Add thread index format 
Add name param to newCachedThreadPool

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-13 20:35:49 -05:00
HenrikJannsen
d4b6965348
Use networkNode.sendMessage instead of connection.sendMessage as the call on connection is blocking. 
This was likely a major bug for seed nodes that at sending hash responses the main thread got blocked.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-13 16:25:39 -05:00
HenrikJannsen
1b10cc22db
Refactor: Move monitor package from core to seedNode and rename to reporting 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 17:10:02 -05:00
HenrikJannsen
21c6c52ec8
Make fields final. 
Remove setter of key.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 17:02:30 -05:00
Alejandro García
4f34be0a33
Merge pull request #6452 from ripcurlx/update-app-signatures 
Update app signatures for v1.9.7
 2022-12-11 18:36:00 +02:00
Alejandro García
77afb2d62c
Merge pull request #6450 from jmacxx/dispute_min_payout 
Change minimum payout at mediation from 2.5% to 5% of trade amount.
 2022-12-11 18:26:56 +02:00
HenrikJannsen
e57af6e8e8
Update mediation popup text 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:19 -05:00
HenrikJannsen
b7d5af18b0
Add MAX_BURN_TARGET_LOWER_FLOOR to avoid cases where small burn amounts lead to deadlock situations. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:19 -05:00
HenrikJannsen
46b2cf914b
Remove DevEnv.isDevTesting 
Add check for number of confirmations in devMode to show support button after 5 blocks

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:19 -05:00
HenrikJannsen
e3a0ae9425
Use constants for opReturn data. Rename hash to opReturnData. 
Update UI.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:18 -05:00
HenrikJannsen
1bb4b55220
Add BurningManAccountingStore resource file. 
Use resourceDataStoreService and extend StoreService

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:18 -05:00
HenrikJannsen
446762f02c
Add BM account UI 2022-12-11 11:15:17 -05:00
HenrikJannsen
a9bf52d26c
Add BurningMan accounting domain 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:17 -05:00
HenrikJannsen
22c43769bd
Add BurningManAccountingService to CorePersistedDataHost 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:17 -05:00
HenrikJannsen
90550dee3f
Add messages and domain data for accounting domain 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:17 -05:00
HenrikJannsen
d4a0032965
Add new fields and methods 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:17 -05:00
HenrikJannsen
f9db6e0d5c
Add support for multiple clients adding a block handler. 
Add requestRawDtoBlock method.
Rename to make different block types more clear.
Change visibility
 2022-12-11 11:15:17 -05:00
HenrikJannsen
a551a41e5a
Add support for multiple clients calling the setup method. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:17 -05:00
HenrikJannsen
e2f7c4e103
Make AveragePriceUtil.getAveragePriceTuple mor flexible 
Add filter for before date

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:16 -05:00
HenrikJannsen
bc9ccfd0e9
Add String formatCoin(long value) API to CoinFormatter 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:16 -05:00
HenrikJannsen
2615309931
Add Config options 2022-12-11 11:15:16 -05:00
HenrikJannsen
adb02428ee
Remove unused var 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:16 -05:00
HenrikJannsen
d12c8b5fc4
Remove TODO, rename method 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:16 -05:00
HenrikJannsen
97ba1560be
Improve receiver distribution to avoid that legacy BM gets outputs if some outputs fall below the min. amount limit. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:16 -05:00
HenrikJannsen
fa4c952409
Apply code review feedback 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:15 -05:00
HenrikJannsen
eeaafc1e04
Use HashSet instead Lists. 
Remove sorting as not needed.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:15 -05:00
HenrikJannsen
7cbc5d6263
Increase ISSUANCE_BOOST_FACTOR to 3 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:15 -05:00
HenrikJannsen
4ce6ce745a
Add check for isActivated and if not return LEGACY_BURNING_MAN_BTC_FEES_ADDRESS 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:15 -05:00
HenrikJannsen
4e08bcd53d
Split up legacy BM into DPT and BTC fee BM 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:15 -05:00
HenrikJannsen
d30ec07d94
Cleanup/add comments 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:15 -05:00
HenrikJannsen
8ab2582db6
Use check for isRegtest instead of test for isDevTesting to set dev parameters 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:15 -05:00
HenrikJannsen
0e79582819
Refactoring: Move isActivated method to BurningManService 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:14 -05:00
HenrikJannsen
dff6d48333
Refactoring: Move BM model classes into model package. Adjust visibility. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:14 -05:00
HenrikJannsen
c1dc317783
Remove unused methods 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:14 -05:00
HenrikJannsen
d31493b1e9
Use TradeWalletService.MIN_DELAYED_PAYOUT_TX_FEE as min value for miner fee in DelayedPayoutTxReceiverService.getSpendableAmount 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:14 -05:00
HenrikJannsen
d4646cc19f
Add LegacyBurningMan to UI 
It is not included in BurningManCandidate candidate map as that would complicate things.
We only want to show it in the UI for informational purposes.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:14 -05:00
HenrikJannsen
883b0542a1
Fix getSnapshotHeight method 
For chainHeights < genesisHeight+3*grid we ended up with future chainHeights

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:14 -05:00
HenrikJannsen
2b4b6fe715
Add logs for delayedPayoutTx receiver data 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:13 -05:00
HenrikJannsen
b7a5b569ca
Add legacy burningman to btc fee distribution in case we do not reach 100% from capped burn shares. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:13 -05:00
HenrikJannsen
c1b8871fda
Fix burn target calculations 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:13 -05:00
HenrikJannsen
3a7af07e86
Improve burn target calculation and display 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:13 -05:00
HenrikJannsen
c747a486a7
Fix duration calculations 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:13 -05:00
HenrikJannsen
3213c5e770
Avoid negative cycle index 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:13 -05:00
HenrikJannsen
683bc409c7
Use cycles for periods instead of blocks in months/years. 
A cycle is the fundamental unit in the DAO, months/years have no relevance, so using
cycles as base helps avoids some potential weird behaviour with data getting updated at cycle events.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:13 -05:00
HenrikJannsen
2799ccabad
Add util class for cycle related methods with caching 
Add getCycleAtIndex convenience method to DaoStateService

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:12 -05:00
HenrikJannsen
516004dfaf
Change ISSUANCE_BOOST_FACTOR to 3 
Use lower dev test value for BURN_TARGET_BOOST_AMOUNT

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:12 -05:00
HenrikJannsen
1e8ec6f206
Add details if donationAddressOfDelayedPayoutTx check fails 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:12 -05:00
HenrikJannsen
625939b0f9
Bugfix: set burningManSelectionHeight and tradeTxFee at dispute clone 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:12 -05:00
HenrikJannsen
a6a018883d
Add isDevTesting method for adjusting behaviour for dev testing purposes 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:12 -05:00
HenrikJannsen
4e25d2f253
Add isDevMode check to set dev params 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:12 -05:00
HenrikJannsen
402c4075d0
Add option to add opReturn data at BSQ wallet send screen for non-BSQ balance. 
This can be used for providing proof of ownership of a genesis output when attaching a custom BM receiver address.
See: https://github.com/bisq-network/proposals/issues/390#issuecomment-1306075295

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:11 -05:00
HenrikJannsen
78d3fd8d44
Fix wrong initial value. 
For myGenesisOutputNames we check for null not Optional.empty as empty is a valid case and we do not
want to wrap the optional field into another Optional.
Also myCompensationRequestNames is using a null check and gets reset to null instead of an
empty set as the empty set is a valid case as well.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:11 -05:00
HenrikJannsen
88cf28c526
Add applyBlock method and call at constructor (some classes get not initiated at app startup but created by UI activity). 
Remove accumulatedDecayedBurnAmount at getAllowedBurnAmount. Was incorrect.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:11 -05:00
HenrikJannsen
fb51861c4b
Use months and not cycles for burn target and average. 
Add checks for chainHeight to make code more generic (in the current usage its always last block anyway)

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:11 -05:00
HenrikJannsen
befe166bc7
Refactor out fields from BurningManCandidate which are not affecting data for delayed payout tx receivers. 
This allows to split off the burn target related code to separate classes.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:11 -05:00
HenrikJannsen
52d48eb90a
Rename getDelayedPayoutTxReceivers to getReceivers 
Cleanup

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:10 -05:00
HenrikJannsen
f0faa44804
Remove Current from method names 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:10 -05:00
HenrikJannsen
7724b5b3ea
Rename getBtcFeeReceiverAddress to getAddress 
Cleanup

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:10 -05:00
HenrikJannsen
92b38ed20f
Move BurningManUtil.getLegacyBurningManAddress to BurningManService. 
Remove BurningManUtil

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:10 -05:00
HenrikJannsen
508081ad16
Rearrange methods 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:10 -05:00
HenrikJannsen
ec25722d08
Split up calculateShare into 4 distinct methods 
Reduce visibility to package scope

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:10 -05:00
HenrikJannsen
3fda949526
Add sorting for output index needed for genesis tx outputs. 
Use static factory methods for the 2 diff. use cases of CompensationModel.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:10 -05:00
HenrikJannsen
22f7b089f4
Remove reference to delayedPayoutTxReceiverService and btcFeeReceiverService inside BurningManService. 
Use DelayedPayoutTxReceiverService and BtcFeeReceiverService in client code instead of BurningManService.
Make BurningManService package private.
 2022-12-11 11:15:09 -05:00
HenrikJannsen
40a03ebdc5
Move getAverageDistributionPerCycle to BurningManService and use from BurningManInfoService. 
Remove reference to BurningManInfoService inside BurningManService.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:09 -05:00
HenrikJannsen
559ba6e9b9
Refactor BurningManService 
Split up into 4 service classes
- BurningManService: Common stuff
- BurningManInfoService: For displaying BurningMan data
- BtcFeeReceiverService: For getting btcFeeReceivers
- DelayedPayoutTxReceiverService: For getting delayedPayoutTxReceivers. This is the critical part where we need to have a deterministic data and which could break trade consensus.

WIP refactoring. More to come...

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:09 -05:00
HenrikJannsen
19067acbcd
Cleanup 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:09 -05:00
HenrikJannsen
7407ab87f9
Subtract accumulatedDecayedBurnAmount from allowedBurnAmount 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:09 -05:00
HenrikJannsen
58cabfaaf6
Add expectedRevenue to BurningManCandidate. 
Add getAverageDistributionPerCycle method to BurningManService.
Show receiver address when BM is selected.
Refactor code, cleanups, UI improvements.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:09 -05:00
HenrikJannsen
731363d128
Sort getBtcFeeReceiverAddress by amount and address. 
Increase minOutputAmount to 1000 sat.
Cleanups

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:08 -05:00
HenrikJannsen
02a163f2f1
Fix handling of null entries in getBtcFeeReceiverAddress method 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:08 -05:00
HenrikJannsen
e16a9b00b1
Add verifyDelayedPayoutTxReceivers method in RefundManager. 
Add burningManSelectionHeight and tradeTxFee in Dispute.
Call validateDonationAddressMatchesAnyPastParamValues and validateDonationAddress
only if legacy BM was used.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:08 -05:00
HenrikJannsen
060b9c476e
Validate delayedPayoutTx outputs size and amount only if BurningManService.isActivated is false. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:08 -05:00
HenrikJannsen
7b280c4a99
Use Burningmen receivers for delayed payout tx. 
Add verification by re-creating receivers and check txId of both DPTs.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:08 -05:00
HenrikJannsen
eee0b691d0
Remove FeeReceiverSelector and test as not used anymore 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:08 -05:00
HenrikJannsen
e2ce053a01
Add burningManSelectionHeight fields to OfferAvailabilityRequest, InputsForDepositTxRequest and ProcessModel. 
Use BurningManService.getBtcFeeReceiverAddress at createFeeTx tasks.
Verify takers burningManSelectionHeight if BurningManService.isActivated at MakerProcessesInputsForDepositTxRequest and OpenOfferManager.
Stores burningManSelectionHeight in ProcessModel.
Add BurningManService fields to OfferAvailabilityModel, PlaceOfferModel, OpenOfferManager and Provider

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:07 -05:00
HenrikJannsen
39a49adb92
Add Burningman UI 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:07 -05:00
HenrikJannsen
739ff8e447
Add BurningMan domain 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:07 -05:00
HenrikJannsen
ea5662f84d
Add new methods to DaoStateService and DaoFacade. 
Will be used later by BurningMan domain.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:07 -05:00
HenrikJannsen
5c7a3308a7
Add burningManReceiverAddress as extraMap entry to CompensationProposal. 
We cannot add a new field as that would break DAO consensus.

Add optional text field for burningManReceiverAddress to CompensationProposal UI.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:07 -05:00
HenrikJannsen
09a1af8f2c
Add allowEmpty flag to InputValidator and BtcAddressValidator 
We will use that for the optional address field in compensation requests and interpret empty input as Optional.empty.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:06 -05:00
Alejandro García
6c7764fc33
Merge pull request #6451 from HenrikJannsen/avoid_sending_repeated_block_related_report_data 
Avoid sending repeated block related report data
 2022-12-11 17:38:00 +02:00
Stephan Oeste
9e50066567
Remove KanoczTomas Bitcoin node, because it is permanet offline. 2022-12-11 15:28:32 +01:00