HenrikJannsen
0a941c1719
Add custom handling of legacy BM.
...
Refactoring: rename variables
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-15 11:20:24 -05:00
HenrikJannsen
d585456732
Refactor: move out fields used the same way in both if/else branches.
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-15 11:18:54 -05:00
HenrikJannsen
7f73ef7cb5
Don't allow the myBurnAmount to be larger than the upperBaseTarget
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-14 21:48:58 -05:00
HenrikJannsen
d0539e17ef
In case we have capped burn shares we redistribute the share from the over-burned amount to the non capped candidates.
...
This helps to avoid that the legacy BM would get the rest in case there are capped shares.
It still can be that a candidate exceeds the cap and by the adjustment becomes capped. We take that into account and the legacy BM would get some share in that case.
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-14 21:44:54 -05:00
HenrikJannsen
4860c1177a
Change burn target calculation.
...
Left side is amount to burn to reach the max allowed receiver share based on the burned amount of all BM.
The right side is the amount to burn to reach the max allowed receiver share based the boosted max burn target.
Increase ISSUANCE_BOOST_FACTOR from 3 to 4.
Add help overlay to burn target table header.
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-14 20:34:42 -05:00
HenrikJannsen
f799e115b0
Remove try catch. Will be handled in Future fault handler
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-14 18:52:08 -05:00
HenrikJannsen
2535f01eb1
Add check for price==0
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-14 18:50:41 -05:00
Christoph Atteneder
51c7e40be9
Merge pull request #6456 from HenrikJannsen/remvoe_connection_keep_alive_header_as_its_restricted_in_java
...
Remove connection:keep-alive header
2022-12-14 10:20:36 +01:00
Christoph Atteneder
5dea677644
Merge pull request #6459 from HenrikJannsen/handle_exception_at_send
...
Handle exception at send
2022-12-14 10:20:07 +01:00
Christoph Atteneder
6fa2ffb3c7
Merge pull request #6460 from HenrikJannsen/remove_unneeded_gradle_tasks
...
Deactivate shadowDistTar and shadowDistZip tasks
2022-12-14 10:18:34 +01:00
Christoph Atteneder
71d6e126dd
Merge pull request #6423 from HenrikJannsen/add-burningman-accounting
...
Add burningman accounting
2022-12-14 10:17:38 +01:00
HenrikJannsen
fb1e731d47
Deactivate shadowDistTar and shadowDistZip tasks
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-13 20:41:02 -05:00
HenrikJannsen
776714fbd4
Remove setting of RejectedExecutionHandler
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-13 20:36:36 -05:00
HenrikJannsen
8c65da9c85
Add thread index format
...
Add name param to newCachedThreadPool
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-13 20:35:49 -05:00
HenrikJannsen
fc2f9241b8
Apply codacy complaint
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-13 20:30:41 -05:00
HenrikJannsen
ebb6652cef
Remove restartTor method as restart is not supported anymore.
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-13 18:15:23 -05:00
HenrikJannsen
c000d38a09
Remove unnecessary thread and try/catch.
...
Wrap nodeAddressProperty.set into UserThread.execute as it is a javafx api. We call startServer also in that execute scope to maintain order of calls.
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-13 18:11:49 -05:00
HenrikJannsen
04a1dee9e9
Cleanup
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-13 18:07:01 -05:00
HenrikJannsen
6d2bd9f8d4
Use 3 distinct executors for send message, create connection and server.
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-13 18:03:29 -05:00
HenrikJannsen
c4dfc2f9ac
Add ExecutorService to TorNetworkNode instead of using pool from base class.
...
Remove torStartupFuture as it was not needed.
Make executorService private and add shutdownNow call.
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-13 17:57:19 -05:00
HenrikJannsen
0e34932ec8
Remove createExecutorService method and create executor in constructor instead.
...
Make executorService protected final
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-13 17:53:03 -05:00
HenrikJannsen
553dd84f28
Cleanups
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-13 17:49:51 -05:00
HenrikJannsen
43233db70c
Throw RuntimeException at sendMessage.
...
Make sendMessage package scope to not be used from client code.
Remove stacktrace print.
The caller in NetworkNode would report a onSuccess in the future callback because we do not escalate the exception but only handle it inside handleException.
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-13 17:47:04 -05:00
HenrikJannsen
f90c4b8f6b
Use cachedThreadPool which uses SynchronousQueue instead of ArrayBlockingQueue.
...
When ArrayBlockingQueue is used (as in case of using Utilities.getListeningExecutorService) the maxPoolSize
has no effect. The pool creates never more threads than the core pool size.
Thus we have been limited to 15 threads for message sending and connection creation.
This was likely a reason why seed nodes are not accepting new connections if the pool is exhausted.
Slow message send can block a thread for 1-3 minutes.
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-13 17:33:31 -05:00
HenrikJannsen
071a352443
Remove rejectedExecutionHandler at newCachedThreadPool.
...
It is more convenient to handle the RejectedExecutionException in the calling code to get more context for error logging.
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-13 17:33:31 -05:00
HenrikJannsen
84584d38ac
The connection:keep-alive header is restricted in java and would require a jvm option to allow it.
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-13 17:33:30 -05:00
HenrikJannsen
0dc8d0b2bd
Add maxConnection parameter to be used for setting the core pool size of the executor in NetworkNode.
...
We use double the maxConnection size for the core size and 4x for the max pool size.
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-13 16:35:16 -05:00
HenrikJannsen
d4b6965348
Use networkNode.sendMessage instead of connection.sendMessage as the call on connection is blocking.
...
This was likely a major bug for seed nodes that at sending hash responses the main thread got blocked.
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-13 16:25:39 -05:00
HenrikJannsen
1f40169722
The connection:keep-alive header is restricted in java and would require a jvm option to allow it.
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-12 20:23:32 -05:00
Christoph Atteneder
ac575cef5e
Merge pull request #6454 from HenrikJannsen/apply_code_review_suggestions_to_seednode_changes
...
Apply code review suggestions to seednode changes
2022-12-12 11:26:14 +01:00
HenrikJannsen
f28e3960da
Rename *ValueItem to *ValueReportingItem
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-11 17:26:50 -05:00
HenrikJannsen
3ae52dbb52
Add proto to seed node
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-11 17:26:08 -05:00
HenrikJannsen
53c031dfaf
Refactor: Move SeedNodeReportingService to reporting package
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-11 17:10:33 -05:00
HenrikJannsen
1b10cc22db
Refactor: Move monitor package from core to seedNode and rename to reporting
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-11 17:10:02 -05:00
HenrikJannsen
1e32d86b23
Only log errors if shutdown is not in progress.
...
I want to avoid to risk changes with not calling error handlers/listeners in those cases
as not 100% sure if that could have unintended effects.
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-11 17:08:40 -05:00
HenrikJannsen
6addd27a33
Add params to newCachedThreadPool method.
...
Use executor at httpClient builder.
Use httpClient.sendAsync.
Add keep-alive header.
Add RejectedExecutionHandler.
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-11 17:06:01 -05:00
HenrikJannsen
21c6c52ec8
Make fields final.
...
Remove setter of key.
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-11 17:02:30 -05:00
Alejandro García
4f34be0a33
Merge pull request #6452 from ripcurlx/update-app-signatures
...
Update app signatures for v1.9.7
2022-12-11 18:36:00 +02:00
Alejandro García
77afb2d62c
Merge pull request #6450 from jmacxx/dispute_min_payout
...
Change minimum payout at mediation from 2.5% to 5% of trade amount.
2022-12-11 18:26:56 +02:00
HenrikJannsen
e57af6e8e8
Update mediation popup text
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-11 11:15:19 -05:00
HenrikJannsen
b7d5af18b0
Add MAX_BURN_TARGET_LOWER_FLOOR to avoid cases where small burn amounts lead to deadlock situations.
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-11 11:15:19 -05:00
HenrikJannsen
46b2cf914b
Remove DevEnv.isDevTesting
...
Add check for number of confirmations in devMode to show support button after 5 blocks
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-11 11:15:19 -05:00
HenrikJannsen
e3a0ae9425
Use constants for opReturn data. Rename hash to opReturnData.
...
Update UI.
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-11 11:15:18 -05:00
HenrikJannsen
c8a9b9a7cc
Improve TAC text
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-11 11:15:18 -05:00
HenrikJannsen
65eebefb69
Make copy icon in popups smaller
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-11 11:15:18 -05:00
HenrikJannsen
891685f3ec
Update TAC text and layout
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-11 11:15:18 -05:00
HenrikJannsen
1bb4b55220
Add BurningManAccountingStore resource file.
...
Use resourceDataStoreService and extend StoreService
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-11 11:15:18 -05:00
HenrikJannsen
a03b0eadfc
Make codacy happy
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-11 11:15:18 -05:00
HenrikJannsen
446762f02c
Add BM account UI
2022-12-11 11:15:17 -05:00
HenrikJannsen
a9bf52d26c
Add BurningMan accounting domain
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-11 11:15:17 -05:00