Commit Graph

12496 Commits

Author SHA1 Message Date
chimp1984
076af0a3e1
Do not log full tiler object in case of an invalid Filter
Instead log signerPubKeyAsHex and creation date. We have currently the old filter still around (intended) so we get that log called and it would confuse ppl reading the log without knowing more about the context.
2020-10-07 09:42:01 -05:00
sqrrm
723a1f5cf9
Merge pull request #4592 from chimp1984/improve-bisq-setup
Improve bisq setup
2020-10-07 14:08:10 +02:00
Christoph Atteneder
7d14ff37d8
Merge pull request #4595 from ghubstan/remove-duplicated-supporttype-enum
Remove redundant DisputeAgentType enum
2020-10-07 09:37:15 +02:00
Christoph Atteneder
66f6e49f83
Merge pull request #4596 from ghubstan/refactor-placeoffer-tx-handling
Simplify GrpcOffersService#createOffer (refactor)
2020-10-07 09:30:40 +02:00
Christoph Atteneder
d88583307f
Merge pull request #4602 from chimp1984/re-activate-confirm-buttons-again
Re activate confirm buttons again
2020-10-07 09:22:51 +02:00
chimp1984
7ecae0e5be
Set amounts before setting state, as the state triggers the check where the amount is needed 2020-10-06 11:30:44 -05:00
chimp1984
2d99ae7d09
Remove isDisputed checks 2020-10-06 11:04:20 -05:00
chimp1984
b4bd1df27f
Refactor: Move method 2020-10-06 10:45:19 -05:00
chimp1984
4a0fe3e62e
Move checks to enable confirm to Trade
Use it in view to disable button
2020-10-06 10:40:39 -05:00
chimp1984
f0606f9266
Refactor: Remove commented out code and comments 2020-10-06 10:26:11 -05:00
chimp1984
0e89c27021
Add mediationResultAppliedPenaltyToSeller method to Trade
Add util methods to DisputeState
Impl. paymentReceivedEnabled method for SellerProtocol
Impl. paymentStartedEnabled method for BuyerProtocol
Remove notDisputed method as not used anymore

Add final keywords
2020-10-06 10:22:22 -05:00
ghubstan
5f9b1e6e1a
Format exception message 2020-10-06 11:30:17 -03:00
ghubstan
30e6dae90b
Change return type to void
The prior Offer return type is redundant and confusing given the
new offer is passed up via the Consumer<Offer> resultHandler.
2020-10-06 11:19:08 -03:00
Christoph Atteneder
454b3a97d5
Merge pull request #4587 from wiz/update-tac-for-price-indices
Update text/URL in Terms and Conditions window for Bisq Price Indices
2020-10-06 10:10:21 +02:00
Christoph Atteneder
049b6209b7
Merge pull request #4594 from ghubstan/refactor-api-price-service
Tidy up CorePriceService (refactor)
2020-10-06 10:04:00 +02:00
Christoph Atteneder
be0946609e
Merge pull request #4597 from wiz/revert-mempool-back-to-medium-prio
Reduce mempool fee estimation back to "medium" priority
2020-10-06 09:56:03 +02:00
Christoph Atteneder
36bc15df2e
Merge pull request #4600 from chimp1984/avoid-illegal-reflective-access-operation-warning
Setting jvm option  `-Djdk.module.illegalAccess=deny`
2020-10-06 09:50:53 +02:00
chimp1984
be204c457d
Setting jvm option -Djdk.module.illegalAccess=deny avoids the warning logs at startup
Not sure how to add it to gradle so its set at normal compilation as well...

User get confused by the warning as it sounds somehow alerting.

`WARNING: An illegal reflective access operation has occurred
 WARNING: Illegal reflective access by com.google.inject.internal.cglib.core.$ReflectUtils$1 (file:/Users/dev/.gradle/caches/modules-2/files-2.1/com.google.inject/guice/4.2.2/6dacbe18e5eaa7f6c9c36db33b42e7985e94ce77/guice-4.2.2.jar) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain)
 WARNING: Please consider reporting this to the maintainers of com.google.inject.internal.cglib.core.$ReflectUtils$1
 WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
 WARNING: All illegal access operations will be denied in a future release`
2020-10-06 00:19:50 -05:00
ghubstan
3f3f4f06f5
Use consumer::accept instead of a countdown latch
This is more readable and stylistically consistent.
2020-10-05 14:32:05 -03:00
ghubstan
2d34730bd8
Fix method name 2020-10-05 13:51:48 -03:00
wiz
894cdf3536
Reduce mempool fee estimation back to "medium" priority
Now that we've recently optimized the "medium" fee estimation algorithm
in mempool/mempool@15bb5a96, we can move Bisq back to "medium", since
always using "high" will be a bit wasteful on the weekends when the
mempool is empty.
2020-10-06 01:30:34 +09:00
ghubstan
dd67acc153
Simplify GrpcOffersService#createOffer (refactor)
Push the placeOffer call down into CoreOffersService#createOffer,
and use a countdown latch to wait for async placeOffer to
complete.
2020-10-05 12:23:54 -03:00
chimp1984
474c4138d2
Refactor: rearrange methods 2020-10-04 17:24:03 -05:00
chimp1984
52f5f2f064
Extract domain initialisation to domainInitialisation class 2020-10-04 17:24:03 -05:00
chimp1984
d6c3ccd605
Add AppStartupState and DomainInitialisation.accountAgeWitnessService
See comments to classes for reasoning.
2020-10-04 17:24:03 -05:00
sqrrm
fd65bcc4ec
Merge pull request #4589 from chimp1984/persistence-redesign
Persistence redesign
2020-10-04 23:29:14 +02:00
chimp1984
e179ee4e32
Use Collection for constructor which is called from the fromProto methods.
We do not set the collection as list but we fill the list created via the createList method.
2020-10-04 16:13:45 -05:00
chimp1984
c797317c0d
Fix typo 2020-10-04 16:05:43 -05:00
chimp1984
d18b243322
Do not use persistNow for snapshots but requestPersistence
This avoids frequent write at dao sync and better performance.
2020-10-04 13:34:28 -05:00
chimp1984
f9f33aa16d
Add PersistableListAsObservable
Remove ObservableList methods from PersistableList
Let DisputeList and TradableList extend PersistableListAsObservable
Fix param names
2020-10-04 13:18:25 -05:00
chimp1984
f7c2464fbc
Fix typo 2020-10-04 13:16:49 -05:00
chimp1984
0cc0cfc9a5
Use runAfter instead of runPeriodically 2020-10-04 12:54:27 -05:00
chimp1984
3b31dc9ff3
Fix typo 2020-10-04 12:53:20 -05:00
chimp1984
a612405d9d
Update common/src/main/java/bisq/common/persistence/PersistenceManager.java
Co-authored-by: sqrrm <sqrrm@users.noreply.github.com>
2020-10-04 12:49:02 -05:00
ghubstan
9942529448
Remove redundant DisputeAgentType enum
Use existing SupportType enum instead, and map the valid api
'registerdisputeagent' method's dispute-agent-type parameter
names to SupportType.
2020-10-03 15:42:27 -03:00
ghubstan
0cc998c4e2
Tidy up CorePriceService
Remove unnecessary String.format call and do a null check.
2020-10-03 14:48:49 -03:00
chimp1984
6693a03f96
Fix test class 2020-10-03 12:48:23 -05:00
chimp1984
c9cd58a378
Fix rename mistakes 2020-10-03 12:48:23 -05:00
chimp1984
e9db7c6808
Rename Priority to Source. This should make it more clear what is the intention of the usage.
Rename:
LOW to NETWORK
MID to PRIVATE_LOW_PRIO
HIGH to PRIVATE

Change delay of MID/PRIVATE_LOW_PRIO from 30 min to 2 hours (we had different datastores before using it, now its only real low prio stores)

Add comment to each enum
2020-10-03 12:48:23 -05:00
chimp1984
137b5e81d1
Enforce that clients set the priority. Remove the initialize methods which did not have priority as a param.
Make initializePersistenceManager in StorageService abstract to enforce in concrete class to define priority.

Change priorities for future renaming to a different meaning. instead of priority we want to describe the category: private data, public data,.... will come in next commit
2020-10-03 12:48:22 -05:00
chimp1984
18f64d53ca
Persist all Priority.HIGH stores at shutdown to be more safe that we did not miss any state update.
Priority.HIGH stores are all those which contain private data. Others can be rebuilt from network data or are not critical like navigationPath.
2020-10-03 12:48:22 -05:00
chimp1984
10e9b054a0
Rename writeCompleted to onWriteCompleted
Add comment
Use decrementAndGet instead of getAndDecrement

Tested cases when there is an exception at write to disk, but as we call the result handler in the finally clause we get always called onWriteCompleted, so it cannot happen that we get stuck.
2020-10-03 12:48:22 -05:00
chimp1984
232fa8ddee
Execute result handler on userThread 2020-10-03 12:48:22 -05:00
chimp1984
b712445e34
Remove duplicate startApplication call. Remove checkCryptoSetup call and fields used only for that. 2020-10-03 12:48:22 -05:00
chimp1984
32238f2050
Rename getClosedTradables and getFailedTrades to getObservableList 2020-10-03 12:48:22 -05:00
chimp1984
c789650d0b
Move methods to base class 2020-10-03 12:48:22 -05:00
chimp1984
e88a810dd0
Revert exit code to 1 as it was before. Not sure if there have been some scripts for seeds which expect an error code at shutdown for auto restart. I remotely remember there have been something... 2020-10-03 12:48:22 -05:00
chimp1984
e242c54dab
Refactor: Rename getTradesAsObservableList to getObservableList 2020-10-03 12:48:22 -05:00
chimp1984
5f47ed20d8
Use decrementAndGet instead of getAndDecrement 2020-10-03 12:48:21 -05:00
chimp1984
ccfda5b043
Cleanups, add generics, add final, remove unused code/comments/todos, 2020-10-03 12:48:21 -05:00