mirrors/bisq
1
0
Fork 0
mirror of https://github.com/bisq-network/bisq.git synced 2024-11-19 09:52:23 +01:00
Code Issues Packages Projects Releases Wiki Activity
17,375 Commits 4 Branches 148 Tags 4.3 GiB
02107ad9f0
Commit Graph

7056 Commits

Author SHA1 Message Date
Christoph Atteneder
afba2f22b9
Update bitcoinj checkpoints for v1.9.7 2022-12-14 11:12:49 +01:00
Christoph Atteneder
72dea08473
Update translations for v1.9.7 2022-12-14 10:39:28 +01:00
Christoph Atteneder
5dea677644
Merge pull request #6459 from HenrikJannsen/handle_exception_at_send 
Handle exception at send
 2022-12-14 10:20:07 +01:00
Christoph Atteneder
71d6e126dd
Merge pull request #6423 from HenrikJannsen/add-burningman-accounting 
Add burningman accounting
 2022-12-14 10:17:38 +01:00
HenrikJannsen
8c65da9c85
Add thread index format 
Add name param to newCachedThreadPool

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-13 20:35:49 -05:00
HenrikJannsen
d4b6965348
Use networkNode.sendMessage instead of connection.sendMessage as the call on connection is blocking. 
This was likely a major bug for seed nodes that at sending hash responses the main thread got blocked.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-13 16:25:39 -05:00
HenrikJannsen
1b10cc22db
Refactor: Move monitor package from core to seedNode and rename to reporting 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 17:10:02 -05:00
HenrikJannsen
21c6c52ec8
Make fields final. 
Remove setter of key.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 17:02:30 -05:00
Alejandro García
4f34be0a33
Merge pull request #6452 from ripcurlx/update-app-signatures 
Update app signatures for v1.9.7
 2022-12-11 18:36:00 +02:00
Alejandro García
77afb2d62c
Merge pull request #6450 from jmacxx/dispute_min_payout 
Change minimum payout at mediation from 2.5% to 5% of trade amount.
 2022-12-11 18:26:56 +02:00
HenrikJannsen
e57af6e8e8
Update mediation popup text 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:19 -05:00
HenrikJannsen
b7d5af18b0
Add MAX_BURN_TARGET_LOWER_FLOOR to avoid cases where small burn amounts lead to deadlock situations. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:19 -05:00
HenrikJannsen
46b2cf914b
Remove DevEnv.isDevTesting 
Add check for number of confirmations in devMode to show support button after 5 blocks

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:19 -05:00
HenrikJannsen
e3a0ae9425
Use constants for opReturn data. Rename hash to opReturnData. 
Update UI.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:18 -05:00
HenrikJannsen
1bb4b55220
Add BurningManAccountingStore resource file. 
Use resourceDataStoreService and extend StoreService

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:18 -05:00
HenrikJannsen
446762f02c
Add BM account UI 2022-12-11 11:15:17 -05:00
HenrikJannsen
a9bf52d26c
Add BurningMan accounting domain 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:17 -05:00
HenrikJannsen
22c43769bd
Add BurningManAccountingService to CorePersistedDataHost 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:17 -05:00
HenrikJannsen
90550dee3f
Add messages and domain data for accounting domain 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:17 -05:00
HenrikJannsen
d4a0032965
Add new fields and methods 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:17 -05:00
HenrikJannsen
f9db6e0d5c
Add support for multiple clients adding a block handler. 
Add requestRawDtoBlock method.
Rename to make different block types more clear.
Change visibility
 2022-12-11 11:15:17 -05:00
HenrikJannsen
a551a41e5a
Add support for multiple clients calling the setup method. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:17 -05:00
HenrikJannsen
e2f7c4e103
Make AveragePriceUtil.getAveragePriceTuple mor flexible 
Add filter for before date

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:16 -05:00
HenrikJannsen
bc9ccfd0e9
Add String formatCoin(long value) API to CoinFormatter 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:16 -05:00
HenrikJannsen
2615309931
Add Config options 2022-12-11 11:15:16 -05:00
HenrikJannsen
adb02428ee
Remove unused var 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:16 -05:00
HenrikJannsen
d12c8b5fc4
Remove TODO, rename method 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:16 -05:00
HenrikJannsen
97ba1560be
Improve receiver distribution to avoid that legacy BM gets outputs if some outputs fall below the min. amount limit. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:16 -05:00
HenrikJannsen
fa4c952409
Apply code review feedback 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:15 -05:00
HenrikJannsen
eeaafc1e04
Use HashSet instead Lists. 
Remove sorting as not needed.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:15 -05:00
HenrikJannsen
7cbc5d6263
Increase ISSUANCE_BOOST_FACTOR to 3 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:15 -05:00
HenrikJannsen
4ce6ce745a
Add check for isActivated and if not return LEGACY_BURNING_MAN_BTC_FEES_ADDRESS 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:15 -05:00
HenrikJannsen
4e08bcd53d
Split up legacy BM into DPT and BTC fee BM 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:15 -05:00
HenrikJannsen
d30ec07d94
Cleanup/add comments 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:15 -05:00
HenrikJannsen
8ab2582db6
Use check for isRegtest instead of test for isDevTesting to set dev parameters 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:15 -05:00
HenrikJannsen
0e79582819
Refactoring: Move isActivated method to BurningManService 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:14 -05:00
HenrikJannsen
dff6d48333
Refactoring: Move BM model classes into model package. Adjust visibility. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:14 -05:00
HenrikJannsen
c1dc317783
Remove unused methods 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:14 -05:00
HenrikJannsen
d31493b1e9
Use TradeWalletService.MIN_DELAYED_PAYOUT_TX_FEE as min value for miner fee in DelayedPayoutTxReceiverService.getSpendableAmount 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:14 -05:00
HenrikJannsen
d4646cc19f
Add LegacyBurningMan to UI 
It is not included in BurningManCandidate candidate map as that would complicate things.
We only want to show it in the UI for informational purposes.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:14 -05:00
HenrikJannsen
883b0542a1
Fix getSnapshotHeight method 
For chainHeights < genesisHeight+3*grid we ended up with future chainHeights

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:14 -05:00
HenrikJannsen
2b4b6fe715
Add logs for delayedPayoutTx receiver data 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:13 -05:00
HenrikJannsen
b7a5b569ca
Add legacy burningman to btc fee distribution in case we do not reach 100% from capped burn shares. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:13 -05:00
HenrikJannsen
c1b8871fda
Fix burn target calculations 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:13 -05:00
HenrikJannsen
3a7af07e86
Improve burn target calculation and display 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:13 -05:00
HenrikJannsen
c747a486a7
Fix duration calculations 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:13 -05:00
HenrikJannsen
3213c5e770
Avoid negative cycle index 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:13 -05:00
HenrikJannsen
683bc409c7
Use cycles for periods instead of blocks in months/years. 
A cycle is the fundamental unit in the DAO, months/years have no relevance, so using
cycles as base helps avoids some potential weird behaviour with data getting updated at cycle events.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:13 -05:00
HenrikJannsen
2799ccabad
Add util class for cycle related methods with caching 
Add getCycleAtIndex convenience method to DaoStateService

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:12 -05:00
HenrikJannsen
516004dfaf
Change ISSUANCE_BOOST_FACTOR to 3 
Use lower dev test value for BURN_TARGET_BOOST_AMOUNT

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:12 -05:00
HenrikJannsen
1e8ec6f206
Add details if donationAddressOfDelayedPayoutTx check fails 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:12 -05:00
HenrikJannsen
625939b0f9
Bugfix: set burningManSelectionHeight and tradeTxFee at dispute clone 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:12 -05:00
HenrikJannsen
a6a018883d
Add isDevTesting method for adjusting behaviour for dev testing purposes 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:12 -05:00
HenrikJannsen
4e25d2f253
Add isDevMode check to set dev params 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:12 -05:00
HenrikJannsen
402c4075d0
Add option to add opReturn data at BSQ wallet send screen for non-BSQ balance. 
This can be used for providing proof of ownership of a genesis output when attaching a custom BM receiver address.
See: https://github.com/bisq-network/proposals/issues/390#issuecomment-1306075295

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:11 -05:00
HenrikJannsen
78d3fd8d44
Fix wrong initial value. 
For myGenesisOutputNames we check for null not Optional.empty as empty is a valid case and we do not
want to wrap the optional field into another Optional.
Also myCompensationRequestNames is using a null check and gets reset to null instead of an
empty set as the empty set is a valid case as well.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:11 -05:00
HenrikJannsen
88cf28c526
Add applyBlock method and call at constructor (some classes get not initiated at app startup but created by UI activity). 
Remove accumulatedDecayedBurnAmount at getAllowedBurnAmount. Was incorrect.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:11 -05:00
HenrikJannsen
fb51861c4b
Use months and not cycles for burn target and average. 
Add checks for chainHeight to make code more generic (in the current usage its always last block anyway)

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:11 -05:00
HenrikJannsen
befe166bc7
Refactor out fields from BurningManCandidate which are not affecting data for delayed payout tx receivers. 
This allows to split off the burn target related code to separate classes.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:11 -05:00
HenrikJannsen
52d48eb90a
Rename getDelayedPayoutTxReceivers to getReceivers 
Cleanup

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:10 -05:00
HenrikJannsen
f0faa44804
Remove Current from method names 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:10 -05:00
HenrikJannsen
7724b5b3ea
Rename getBtcFeeReceiverAddress to getAddress 
Cleanup

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:10 -05:00
HenrikJannsen
92b38ed20f
Move BurningManUtil.getLegacyBurningManAddress to BurningManService. 
Remove BurningManUtil

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:10 -05:00
HenrikJannsen
508081ad16
Rearrange methods 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:10 -05:00
HenrikJannsen
ec25722d08
Split up calculateShare into 4 distinct methods 
Reduce visibility to package scope

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:10 -05:00
HenrikJannsen
3fda949526
Add sorting for output index needed for genesis tx outputs. 
Use static factory methods for the 2 diff. use cases of CompensationModel.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:10 -05:00
HenrikJannsen
22f7b089f4
Remove reference to delayedPayoutTxReceiverService and btcFeeReceiverService inside BurningManService. 
Use DelayedPayoutTxReceiverService and BtcFeeReceiverService in client code instead of BurningManService.
Make BurningManService package private.
 2022-12-11 11:15:09 -05:00
HenrikJannsen
40a03ebdc5
Move getAverageDistributionPerCycle to BurningManService and use from BurningManInfoService. 
Remove reference to BurningManInfoService inside BurningManService.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:09 -05:00
HenrikJannsen
559ba6e9b9
Refactor BurningManService 
Split up into 4 service classes
- BurningManService: Common stuff
- BurningManInfoService: For displaying BurningMan data
- BtcFeeReceiverService: For getting btcFeeReceivers
- DelayedPayoutTxReceiverService: For getting delayedPayoutTxReceivers. This is the critical part where we need to have a deterministic data and which could break trade consensus.

WIP refactoring. More to come...

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:09 -05:00
HenrikJannsen
19067acbcd
Cleanup 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:09 -05:00
HenrikJannsen
7407ab87f9
Subtract accumulatedDecayedBurnAmount from allowedBurnAmount 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:09 -05:00
HenrikJannsen
58cabfaaf6
Add expectedRevenue to BurningManCandidate. 
Add getAverageDistributionPerCycle method to BurningManService.
Show receiver address when BM is selected.
Refactor code, cleanups, UI improvements.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:09 -05:00
HenrikJannsen
731363d128
Sort getBtcFeeReceiverAddress by amount and address. 
Increase minOutputAmount to 1000 sat.
Cleanups

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:08 -05:00
HenrikJannsen
02a163f2f1
Fix handling of null entries in getBtcFeeReceiverAddress method 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:08 -05:00
HenrikJannsen
e16a9b00b1
Add verifyDelayedPayoutTxReceivers method in RefundManager. 
Add burningManSelectionHeight and tradeTxFee in Dispute.
Call validateDonationAddressMatchesAnyPastParamValues and validateDonationAddress
only if legacy BM was used.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:08 -05:00
HenrikJannsen
060b9c476e
Validate delayedPayoutTx outputs size and amount only if BurningManService.isActivated is false. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:08 -05:00
HenrikJannsen
7b280c4a99
Use Burningmen receivers for delayed payout tx. 
Add verification by re-creating receivers and check txId of both DPTs.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:08 -05:00
HenrikJannsen
eee0b691d0
Remove FeeReceiverSelector and test as not used anymore 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:08 -05:00
HenrikJannsen
e2ce053a01
Add burningManSelectionHeight fields to OfferAvailabilityRequest, InputsForDepositTxRequest and ProcessModel. 
Use BurningManService.getBtcFeeReceiverAddress at createFeeTx tasks.
Verify takers burningManSelectionHeight if BurningManService.isActivated at MakerProcessesInputsForDepositTxRequest and OpenOfferManager.
Stores burningManSelectionHeight in ProcessModel.
Add BurningManService fields to OfferAvailabilityModel, PlaceOfferModel, OpenOfferManager and Provider

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:07 -05:00
HenrikJannsen
39a49adb92
Add Burningman UI 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:07 -05:00
HenrikJannsen
739ff8e447
Add BurningMan domain 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:07 -05:00
HenrikJannsen
ea5662f84d
Add new methods to DaoStateService and DaoFacade. 
Will be used later by BurningMan domain.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:07 -05:00
HenrikJannsen
5c7a3308a7
Add burningManReceiverAddress as extraMap entry to CompensationProposal. 
We cannot add a new field as that would break DAO consensus.

Add optional text field for burningManReceiverAddress to CompensationProposal UI.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:07 -05:00
HenrikJannsen
09a1af8f2c
Add allowEmpty flag to InputValidator and BtcAddressValidator 
We will use that for the optional address field in compensation requests and interpret empty input as Optional.empty.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-11 11:15:06 -05:00
Alejandro García
6c7764fc33
Merge pull request #6451 from HenrikJannsen/avoid_sending_repeated_block_related_report_data 
Avoid sending repeated block related report data
 2022-12-11 17:38:00 +02:00
Stephan Oeste
9e50066567
Remove KanoczTomas Bitcoin node, because it is permanet offline. 2022-12-11 15:28:32 +01:00
HenrikJannsen
491c6a0861
Add onDaoStateBlockCreated method 
Use onDaoStateBlockCreated instead of onDaoStateHashesChanged to avoid multiple calls when we receive hashes from other nodes.
Add daoStateMonitoringService listener after blockchain parsing is completed

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-10 19:19:29 -05:00
jmacxx
e2a23ee196
Change minimum payout at mediation from 2.5% to 5% of trade amount. 
Implements bisq-network/proposals#397
 2022-12-10 10:37:52 -06:00
Alejandro García
2d607cd092
Merge pull request #6433 from jmacxx/user_trade_limits 
User defined trade limit, Part II.
 2022-12-09 19:46:34 +02:00
HenrikJannsen
f98cd04fd8
Use LongValueItem instead of IntegerValueItem 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-09 08:54:28 -05:00
jmacxx
6f8bb00704
Apply code review suggestions. 2022-12-08 08:16:11 -06:00
HenrikJannsen
f4775f89b0
Add SeedNodeReportingService 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-07 13:23:28 -05:00
HenrikJannsen
3a4ed1fc01
Add seedNodeReportingServerUrl option 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-07 11:51:49 -05:00
HenrikJannsen
2c84f07ada
Add value objects and protobuf definitions 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-07 11:51:08 -05:00
HenrikJannsen
3caf2c2b64
Change visibility (will be used from monitor project). 
Remove log, change log level.
Add getters

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-07 11:50:24 -05:00
HenrikJannsen
a925017e4b
Rename readCommitHash to findCommitHash, make it static and return optional. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-12-07 11:03:08 -05:00
jmacxx
09a7a09ec3
Fix FileTransferSession tests. 2022-12-06 20:33:48 -06:00
jmacxx
bddbe6b7ae
Feature to zip logfiles to home directory. 2022-12-05 09:14:12 -06:00
Christoph Atteneder
5dc006ec9b
Merge pull request #6435 from jmacxx/add_shutdown_guard 
Prompt to confirm before shutting down.
 2022-12-05 10:45:02 +01:00
jmacxx
75f224c67c
Check filterWarningHandler is set before use. 2022-12-04 21:10:06 -06:00
jmacxx
0e3314ce14
Prompt to confirm before shutting down. Has dont show again option. 2022-12-02 15:35:27 -06:00
Christoph Atteneder
4069e60f8c
Update app signatures 2022-12-01 12:21:46 +01:00
Christoph Atteneder
16166c42a7
Merge pull request #6429 from HenrikJannsen/handle-rpc-errors-gracefully 
Handle HttpExceptions at block handler
 2022-12-01 09:50:54 +01:00
jmacxx
7ec86c3dc3
User defined trade limit. 
Some commits were missed from the first implementation in #6431.
The user limit is applied to offer entry via AccountAgeWitnessService.
Offers are filtered according to limits in OfferFilterService.
If limit changed, the cache in OfferFilterServices must be cleared.
 2022-11-29 22:41:34 -06:00
jmacxx
1df3046371
Validate BSQ fee payment using DAO tx info. 
Previously the BSQ fee payment was determined by parsing a raw tx
without relying on the DAO.  Unfortunately this turned out to be
problematic, so with this change the BSQ fee paid is obtained from
the DAO tx, as originally preferred by chimp1984.

Unconfirmed transactions will not be able to have their BSQ fees
checked so early requests for validation will skip the fee check.
This is not a problem since maker fee validation is done by the
taker and in the majority of cases will be already confirmed; taker
fee validation is done after the first confirm at trade step 2.
 2022-11-29 18:16:21 -06:00
jmacxx
c796531658
Increase trading limits as an opt-in setting (GH proposal 398) 
More restrictive limits will still apply based on payment method.

It is intended to avoid that a new users who do not fully understand
the process of a Bisq trade to cause an arbitration case with high
amounts and therefore higher risks and costs for the DAO.
 2022-11-29 09:32:38 -06:00
Alejandro García
8d2f0a5d12
Merge pull request #6383 from Android-X13/option_for_qr_codes 
Include option for non-URI addresses in QR codes
 2022-11-29 14:42:05 +02:00
Alejandro García
e054083c1f
Merge pull request #6376 from jmacxx/fix_issue_6367 
Fix loss of mailbox messages during SPV resync
 2022-11-29 14:41:27 +02:00
HenrikJannsen
0b07c104a7
Use recovery for all RPC HttpExceptions exceptions in generic error handler. 
It seems that a reorgs or if a new block arrives quickly after another, that bitcoind is not ready
for a request and throws an RPC error, also the blockhandler throws that if the new block came too fast.
We try to request again with increasing delays up to 1 min. If after 10 attempts its still failing we
do a reorg and start parting again.
 2022-11-27 17:42:53 -05:00
HenrikJannsen
a0900a0f1b
Handle HttpExceptions at block handler 2022-11-27 17:41:21 -05:00
sqrrm
b10881ff7f
Merge pull request #6418 from HenrikJannsen/improve-dao-node-domain 
Improve dao node domain
 2022-11-26 16:19:52 +01:00
jmacxx
8a94642e1a
Do not erase mailbox messages during SPV resync. 2022-11-25 21:13:09 -06:00
Alejandro García
92e4c62287
Merge pull request #6422 from jmacxx/fix_trade_timer_issue 
Fix:  incorrect wallet tx handling
 2022-11-26 03:02:05 +02:00
Alejandro García
80a927afb9
Merge pull request #6404 from HenrikJannsen/improve-dispute-validation 
Improve dispute validation
 2022-11-25 17:37:44 +02:00
Alejandro García
a6293a64cb
Merge pull request #6396 from jmacxx/show_commit_hash 
Store the build's commit hash in Jarfile manifest
 2022-11-25 17:36:34 +02:00
Android-X13
d77b76034d
Include option for non-URI addresses in QR codes 2022-11-22 23:11:45 +02:00
jmacxx
24ae5f6220
Make sure the actual wallet transaction is returned. 
There was an issue with the transaction having a non-initialized
updateTime and/or blockTime because the wallet transaction was
not returned.
 2022-11-21 09:39:21 -06:00
HenrikJannsen
671ab1f373
Cleanup 
Improve toString methods

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-17 19:55:04 -05:00
HenrikJannsen
0f14ea29c9
Improve handling of case when Bitcoin Core sync is not completed. 
We repeat with a quadratically increasing delay 5 times, then we give up.
In the previous code we repeated forever which could be risky in case that
code branch is called unexpectedly.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-17 19:51:15 -05:00
HenrikJannsen
811ae52f27
Fix bug with using getPreviousBlockHash instead of getHash 
It had no consequences as it was only used for info logging

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-17 19:46:38 -05:00
HenrikJannsen
1e72e265f7
Cleanup comments 
Improve toString methods
Rename var for more clear meaning

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-17 19:44:58 -05:00
HenrikJannsen
de654c15b3
Improve handling of ConnectionState.expectedInitialDataResponses 
Rename to expectedInitialDataResponses as we compare with numInitialDataResponses.
Add comment to make it more clear how its used.
Let the LiteNode increment only if getBlocks get called (e.g. blocks are missing).

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-17 19:41:32 -05:00
Bisq GitHub Admin
60522218a7
Merge pull request #6412 from bisq-network/release/v1.9.6 
Merge release branch
 2022-11-15 21:03:40 +01:00
sqrrm
3dd9b0e575
Merge pull request #6403 from HenrikJannsen/disable-deactivation-of-dao 
Require the DAO is enabled for traders
 2022-11-04 11:44:26 +01:00
HenrikJannsen
81be778df3
Remove deposit tx output size check. 
It is allowed that there are change outputs, for instance if taker
does not take full trade amount, there is a change output for maker.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-03 14:14:32 -05:00
HenrikJannsen
e653262751
Fix param in test 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-03 12:26:59 -05:00
HenrikJannsen
cba35b6342
Remove deposit tx output size check. 
It is allowed that there are change outputs, for instance if taker
does not take full trade amount, there is a change output for maker.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-03 12:21:47 -05:00
HenrikJannsen
8d8cdc14b4
Cleanup 2022-11-03 12:12:02 -05:00
HenrikJannsen
b5df4afd40
Remove DevEnv.isDaoActivated method as not used anymore 
Remove daoActivatedToggleButton from PreferencesView and NewsView

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-03 11:16:10 -05:00
HenrikJannsen
e8a9132d30
Remove if blocks with !DevEnv.isDaoActivated() and combined && as isDaoActivated is always true the whole statement is always false 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-03 11:00:23 -05:00
HenrikJannsen
80e7dc7203
Remove tertiary operator DevEnv.isDaoActivated() ? as isDaoActivated is always true 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-03 11:00:22 -05:00
HenrikJannsen
72d97b8d97
Remove if (DevEnv.isDaoActivated()) checks as isDaoActivated is always true 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-03 10:51:01 -05:00
HenrikJannsen
008cfaac57
Remove daoActivated options 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-03 10:46:26 -05:00
HenrikJannsen
14312f08af
Add validateDisputeData, validateTradeAndDispute and validateSenderNodeAddress methods 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 23:59:12 -05:00
HenrikJannsen
04e501d450
We had not updated the contract hash after setting the signature. 
We verify later the contract hash in disputes and that would fail otherwise.
 2022-11-02 23:56:25 -05:00
HenrikJannsen
c49b811da3
Add verification of chain of transactions at DisputeSummaryWindow 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 23:24:05 -05:00
HenrikJannsen
60cd8b1e16
Add requestBlockchainTransactions and verifyTradeTxChain methods to RefundManager 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 23:15:41 -05:00
HenrikJannsen
0553a0f9d4
Add cachedDepositTx field to Dispute 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 23:15:11 -05:00
HenrikJannsen
0388c7c88a
Add block explorer tx as hex request using completeable future api 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 23:03:55 -05:00
HenrikJannsen
7f5675f054
Remove if case for old clients 
Remove null check for dispute

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:51:39 -05:00
HenrikJannsen
97648c51f3
Rename to make use case more clear 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:49:57 -05:00
HenrikJannsen
0bf44f061d
Remove addressAsString null check. That was when the donationAddress got added to support not updated nodes. Now there are none of such nodes. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:48:55 -05:00
HenrikJannsen
710dba9f36
Remove validateDonationAddress method without dispute param 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:47:39 -05:00
HenrikJannsen
5daaa60779
Refactor validateDonationAddress 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:44:58 -05:00
HenrikJannsen
3007652f4a
Remove dispute field from TradeDataValidation.ValidationException 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:41:46 -05:00
HenrikJannsen
cfb3780e6b
Move null check for address to validateDonationAddress method 
Remove dispute as unused param
Remove redundant methods

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:39:56 -05:00
HenrikJannsen
e8c6b0ae14
Remove daoFacade as unused parameter 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:32:28 -05:00
HenrikJannsen
cfc67dcc9c
Move validateDonationAddress to DisputeValidation 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:29:59 -05:00
HenrikJannsen
d86071db4a
Remove validateDonationAddress call inside validateDelayedPayoutTx. 
Add call to validateDonationAddress at client calling validateDelayedPayoutTx

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:28:41 -05:00
HenrikJannsen
2484fa4371
Part of a multistep refactoring to separate dispute related validation out of TradeDataValidation 
Refactor donationAddress validation out to new method
Rename addressAsString to delayedPayoutTxOutputAddressAsString
Recreate delayedPayoutTxOutputAddress at new validateDonationAddress method from relevant data

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:25:11 -05:00
HenrikJannsen
e49e634956
Move testIfAnyDisputeTriedReplay and related methods to DisputeValidation 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:14:55 -05:00
HenrikJannsen
37457ed132
Move validateDonationAddress to DisputeValidation 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:12:55 -05:00
HenrikJannsen
12686deff6
Move validateNodeAddress to DisputeValidation 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:11:23 -05:00
HenrikJannsen
aa22bd366a
Add DisputeValidation class for validation methods and exceptions of the dispute domain. 
Move AddressException, NodeAddressException and DisputeReplayException to DisputeValidation.
Use DisputeValidation.ValidationException as type for DisputeManager.validationExceptions.
Remove Nullable annotation for dispute field in those exceptions.
Remove null checks when those DisputeValidation.ValidationException are used.
 2022-11-02 22:09:30 -05:00
HenrikJannsen
43fb0cc635
Reformat code and reorg imports 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 21:22:35 -05:00
jmacxx
797bfe5cd5
Store the build's commit hash in Jarfile manifest. 2022-10-29 22:12:31 -05:00
Christoph Atteneder
80246e5d66
Update data stores for v1.9.6 2022-10-20 12:19:30 +02:00
Christoph Atteneder
6831f72a03
Update translations for v1.9.6 2022-10-13 09:53:23 +02:00
jmacxx
b35e316cdc
Warn at shutdown if Dispute message is pending. 2022-10-11 17:54:07 -05:00
jmacxx
b5dc6a4e45
Misc burn chart series CSS color settings and tooltip description. 2022-10-05 07:11:40 -05:00
jmacxx
8b92b2cdf5
UI Changes for BSQ Supply screen. 
Adds ability to track Misc Burnt amounts (incl. voting, asset listing etc)
Corrects the descriptions for Total BSQ and Change in supply.
 2022-10-05 07:11:36 -05:00
Christoph Atteneder
75e030f541
Merge pull request #6362 from jmacxx/dispute_min_payout 
Set the minimum payout at mediation to be 2.5% of trade amount
 2022-10-04 09:12:38 +02:00
Stephan Oeste
46139cf6b0
Remove c4talys7 seednodes and readd wiz seednodes 2022-09-28 15:16:25 +02:00
Android-X13
ee2db16451
Fix issue with offers getting disabled for no apparent reason 2022-09-20 20:55:19 +03:00
jmacxx
11e4469b0e
Set the minimum payout at mediation to be 2.5% of trade amount. 
If 2.5% is less than 0.0005 BTC, then fall back to 0.0005 BTC.
 2022-09-18 21:51:24 -05:00
ghubstan
a33a6e936b
Fix BSQ buyer's displayed trade fee for gettrade(s) methods 
API clients looking at their BSQ swap trades -- BSQ buyers
specifically -- were seeing a 0.00 BSQ trade fee, due to an
incorrect assumption BSQ sellers paid the entire BSQ trade
fee for both sides.  BSQ Swap execution via API has been
working just like the GUI (same code-base), but the reported
trade fee for the BSQ buy side was wrong.
This change shows the correct BSQ trade fee.

Partially addresses issue https://github.com/bisq-network/bisq/issues/6355
 2022-09-11 16:06:59 -03:00
ghubstan
d32fd4e97b
Improve CLI takeoffer man-page param descriptions 2022-09-11 12:26:00 -03:00
Christoph Atteneder
4a359997ff
Merge pull request #6333 from ripcurlx/update-data-stores-for-v1.9.5 
Update data stores for v1.9.5
 2022-08-22 17:57:04 +02:00
jmacxx
4e8e6eb9ac
Use getCurrencyCode method rather than directly accessing member. 
The transient currencyCode member is null until the getter method
has been used, so we should no access the variable directly.

This fixes a problem with OfferBook filtering, which was checking
for isFiat(currencyCode); the variable was null and isFiat returned
the wrong answer.
 2022-08-22 15:53:47 +02:00
Stephan Oeste
dd66520a24
Remove sn2bisqad7... Seeednode 2022-08-22 15:53:21 +02:00
Christoph Atteneder
827ddb071f
Update bitcoinj checkpoints for v1.9.5 2022-08-22 11:46:26 +02:00
Christoph Atteneder
cc11c28ffe
Update translations for v1.9.5 2022-08-21 21:34:06 +02:00
Christoph Atteneder
d2c7824740
Merge pull request #6315 from wiz/wiz/remove-wiz-seed-nodes 
Remove 3 wiz seed nodes
 2022-08-19 12:42:44 +02:00
Stephan Oeste
e878aec78c
Add new Seednodes from jmacxx and c4talys7 2022-08-19 11:48:23 +02:00
jmacxx
8e21682e92
Add P2P network status indicator. 2022-08-18 10:46:39 -05:00
wiz
f193b4a4c5
Remove 3 wiz seed nodes 2022-08-09 18:07:08 +09:00
Christoph Atteneder
423d57ae24
Merge pull request #6312 from ghubstan/support-choosing-trade-amount-in-range 
API takeoffer:  Let user choose intended trade amount
 2022-08-07 21:36:41 +02:00
ghubstan
c57b573d5c
Document TakeOfferRequest's intended trade amt param 2022-08-06 15:09:00 -03:00
ghubstan
7d4e7dd696
Support TakeOfferRequest's intended trade amt in daemon 2022-08-06 15:08:30 -03:00
chimp1984
6aa91a4ee4
Add check for date 2022-08-01 17:07:17 +02:00
chimp1984
aebabcb53e
Add api for account age and signed account age witness 2022-08-01 00:34:06 +02:00
chimp1984
ef81bde7f2
Add export feature for signed account age witness 2022-07-31 14:40:18 +02:00
chimp1984
2b6dd187c6
Add export feature for account age 2022-07-25 20:50:43 +02:00
chimp1984
2628eea9db
Add bsq bonds 2022-07-25 00:12:13 +02:00
Christoph Atteneder
ec00c9962f
Merge pull request #6282 from jmacxx/adjust_blocks_response_size 
GetBlocksResponse lower chunk size (was 6000 now 4000).
 2022-07-13 12:33:00 +02:00
Christoph Atteneder
f0db45255a
Merge pull request #6283 from jmacxx/clear_sensitive_data_2 
Clear sensitive data from trade ProcessModel
 2022-07-12 09:55:22 +02:00
Bisq GitHub Admin
fa635bd304
Merge pull request #6286 from bisq-network/release/v1.9.4 
Release v1.9.4
 2022-07-12 09:20:32 +02:00
jmacxx
aacabb9685
Clear sensitive data from trade ProcessModel. 2022-07-06 13:24:26 -05:00
jmacxx
12d3256f20
GetBlocksResponse lower chunk size (was 6000 now 4000). 
We lower the number of blocks delivered in a message to avoid
exceeding the max network message size.
 2022-07-06 08:17:05 -05:00
Christoph Atteneder
9011ebbd3f
Fix incorrect version number for new feature popup 2022-07-05 10:57:45 +02:00
Christoph Atteneder
bca997a55b
Merge pull request #6219 from ghubstan/wip-prep-bisq-for-bitcoin-v23 
Prepare Bisq for bitcoin-core v23 compatiblity
 2022-07-05 09:05:08 +02:00
chimp1984
b515ec7342
Update text and default series 2022-06-30 20:20:02 +02:00
chimp1984
70e2f7c53b
Add supply change series. 
Remove BsqSupplyChange. Use existing methods for supply calculation
(existing method was incorrect as far I understand).
 2022-06-30 20:19:52 +02:00
chimp1984
e08f7b6c09
Add new series. Regroup series. Add tooltips. 2022-06-30 20:19:38 +02:00
jmacxx
a5ba349574
Clear Tor directory when a new release is downloaded. 2022-06-30 20:19:25 +02:00
Christoph Atteneder
9b2c4807bf
Merge pull request #6274 from chimp1984/improve-dao-chats-legends 
Improve dao chats legends
 2022-06-30 20:17:04 +02:00
jmacxx
e1bc92eee5
Clear Tor directory when a new release is downloaded. 2022-06-30 07:04:17 -05:00
chimp1984
09cf4c8a73
Update text and default series 2022-06-29 19:01:20 +02:00
chimp1984
c91ba4a8e0
Add supply change series. 
Remove BsqSupplyChange. Use existing methods for supply calculation
(existing method was incorrect as far I understand).
 2022-06-29 18:50:43 +02:00
chimp1984
42d3df04f7
Add new series. Regroup series. Add tooltips. 2022-06-29 17:24:25 +02:00