Go to file
Nick Mathewson 9cf6af76eb Fix a double-free bug in routerlist_reparse_old
I introduced this bug when I moved signing_key_cert into
signed_descriptor_t. Bug not in any released Tor.  Fixes bug 19175, and
another case of 19128.

Just like signed_descriptor_from_routerinfo(), routerlist_reparse_old()
copies the fields from one signed_descriptor_t to another, and then
clears the fields from the original that would have been double-freed by
freeing the original.  But when I fixed the s_d_f_r() bug [#19128] in
50cbf22099, I missed the fact that the code was duplicated in
r_p_o().

Duplicated code strikes again!

For a longer-term solution here, I am not only adding the missing fix to
r_p_o(): I am also extracting the duplicated code into a new function.

Many thanks to toralf for patiently sending me stack traces until
one made sense.
2016-05-25 16:11:35 -04:00
changes Merge branch 'bug19161_028_v2' into maint-0.2.8 2016-05-25 10:17:26 -04:00
contrib and NOW the version is 0.2.8.2-alpha-dev 2016-03-28 15:53:17 -04:00
doc minor touchups on nick's ticket 17621 changes 2016-05-11 16:35:36 -04:00
m4 Add pkg.m4 to use pkgconfig macros 2014-12-23 11:39:48 -05:00
scripts Simplify string cleansing in fallback update script 2016-04-29 11:59:46 +10:00
src Fix a double-free bug in routerlist_reparse_old 2016-05-25 16:11:35 -04:00
.gitignore Do not ignore files that are being tracked by git 2016-05-23 11:02:15 -04:00
acinclude.m4 Fedora Core->Fedora; yum->dnf. 2016-03-11 09:13:33 -05:00
autogen.sh Use a nicely written autoconf macro to determine the sign of a type 2013-02-07 16:23:48 -05:00
ChangeLog rewrap changelog 2016-03-28 13:54:50 -04:00
configure.ac Make sure that libscrypt_scrypt actually exists before using it. 2016-05-24 10:31:02 -04:00
Doxyfile.in Use output variables instead of relative paths. 2015-03-14 13:00:04 -04:00
INSTALL Small fixes for the 2702 implementation 2011-04-02 12:15:08 +02:00
LICENSE Update the copyright year. 2016-02-27 18:48:19 +01:00
Makefile.am Merge branch 'maint-0.2.7' into maint-0.2.8 2016-05-09 18:14:44 -04:00
Makefile.nmake Clean up the MVSC nmake files so they work again. 2014-09-09 10:27:05 -04:00
README Move hacking documentation into a new subdirectory. 2015-10-09 10:40:53 -04:00
ReleaseNotes minor changelog cleanups to help the new alpha 2016-03-28 13:20:51 -04:00

Tor protects your privacy on the internet by hiding the connection
between your Internet address and the services you use. We believe Tor
is reasonably secure, but please ensure you read the instructions and
configure it properly.

To build Tor from source:
        ./configure && make && make install

To build Tor from a just-cloned git repository:
        sh autogen.sh && ./configure && make && make install

Home page:
        https://www.torproject.org/

Download new versions:
        https://www.torproject.org/download/download.html

Documentation, including links to installation and setup instructions:
        https://www.torproject.org/docs/documentation.html

Making applications work with Tor:
        https://wiki.torproject.org/projects/tor/wiki/doc/TorifyHOWTO

Frequently Asked Questions:
        https://www.torproject.org/docs/faq.html


To get started working on Tor development:
        See the doc/HACKING directory.