Roger Dingledine
e17fd57782
fix typo
2012-10-23 17:15:28 -04:00
Nick Mathewson
98c24670e7
Merge remote-tracking branch 'origin/maint-0.2.3'
2012-10-23 16:28:34 -04:00
Nick Mathewson
85659d3964
Fix parse_short_policy (bug 7192.)
...
Our implementation of parse_short_policy was screwed up: it would
ignore the last character of every short policy. Obviously, that's
broken.
This patch fixes the busted behavior, and adds a bunch of unit tests
to make sure the rest of that function is okay.
Fixes bug 7192; fix on 0.2.3.1-alpha.
2012-10-23 13:49:48 -04:00
Roger Dingledine
4c8b58f900
add a unit test to expose bug 7192
2012-10-22 17:09:43 -04:00
Nick Mathewson
848333c6d6
Fix more madness from the split_circuitbuild merge
2012-10-22 14:36:30 -04:00
Nick Mathewson
fa6a65756f
Kill extraneous x from 907db008ab
...
Looks like clang doesn't complain about this kind of thing.
Spotted by Andrea. Bug not in any released version.
2012-10-22 14:29:15 -04:00
Nick Mathewson
86258df65d
Merge branch 'split_circuitbuild'
...
Conflicts:
src/or/circuitbuild.c
There was a huge-looking conflict in circuitbuild.c, but the only
change that had been made to circuitbuild.c since I forked off the
split_circuitbuild branch was 17442560c4
. So I took the
split_circuitbuild version of the conflicting part, and manually
re-applied the change from 17442560c44e8093f9a..
2012-10-22 11:35:32 -04:00
Linus Nordberg
8c9b427425
Name variables more consistently.
2012-10-22 12:36:34 +02:00
Linus Nordberg
9d71d97e9d
Document two functions.
2012-10-22 12:24:29 +02:00
Linus Nordberg
172aac62ed
Rename C reserved identifiers missed before.
2012-10-20 20:56:59 +02:00
Linus Nordberg
cb51807236
Add "IPVersions" to control command "status/clients-seen".
2012-10-20 20:56:59 +02:00
Linus Nordberg
af175fa7e4
Duplicate less code.
2012-10-20 20:56:59 +02:00
Linus Nordberg
817ff962f8
Separate IPv4 and IPv6 geoip file loading.
...
Also add IPv6 geoip file digest to extra info.
Also also, add support for IPv6 addresses in control command
"ip-to-country".
2012-10-20 20:56:59 +02:00
Nick Mathewson
e8f547c181
Merge branch 'block_renegotiate_024'
2012-10-19 14:32:42 -04:00
Nick Mathewson
1cc06bd35e
Merge branch 'block_renegotiate_023' into maint-0.2.3
2012-10-19 14:30:31 -04:00
Nick Mathewson
0dac0d8ad6
Merge remote-tracking branch 'origin/maint-0.2.3'
2012-10-19 03:06:15 -04:00
Robert Ransom
d3bfdd6108
Don't serve or accept v2 HS descs over a DirPort
...
(changes file tweaked by nickm)
2012-10-19 02:56:25 -04:00
Andrea Shepard
981f25a73a
Factor out common parts of channel_tls_connect() and channel_tls_handle_incoming(); fixes get_remote_addr problem with incoming connections for bug 7112
2012-10-18 21:53:50 -04:00
Nick Mathewson
3d8b73db55
Discard extraneous renegotiation attempts in the v3 link protocol
...
Failure to do so left us open to a remotely triggerable assertion
failure. Fixes CVE-2012-2249; bugfix on 0.2.3.6-alpha. Reported by
"some guy from France".
This patch is a forward-port to 0.2.4, to work with the new channel
logic.
2012-10-17 19:19:58 -04:00
Nick Mathewson
f357ef9dcc
Discard extraneous renegotiation attempts in the v3 link protocol
...
Failure to do so left us open to a remotely triggerable assertion
failure. Fixes CVE-2012-2249; bugfix on 0.2.3.6-alpha. Reported by
"some guy from France".
2012-10-17 19:18:16 -04:00
Nick Mathewson
850c990144
Fix a bug in channel_dump_statistics
...
We were calling channel_get_actual_remote_descr() before we used the
output of a previous channel_get_canonical_remote_descr(), thus
invalidating its output.
2012-10-17 11:29:59 -04:00
Nick Mathewson
cb9d123764
Document lifespan of return values of the _remote_descr() funcs
2012-10-17 11:29:37 -04:00
Nick Mathewson
26946c659b
Restore the 'address' value of tunneled connections
...
When we merged the channel code, we made the 'address' field of linked
directory connections created with begindir (and their associated edge
connections) contain an address:port string, when they should only
have contained the address part.
This patch also tweaks the interface to the get_descr method of
channels so that it takes a set of flags rather than a single flag.
2012-10-17 11:23:26 -04:00
Nick Mathewson
898bd1ae8f
Fix for bug 7112 (spewing complaints from tor_addr_is_internal)
...
In 4768c0efe3
(not in any released
version of Tor), we removed a little block of code that set the addr
field of an exit connection used in making a tunneled directory
request. Turns out that wasn't right.
2012-10-17 11:15:01 -04:00
Nick Mathewson
f633184af1
Document return value of channel_get_addr_if_possible
2012-10-17 11:12:59 -04:00
Linus Nordberg
e2313d8622
White space.
2012-10-17 14:01:02 +02:00
Andrea Shepard
35f573136d
Use LD_PROTOCOL rather than LD_BUG to warn about bogus reason codes that originated remotely in circuit_end_reason_to_control_string()
2012-10-17 03:24:28 -07:00
Andrea Shepard
17442560c4
Fix mal-merge, don't | END_CIRC_REASON_CHANNEL_CLOSED into reason codes in circuit_truncated()
2012-10-17 03:23:35 -07:00
Linus Nordberg
74c6dafed6
Two changes lost in rebase resurrected.
2012-10-17 12:13:49 +02:00
Linus Nordberg
19ab7b1639
Rename reserved C identifiers.
2012-10-17 10:54:53 +02:00
Karsten Loesing
1f849f9181
Minor tweaks to nils' v4 vs v6 bridge usage code.
2012-10-17 10:54:53 +02:00
Karsten Loesing
c03e3d66a9
Minor tweaks and comments to nils' geoip v6 code.
2012-10-17 10:54:52 +02:00
nils
31e224173b
Include statistics as to how many connections are IPv4 versus IPv6
2012-10-17 10:54:52 +02:00
nils
abb886014e
Add GeoIP database for IPv6 addresses
2012-10-17 10:54:52 +02:00
nils
167363403b
Rename address family specific IPv4 geoip functions in preparation for IPv6 support
2012-10-17 10:54:17 +02:00
Andrea Shepard
94a0309909
Merge branch 'bug7087_2' of ssh://git-rw.torproject.org/user/andrea/tor
2012-10-15 13:04:55 -07:00
Andrea Shepard
ac227cf587
Close and free channel_tls_listener correctly in channel_tls_free_all()
2012-10-15 12:22:20 -07:00
Nick Mathewson
907db008ab
Move the circuit build timeout code into its own file.
2012-10-15 14:50:55 -04:00
Nick Mathewson
9e9edf71f7
Split code for entry guards and bridges into a new module.
2012-10-15 14:28:23 -04:00
Nick Mathewson
f38fb29502
whitesapce fix
2012-10-15 11:22:53 -04:00
Nick Mathewson
9f83142591
Merge remote-tracking branch 'public/bug1031'
2012-10-15 11:20:48 -04:00
Andrea Shepard
99057014ba
Add debug logging to channel_listener_free()/channel_listener_force_free()
2012-10-15 07:56:35 -07:00
Nick Mathewson
469b847c70
Fix a long line
2012-10-15 10:55:52 -04:00
Markus Teich
5a959163d3
fixed differing returntype in definition and declaration of dirserv_add_extrainfo
2012-10-15 10:53:11 -04:00
Andrea Shepard
4da2864308
Merge branch 'bug7087' of git://git.torproject.org/user/andrea/tor
2012-10-15 07:22:33 -07:00
Andrea Shepard
3894ca1508
Add debug logging for channel_free() and channel_force_free()
2012-10-15 06:46:23 -07:00
Andrea Shepard
9ef286ec8f
Correctly clear cmux policies and free cmux in channel_free() and channel_force_free()
2012-10-15 06:32:44 -07:00
Nick Mathewson
0d946e1773
Merge remote-tracking branch 'arma/bug7029'
2012-10-14 23:06:43 -04:00
Roger Dingledine
38b7947386
fix trivial typo
2012-10-13 18:34:24 -04:00
Nick Mathewson
2b10e99eb0
Try refactoring channel list to use HT_ and LIST_ stuff directly
2012-10-12 20:16:43 -04:00