Nick Mathewson
d373922217
Speak not the name of INT_MIN; it can upset older compilers
...
And more to the point, some GCCs will warn that you can't say it
before C90.
Bug not in any released version of Tor.
2012-08-03 13:54:12 -04:00
Nick Mathewson
aa584fd3a3
Merge remote-tracking branch 'origin/maint-0.2.3'
2012-08-03 12:04:36 -04:00
Nick Mathewson
93be3a8822
Merge remote-tracking branch 'origin/maint-0.2.2' into maint-0.2.3
...
Conflicts:
src/or/routerlist.c
2012-08-03 12:04:11 -04:00
Robert Ransom
308f6dad20
Mitigate a side-channel leak of which relays Tor chooses for a circuit
...
Tor's and OpenSSL's current design guarantee that there are other leaks,
but this one is likely to be more easily exploitable, and is easy to fix.
2012-08-03 11:49:51 -04:00
Nick Mathewson
860c4fc811
Merge remote-tracking branch 'origin/maint-0.2.3'
2012-08-03 11:46:03 -04:00
Robert Ransom
82c5e385cb
Remove bogus comment claiming that an assertion is triggerable by consensus
2012-08-03 11:45:33 -04:00
Nick Mathewson
6c64681879
Fix a bunch of "implicit 64->32" warnings from introduce refactoring
2012-08-03 11:31:04 -04:00
Nick Mathewson
babf8e2a85
Merge remote-tracking branch 'origin/maint-0.2.3'
2012-08-03 11:23:06 -04:00
Nick Mathewson
1040afb242
Merge remote-tracking branch 'origin/maint-0.2.2' into maint-0.2.3
2012-08-03 11:18:40 -04:00
Nick Mathewson
57e35ad3d9
Avoid possible segfault when handling networkstatus vote with bad flavor
...
Fix for 6530; fix on 0.2.2.6-alpha.
2012-08-03 10:53:00 -04:00
Matthew Finkel
b50eb14bbf
Updated docs for new connections.
2012-08-02 16:15:23 -04:00
Nick Mathewson
65d8448209
Merge remote-tracking branch 'sysrqb/bug6518'
2012-08-02 15:45:10 -04:00
Matthew Finkel
a47e4343de
Constify struct sockaddr *sa parameter for check
...
The values are only being checked, not modified.
2012-08-02 15:29:38 -04:00
Matthew Finkel
d91bbf376c
Removed redundant check_sockaddr_family_match call
2012-08-02 15:13:34 -04:00
Nick Mathewson
2d6d5db2fe
Defensive programming: clear rs_out between iterations.
...
I can't currently find a bug here, but there are a couple of
near-misses. Addresses ticket 6514; reported pseudonymously on
IRC.
2012-08-01 17:25:34 -04:00
Nick Mathewson
c49975a2b8
Merge remote-tracking branch 'origin/maint-0.2.3'
2012-07-31 17:20:36 -04:00
Nick Mathewson
62637fa224
Avoid hard (impossible?)-to-trigger double-free in dns_resolve()
...
Fixes 6480; fix on 0.2.0.1-alpha; based on pseudonymous patch.
2012-07-31 17:19:17 -04:00
Nick Mathewson
3763959ef0
test_assert is always in affect: no need for extra gotos
2012-07-31 17:08:13 -04:00
Nick Mathewson
3c30417339
Remove duplicate code in test_introduce.c
...
Two of the do_*_test functions were actually prefixes of the third,
which suggests a trivial code elimination step
2012-07-31 17:08:13 -04:00
Nick Mathewson
92f5eaa235
Whitespace tweaks
2012-07-31 17:08:13 -04:00
Andrea Shepard
96c7612679
Unit tests for new rend_intro_cell_t parser
2012-07-31 17:08:13 -04:00
Andrea Shepard
048c128f93
Add replaycache.h to noinst_HEADERS in src/or/Makefile.am
2012-07-31 17:08:12 -04:00
Andrea Shepard
471ab34032
Refactor INTRODUCE2 parsing code in rend_service_introduce()
2012-07-31 17:08:12 -04:00
Andrea Shepard
36c968491f
Use new replaycache_t structure for replay detection in rend_service_introduce()
2012-07-31 17:08:12 -04:00
Andrea Shepard
8f63ef10ad
Implement replaycache_t for bug 6177, and unit tests for the preceding
2012-07-31 17:08:05 -04:00
Nick Mathewson
d3e1e458e1
Remove the upper limit on the size of MD we can generate.
2012-07-31 13:12:07 -04:00
Nick Mathewson
063138e001
Warn at parse time for routerstatus entry missing a microdesc consensus
...
In 0.2.3.18-rc, we started warning on this case while building a
list of missing microdescriptor digests. That turned out to spam
the logs; instead let's warn at parse time.
Partial fix for bug 6404.
2012-07-31 11:01:57 -04:00
Nick Mathewson
7143d112a6
Don't include a router in an md consensus if we can't find a md for it.
...
The spec requires that every router in a microdesc consensus have an
m line; we weren't obeying that spec.
This creates a new consensus method (13) to allow voting to continue
to work right. Partial fix for bug 6404; fix on 0.2.2.6-alpha.
2012-07-31 10:54:14 -04:00
Nick Mathewson
2503cfad24
Allow microdescs to be up to 2k. Partial fix for 6404.
2012-07-31 10:48:35 -04:00
Nick Mathewson
5919e8e561
Merge remote-tracking branch 'origin/maint-0.2.3'
2012-07-31 10:29:34 -04:00
Nick Mathewson
aed93f8ad9
Merge branch 'bug6490_v2' into maint-0.2.3
2012-07-31 10:28:43 -04:00
Nick Mathewson
2bd45213c9
Warn when accounting is used in a way likely to link hidden services
...
Fix for 6490.
2012-07-31 10:28:16 -04:00
Roger Dingledine
1049d315d7
Merge branch 'maint-0.2.3'
2012-07-31 05:10:23 -04:00
Roger Dingledine
1004489354
trivial grammar fix
2012-07-31 05:10:05 -04:00
Nick Mathewson
08e65ce04f
Fix small memleak introduced in recent patch; fixe 6455.
2012-07-24 10:20:00 -04:00
Nick Mathewson
20b625a0fd
Merge remote-tracking branch 'origin/maint-0.2.3'
2012-07-23 12:36:04 -04:00
Nick Mathewson
692005b38d
Merge remote-tracking branch 'asn/bug6274_take3' into maint-0.2.3
2012-07-23 12:35:23 -04:00
Linus Nordberg
fff842a47c
Add config option AuthDirPublishIPv6.
...
Test for config option AuthDirPublishIPv6 == 1 rather than for running
as a bridge authority when deciding whether to care or not about IPv6
OR ports in descriptors.
Implements enhancement #6406 .
2012-07-19 17:51:15 -04:00
Nick Mathewson
6208106c18
Try to re-approximate the older semantics of nodelist_add_routerinfo
2012-07-19 17:51:15 -04:00
Linus Nordberg
dee4f068ee
Don't shadow 'buf'.
2012-07-19 18:21:23 +02:00
Linus Nordberg
044da1bf0f
Add configure option AuthDirHasIPv6Connectivity.
...
Implements enhancement 5974.
2012-07-19 18:21:22 +02:00
Linus Nordberg
cdef2b181a
Rename routers_have_same_or_addr() to reflect the fact that it now checks both OR ports.
2012-07-19 18:21:22 +02:00
Linus Nordberg
7c80a4502c
Include IPv6 OR ports in status documents only if we're a bridge authority.
2012-07-19 18:21:21 +02:00
Linus Nordberg
6d99c51f15
Don't put unreachable IPv6 OR port in routerstatus.
...
To have only reachable ports in "a" lines.
2012-07-19 18:21:21 +02:00
Linus Nordberg
dda177b19e
Add "a" line to status document.
2012-07-19 18:21:21 +02:00
Linus Nordberg
4cce8ab742
Add last_reachable and testing_since for IPv6 OR port.
2012-07-19 18:21:20 +02:00
Linus Nordberg
c1ff07440e
Don't assume that a node has routerinfo.
...
We can end up in dirserv_orconn_tls_done() with a node missing
routerinfo in at least two cases -- command_process_certs_cell() and
connection_or_check_valid_tls_handshake() -- and probably more.
2012-07-19 18:21:20 +02:00
Linus Nordberg
631ec5c4fe
Move last_reachable and testing_since from routerinfo_t to node_t.
2012-07-19 18:21:20 +02:00
Nick Mathewson
24451e6f7d
Avoid double-typedef of transport_t.
...
You can say "struct foo_t" as much as you want, but you'd better not
have "typedef struct foo_t foo_t" more than once.
Fix for bug 6416. Bug not in any released version of Tor.
2012-07-19 09:06:11 -04:00
George Kadianakis
a1d060a68f
Better handling of server managed proxies when Tor is not a relay.
2012-07-18 20:01:02 +02:00
