mirrors/tor

Fork 0

mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2025-02-28 00:53:04 +01:00

Commit graph

Author	SHA1	Message	Date
Samanta Navarro	4a0cd79588	Fix typos. Typos found with codespell. Please keep in mind that this should have impact on actual code and must be carefully evaluated: src/core/or/lttng_circuit.inc - ctf_enum_value("CONTROLER", CIRCUIT_PURPOSE_CONTROLLER) + ctf_enum_value("CONTROLLER", CIRCUIT_PURPOSE_CONTROLLER)	2020-11-12 11:44:09 -05:00
David Goulet	2edda444da	test: Missing tor_free() in metrics unit tests Found by coverity: *** CID 1468664: Resource leaks (RESOURCE_LEAK) /src/test/test_metrics.c: 83 in test_config() 77 tt_int_op(ret, OP_EQ, false); 78 79 done: 80 SMARTLIST_FOREACH(ports, port_cfg_t *, c, port_cfg_free(c)); 81 smartlist_free(ports); 82 or_options_free(options); >>> CID 1468664: Resource leaks (RESOURCE_LEAK) >>> Variable "err_msg" going out of scope leaks the storage it points to. 83 } 84 85 static char _c_buf[256]; 86 #define CONTAINS(conn, msg) \ 87 do { \ 88 tt_int_op(buf_datalen(conn->outbuf), OP_EQ, (strlen(msg))); \ Signed-off-by: David Goulet <dgoulet@torproject.org>	2020-10-28 08:52:02 -04:00
David Goulet	f65c0820af	test: Metrics tests for lib/ and feature/ Related to #40063 Signed-off-by: David Goulet <dgoulet@torproject.org>	2020-10-27 10:43:42 -04:00

Author

SHA1

Message

Date

Samanta Navarro

4a0cd79588

Fix typos.

Typos found with codespell.

Please keep in mind that this should have impact on actual code
and must be carefully evaluated:

src/core/or/lttng_circuit.inc
-    ctf_enum_value("CONTROLER", CIRCUIT_PURPOSE_CONTROLLER)
+    ctf_enum_value("CONTROLLER", CIRCUIT_PURPOSE_CONTROLLER)

2020-11-12 11:44:09 -05:00

David Goulet

2edda444da

test: Missing tor_free() in metrics unit tests

Found by coverity:

  *** CID 1468664:  Resource leaks  (RESOURCE_LEAK)
  /src/test/test_metrics.c: 83 in test_config()
  77       tt_int_op(ret, OP_EQ, false);
  78
  79      done:
  80       SMARTLIST_FOREACH(ports, port_cfg_t *, c, port_cfg_free(c));
  81       smartlist_free(ports);
  82       or_options_free(options);
  >>>     CID 1468664:  Resource leaks  (RESOURCE_LEAK)
  >>>     Variable "err_msg" going out of scope leaks the storage it points to.
  83     }
  84
  85     static char _c_buf[256];
  86     #define CONTAINS(conn, msg) \
  87       do { \
  88         tt_int_op(buf_datalen(conn->outbuf), OP_EQ, (strlen(msg))); \

Signed-off-by: David Goulet <dgoulet@torproject.org>

2020-10-28 08:52:02 -04:00

David Goulet

f65c0820af

test: Metrics tests for lib/ and feature/

Related to #40063

Signed-off-by: David Goulet <dgoulet@torproject.org>

2020-10-27 10:43:42 -04:00

3 commits