12 commits

Author	SHA1	Message	Date
Nick Mathewson	eb856a3e51	strcasecmp should not take a size_t argument	2018-07-09 11:17:23 -04:00
Nick Mathewson	fecb8214d5	Try to use stricmp variants that MSDN actually recommends ... Per recommendation by Gisle Vanem	2018-07-05 13:51:50 -04:00
rl1987	fedb3e46ec	Remove ATTR_NONNULL macro	2018-07-03 12:33:09 +03:00
Nick Mathewson	c8ccd028a7	Don't redefine str(n)casecmp on windows unless they're missing ... When we do redefine them, use inline functions instead of #define. This fixes a latent code problem in our redefinition of these functions, which was exposed by our refactoring: Previously, we would #define strcasecmp after string.h was included, so nothing bad would happen. But when we refactored, we would sometimes #define it first, which was a problem on mingw, whose headers contain (approximately): inline int strcasecmp (const char *a, const char *b) { return _stricmp(a,b); } Our define turned this into: inline int _stricmp(const char *a, const char *b) { return _stricmp(a,b); } And GCC would correctly infer that this function would loop forever, rather than actually comparing anything. This caused bug 26594. Fixes bug 26594; bug not in any released version of Tor.	2018-07-02 11:50:17 -04:00
Taylor Yu	f9e22c68a0	Fix macOS includes ... Recent code movement from refactoring missed some includes that seem to be necessary on macOS.	2018-06-28 17:15:53 -05:00
Nick Mathewson	e165c9c304	Move various mem* functions to lib/string	2018-06-27 16:18:42 -04:00
Nick Mathewson	9e592d1dec	Move tor_strtok_r to libtor-string	2018-06-27 15:28:55 -04:00
Nick Mathewson	80730c45e0	Move tor_parse_long and friends into parse_int.h in libtor-string	2018-06-26 21:02:29 -04:00
Nick Mathewson	1b93b065fc	Make an inline static so we can build with coverage enabled.	2018-06-22 14:11:37 -04:00
Nick Mathewson	cf66544941	Two more small changes for CI.	2018-06-22 13:10:52 -04:00
Nick Mathewson	90a09df5ba	Extract strlcpy and strlcmp to libtor-string	2018-06-22 11:18:19 -04:00
Nick Mathewson	1abadee3fd	Extract key string manipulation functions into a new library.	2018-06-22 09:49:13 -04:00