Roger Dingledine
28b755e660
refactor out the tor_event_base_loopexit() call
...
no actual changes
2016-11-01 19:52:54 -04:00
Nick Mathewson
cb35a7c271
Merge branch 'maint-0.2.9'
2016-11-01 13:05:45 -04:00
Nick Mathewson
733b245283
Merge remote-tracking branch 'teor/bug20472-029-v2' into maint-0.2.9
2016-11-01 13:05:33 -04:00
Nick Mathewson
59a78187cd
Merge branch 'maint-0.2.9'
2016-10-31 15:20:45 -04:00
Nick Mathewson
24b7b922ae
Actually free the worker_state_t object when we do an update with it
...
Previously we freed the old "keys" object, but leaked the
worker_state_t that we had taken it from.
Fixes bug 20401; bugfix on 0.2.6.3-alpha.
2016-10-31 15:20:25 -04:00
Nick Mathewson
d73c671d6d
policy_is_reject_star():
...
ome policies are default-reject, some default-accept. But
policy_is_reject_star() assumed they were all default_reject. Fix
that!
Also, document that policy_is_reject_star() treats a NULL policy as
empty. This allows us to simplify the checks in
parse_reachable_addresses() by quite a bit.
Fxes bug 20306; bugfix on 0.2.8.2-alpha.
2016-10-31 15:05:56 -04:00
Nick Mathewson
8841a9e396
Create single-onion-service directory before poisoning it, if needed
...
(Also, refactor the code to create a hidden service directory into a
separate funcion, so we don't have to duplicate it.)
Fixes bug 20484; bugfix on 0.2.9.3-alpha.
2016-10-31 14:54:20 -04:00
teor
3158777d35
Rename routerstatus_version_supports_ntor to *_supports_extend2_cells
...
This helps avoid the confusion that caused bug 20472.
Bugfix on commit 10aa913
from #19163 in tor-0.2.9.3-alpha.
2016-10-31 17:02:21 +11:00
teor
d81f2b5d81
Refactor circuit_pick_create_handshake
...
Make the structure of circuit_pick_create_handshake consistent with
circuit_pick_extend_handshake.
No behaviour change.
2016-10-31 17:01:33 +11:00
teor
26d7a07ad7
In circuit_pick_extend_handshake, assume all hops support EXTEND2 and ntor
...
This simplifies the function: if we have an ntor key, use ntor/EXTEND2,
otherwise, use TAP/EXTEND.
Bugfix on commit 10aa913
from 19163 in 0.2.9.3-alpha.
2016-10-31 17:01:04 +11:00
Nick Mathewson
ada75d5567
Fix bad warning when checking IP policies.
...
I had replaced a comment implying that a set of ifs was meant to be
exhaustive with an actual check for exhaustiveness. It turns out,
they were exhaustive, but not in the way I had assumed. :(
Bug introduced in f3e158edf7
, not in any released Tor.
2016-10-28 15:33:12 -04:00
Nick Mathewson
f3e158edf7
Comment the heck out of the stream/circuit attaching process.
2016-10-27 12:04:43 -04:00
David Goulet
70b9e79700
Slightly refactor and fix couple callsites
...
Signed-off-by: David Goulet <dgoulet@torproject.org>
2016-10-27 10:34:02 -04:00
Nick Mathewson
dc79504e2a
Document main.c a lot better
2016-10-27 10:25:26 -04:00
Ivan Markin
23b878b875
Do assert when calling relay_send_command_from_edge() on OR-side circs
2016-10-27 10:19:06 -04:00
Ivan Markin
2d04946960
Do not mark circs for close again after relay_send_command_from_edge()
2016-10-27 10:19:04 -04:00
overcaffeinated
265d5446fa
Automated change to use smartlist_add_strdup
...
Use the following coccinelle script to change uses of
smartlist_add(sl, tor_strdup(str)) to
smartlist_add_strdup(sl, string) (coccinelle script from nickm
via bug 20048):
@@
expression a;
expression b;
@@
- smartlist_add
+ smartlist_add_strdup
(a,
- tor_strdup(
b
- )
)
2016-10-27 10:26:06 +01:00
Nick Mathewson
77d14b5f56
Small refactoring: explain G,M,E,D,T initialization
2016-10-26 16:39:59 -04:00
Matt Traudt
7ba0ae9426
Add consensus weight calculation tests
2016-10-26 16:37:16 -04:00
Matt Traudt
909ee0e55f
Fix default bw weights with new consensus method
...
See #14881
2016-10-26 16:33:54 -04:00
Nick Mathewson
39375db3dc
Merge remote-tracking branch 'pastly/ticket20459'
2016-10-26 16:22:06 -04:00
Nick Mathewson
5a1779b7ff
Merge branch 'maint-0.2.9'
2016-10-26 14:17:21 -04:00
Nick Mathewson
d288704023
Avoid tor_fragile_assert() failure with DNSPort on RESOLVED_TYPE_ERROR
...
The tor_fragile_assert() bug has existed here since c8a5e2d588
in tor-0.2.1.7-alpha forever, but tor_fragile_assert() was mostly a
no-op until 0.2.9.1-alpha.
Fixes bug 19869.
2016-10-26 14:16:40 -04:00
Nick Mathewson
8a38d053a0
Continue the module documentation effort with circuitbuild and circuituse
2016-10-26 13:30:23 -04:00
Nick Mathewson
9c8dbcd0d6
More module documentation (circpathbias, circuitlist)
2016-10-26 12:38:50 -04:00
Nick Mathewson
a5f07a6c2a
More module-level documentation.
2016-10-26 11:02:57 -04:00
Nick Mathewson
04b8af9dc0
Whitespace fixes
2016-10-26 08:39:04 -04:00
Nick Mathewson
8cc528c750
Allow asking a bridge's own descriptor over one-hop connection
...
When we refactored purpose_needs_anonymity(), we made it so _all_
bridge requests required anonymity. But that missed the case
that we are allowed to ask a bridge for its own descriptor.
With this patch, we consider the resource, and allow "authority.z"
("your own descriptor, compressed") for a bridge's server descriptor
to be non-anonymous.
Fix for bug 20410; bug not in any released Tor.
2016-10-26 08:32:48 -04:00
Matt Traudt
c09993fdf6
Fix ewma_cmp_cmux never considering policies different
2016-10-25 10:07:05 -04:00
Nick Mathewson
01482e30ad
Merge remote-tracking branch 'pastly/ticket20273'
2016-10-24 12:47:29 -04:00
Nick Mathewson
961c8f4838
Module-document dnsserv.c, policies.c, routerkeys.c
2016-10-24 11:47:40 -04:00
Nick Mathewson
e3592cd8b5
html error in doxygen comment in rendservice.c
2016-10-24 10:31:16 -04:00
Nick Mathewson
3a232ef64a
Module documentation for config.c and confparse.c
2016-10-24 10:16:46 -04:00
Nick Mathewson
5382b174c5
Module documentation (and an important caveat) for dirvote.c
2016-10-24 09:21:54 -04:00
Nick Mathewson
d1bcba19a9
Turn scheduler.c documentation into doxygen.
2016-10-20 11:02:04 -04:00
Ivan Markin
e77033e9ee
Say 'Invalid argument' instead of unclear 'Unrecognized'
2016-10-19 18:06:04 -04:00
Nick Mathewson
c87d9b13a4
BUG in purpose_needs_anonymity if switch not matched.
...
I believe that this should never trigger, but if it does, it
suggests that there was a gap between is_sensitive_dir_purpose and
purpose_needs_anonymity that we need to fill. Related to 20077.
2016-10-19 18:04:47 -04:00
Nick Mathewson
df387b94e8
Merge remote-tracking branch 'chelseakomlo/master'
2016-10-19 17:17:12 -04:00
Nick Mathewson
12cf73c451
Merge remote-tracking branch 'andrea/ticket19858_v2'
...
Conflict in entrynodes.c: any_bridge_supports_microdescriptors was
removed in master, and modified in 19858_v2
2016-10-19 17:11:47 -04:00
Nick Mathewson
ec4142abdf
Unify code in channel_write_*cell()
...
Patch from pingl; patch for 13827.
2016-10-19 17:07:23 -04:00
Nick Mathewson
87e4b9259a
Merge remote-tracking branch 'arma/bug6769'
2016-10-19 17:04:44 -04:00
Chelsea H. Komlo
471b0c5175
Refactor purpose_needs_anonymity to use switch statement
2016-10-19 12:25:50 -05:00
Chelsea H. Komlo
195ccce94e
Refactor to use purpose_needs_anonymity and remove is_sensitive_dir_purpose
2016-10-18 18:40:50 -05:00
Nick Mathewson
54fda6b98a
Module-level docs for ext_orport and router.c
2016-10-18 19:32:49 -04:00
Nick Mathewson
4396540129
Turn replaycache.c module doc into doxygen
2016-10-18 12:31:50 -04:00
Nick Mathewson
d1b45786b1
Document connection_or.c and connection.c at module level
2016-10-18 12:25:55 -04:00
Nick Mathewson
84829e336c
Module documentation for circuitmux_ewma.c
2016-10-18 11:28:40 -04:00
Nick Mathewson
56933787d5
Turn circuitmux.c comments into module docs.
2016-10-18 11:17:34 -04:00
Nick Mathewson
35df48b189
Module docs for channel.c and channeltls.c
2016-10-18 10:53:12 -04:00
Nick Mathewson
66ecdcdd75
Update the buffer sentinel fix to work with our #20081 fix.
2016-10-17 14:52:44 -04:00