Isis Lovecruft
c59ba01550
rephist: Remove unused crypto_pk statistics.
...
These statistics were largely ununsed, and kept track of statistical information
on things like how many time we had done TLS or how many signatures we had
verified. This information is largely not useful, and would only be logged
after receiving a SIGUSR1 signal (but only if the logging severity level was
less than LOG_INFO).
* FIXES #19871 .
* REMOVES note_crypto_pk_op(), dump_pk_op(), and pk_op_counts from
src/or/rephist.c.
* REMOVES every external call to these functions.
2017-07-13 20:24:48 +00:00
Roger Dingledine
0fe7c42e0e
general formatting / whitespace / typo fixes
2017-07-01 17:56:06 -04:00
Nick Mathewson
ee3ccd2fac
#22211 Fix a comment in routerparse.c
2017-05-10 11:16:07 -04:00
Nick Mathewson
e1d31f2a2f
Update the consdiff directory code based on #22143 fixes
...
These are mostly just identifier renames, except for one place in
routerparse.c where we switch to using a correct hash.
2017-05-04 08:49:02 -04:00
Nick Mathewson
112286338b
Store the sha3 of a networkstatus as part of the networkstatus_t
...
Also store it in the cached_dir_t.
2017-05-04 08:37:41 -04:00
Nick Mathewson
5acddbbbf7
bug#22143/prop#140: identify input diffs by their digest-as-signed
...
See may 3 changes to prop140 for more background.
2017-05-03 13:09:08 -04:00
David Goulet
dff50001ec
prop224: Flag router with HSIntro/HSDir using protover
...
Note down in the routerstatus_t of a node if the router supports the HSIntro=4
version for the ed25519 authentication key and HSDir=2 version for the v3
descriptor supports.
Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-04-07 09:44:52 -04:00
Nick Mathewson
7505f452c8
Run the copyright update script.
2017-03-15 16:13:17 -04:00
Nick Mathewson
5203cd2f11
Check for NULL as input to extrainfo_parse_entry_from_string()
...
We hope this will make the clangalyzer less worried about this function.
Closes ticket 21496.
2017-03-06 11:31:11 -05:00
Nick Mathewson
ef610467fa
Merge remote-tracking branch 'teor/bug21507-029'
2017-02-28 11:19:24 -05:00
teor
57154e71aa
Reject Tor versions that contain non-numeric prefixes
...
strto* and _atoi64 accept +, -, and various whitespace before numeric
characters. And permitted whitespace is different between POSIX and Windows.
Fixes bug 21507 and part of 21508; bugfix on 0.0.8pre1.
2017-02-19 22:38:06 +11:00
Nick Mathewson
5dbbd6bc39
Merge branch 'maint-0.2.9' into maint-0.3.0
2017-02-17 11:32:45 -05:00
Nick Mathewson
67cec7578c
Check for micro < 0, rather than checking "minor" twice.
...
Bug found with clang scan-build. Fixes bug on f63e06d3dc
.
Bug not present in any released Tor.
2017-02-17 11:31:39 -05:00
Nick Mathewson
d633c4757c
Merge branch 'maint-0.2.9'
2017-02-15 08:19:51 -05:00
Nick Mathewson
fea93abecd
whoops; make 21450 compile
2017-02-15 08:19:37 -05:00
Nick Mathewson
62f98ad485
Merge branch 'maint-0.2.9'
2017-02-15 07:58:15 -05:00
Nick Mathewson
cb6b3b7cad
Limit version numbers to 0...INT32_MAX.
...
Closes 21450; patch from teor.
2017-02-15 07:57:34 -05:00
Nick Mathewson
76d79d597a
Merge branch 'maint-0.2.9'
2017-02-15 07:48:42 -05:00
Nick Mathewson
ec6b5a098d
Merge branch 'bug21278_redux_029_squashed' into maint-0.2.9
2017-02-15 07:48:18 -05:00
Nick Mathewson
eeb743588a
Merge branch 'maint-0.2.8' into maint-0.2.9
2017-02-15 07:48:10 -05:00
Nick Mathewson
1ebdae6171
Merge branch 'maint-0.2.7' into maint-0.2.8
2017-02-15 07:47:28 -05:00
Nick Mathewson
ed806843dc
Merge branch 'maint-0.2.6' into maint-0.2.7
2017-02-15 07:47:21 -05:00
Nick Mathewson
3781f24b80
Merge branch 'maint-0.2.5' into maint-0.2.6
2017-02-15 07:47:12 -05:00
Nick Mathewson
a452b71395
Merge branch 'maint-0.2.4' into maint-0.2.5
2017-02-15 07:47:04 -05:00
Roger Dingledine
3c4da8a130
give tor_version_parse_platform some function documentation
2017-02-15 07:46:34 -05:00
Nick Mathewson
f63e06d3dc
Extract the part of tor_version_as_new_as that extracts platform
...
Also add a "strict" mode to reject negative inputs.
2017-02-15 07:46:34 -05:00
Nick Mathewson
194e31057f
Avoid integer underflow in tor_version_compare.
...
Fix for TROVE-2017-001 and bug 21278.
(Note: Instead of handling signed ints "correctly", we keep the old
behavior, except for the part where we would crash with -ftrapv.)
2017-02-14 16:10:27 -05:00
Nick Mathewson
143235873b
Memory leak on bogus ed key in microdesc
2017-01-30 08:37:26 -05:00
Nick Mathewson
a092bcdd4f
Fix a memory leak found while fuzzing
2017-01-30 08:37:26 -05:00
Nick Mathewson
b1567cf500
Three more fuzzers: consensus, hsdesc, intro points
2017-01-30 08:37:24 -05:00
Nick Mathewson
e2aeaeb76c
Make a bunch of signature/digest-checking functions mockable
2017-01-30 08:37:22 -05:00
Nick Mathewson
a9c8a5ff18
Merge branch 'maint-0.2.6' into maint-0.2.7
2016-12-20 18:14:21 -05:00
Nick Mathewson
b18bde23cf
Merge branch 'maint-0.2.5' into maint-0.2.6
2016-12-20 18:11:25 -05:00
Nick Mathewson
db58d4d16f
Merge branch 'maint-0.2.4' into maint-0.2.5
2016-12-20 18:11:08 -05:00
Nick Mathewson
f9f1e3c94b
Merge branch 'maint-0.2.9'
2016-12-19 08:03:17 -05:00
Nick Mathewson
de65647461
Merge branch 'maint-0.2.8' into maint-0.2.9
2016-12-19 07:58:43 -05:00
Nick Mathewson
c11de4c45f
Merge branch 'bug21018_024' into maint-0.2.8
2016-12-19 07:58:21 -05:00
Nick Mathewson
d978216dea
Fix parsing bug with unecognized token at EOS
...
In get_token(), we could read one byte past the end of the
region. This is only a big problem in the case where the region
itself is (a) potentially hostile, and (b) not explicitly
nul-terminated.
This patch fixes the underlying bug, and also makes sure that the
one remaining case of not-NUL-terminated potentially hostile data
gets NUL-terminated.
Fix for bug 21018, TROVE-2016-12-002, and CVE-2016-1254
2016-12-18 20:17:24 -05:00
Nick Mathewson
2cee38f76a
Merge branch 'prop271_030_v1_squashed'
2016-12-16 11:20:59 -05:00
Nick Mathewson
56b11905e5
Remove a little dead code from routerparse.c
...
In c35fad2bde
, merged in
0.2.4.7-alpha, we removed the code to parse v1 directory
objects. When we did so, we removed everything that could set the
CST_CHECK_AUTHORITY flag for check_signature_token().
So in this code, we remove the flag itself, the code to handle the
flag, and a function that only existed to handle the flag.
2016-12-13 09:36:59 -05:00
Nick Mathewson
41adfd6fa3
Fix a couple more crypto_digest() calls to be explicit < 0
2016-12-05 10:31:31 -05:00
Nick Mathewson
539eba0a4b
Teach parse_iso_time about the spaceless variant.
...
(We previously added support for generating the spaceless
2016-11-14T19:58:12 variant, but not for actually parsing it.)
2016-11-30 14:42:52 -05:00
Chelsea H. Komlo
9d9110f65d
crypto_digest256 returns expected error value of -1
2016-11-24 12:13:07 -05:00
Chelsea H. Komlo
276d07a88a
crypto_digest returns expected error value of -1
2016-11-24 10:01:03 -05:00
Nick Mathewson
b6164e1604
Merge remote-tracking branch 'public/feature20552'
2016-11-10 09:25:11 -05:00
Nick Mathewson
c58592e658
Merge branch 'maint-0.2.9'
2016-11-08 18:51:19 -05:00
Nick Mathewson
c35c43d7d9
Merge branch 'ticket17238_029_02-resquash'
...
Conflicts:
src/or/rendclient.c
src/or/rendcommon.c
src/or/routerparse.c
src/test/test_dir.c
src/trunnel/ed25519_cert.h
2016-11-04 13:26:37 -04:00
David Goulet
e8c12175fe
Move token parsing code to parsecommon.{c|h}
...
Signed-off-by: David Goulet <dgoulet@torproject.org>
Signed-off-by: George Kadianakis <desnacked@riseup.net>
2016-11-04 10:29:26 -04:00
Nick Mathewson
b7a1e793e6
Declare a LINKAUTH subprotocol version for #15055 (ed link handshake)
...
Closes ticket 20552.
2016-11-03 10:01:40 -04:00
Nick Mathewson
d9ca4e20bd
Merge branch 'feature_15055_v2'
2016-11-03 08:44:46 -04:00