Matt Traudt
c09993fdf6
Fix ewma_cmp_cmux never considering policies different
2016-10-25 10:07:05 -04:00
Nick Mathewson
01482e30ad
Merge remote-tracking branch 'pastly/ticket20273'
2016-10-24 12:47:29 -04:00
Nick Mathewson
961c8f4838
Module-document dnsserv.c, policies.c, routerkeys.c
2016-10-24 11:47:40 -04:00
Nick Mathewson
e3592cd8b5
html error in doxygen comment in rendservice.c
2016-10-24 10:31:16 -04:00
Nick Mathewson
3a232ef64a
Module documentation for config.c and confparse.c
2016-10-24 10:16:46 -04:00
Nick Mathewson
5382b174c5
Module documentation (and an important caveat) for dirvote.c
2016-10-24 09:21:54 -04:00
Nick Mathewson
d1bcba19a9
Turn scheduler.c documentation into doxygen.
2016-10-20 11:02:04 -04:00
Ivan Markin
e77033e9ee
Say 'Invalid argument' instead of unclear 'Unrecognized'
2016-10-19 18:06:04 -04:00
Nick Mathewson
c87d9b13a4
BUG in purpose_needs_anonymity if switch not matched.
...
I believe that this should never trigger, but if it does, it
suggests that there was a gap between is_sensitive_dir_purpose and
purpose_needs_anonymity that we need to fill. Related to 20077.
2016-10-19 18:04:47 -04:00
Nick Mathewson
df387b94e8
Merge remote-tracking branch 'chelseakomlo/master'
2016-10-19 17:17:12 -04:00
Nick Mathewson
9f6bb29b05
Compilation fix. (function pointer implicit cast in tests.)
2016-10-19 17:15:42 -04:00
Nick Mathewson
12cf73c451
Merge remote-tracking branch 'andrea/ticket19858_v2'
...
Conflict in entrynodes.c: any_bridge_supports_microdescriptors was
removed in master, and modified in 19858_v2
2016-10-19 17:11:47 -04:00
Nick Mathewson
ec4142abdf
Unify code in channel_write_*cell()
...
Patch from pingl; patch for 13827.
2016-10-19 17:07:23 -04:00
Nick Mathewson
87e4b9259a
Merge remote-tracking branch 'arma/bug6769'
2016-10-19 17:04:44 -04:00
Nick Mathewson
e12560db76
Bump version on master to 0.3.0.0-alpha-dev.
2016-10-19 17:03:22 -04:00
Chelsea H. Komlo
471b0c5175
Refactor purpose_needs_anonymity to use switch statement
2016-10-19 12:25:50 -05:00
Chelsea H. Komlo
195ccce94e
Refactor to use purpose_needs_anonymity and remove is_sensitive_dir_purpose
2016-10-18 18:40:50 -05:00
Nick Mathewson
54fda6b98a
Module-level docs for ext_orport and router.c
2016-10-18 19:32:49 -04:00
Nick Mathewson
4396540129
Turn replaycache.c module doc into doxygen
2016-10-18 12:31:50 -04:00
Nick Mathewson
d1b45786b1
Document connection_or.c and connection.c at module level
2016-10-18 12:25:55 -04:00
Nick Mathewson
84829e336c
Module documentation for circuitmux_ewma.c
2016-10-18 11:28:40 -04:00
Nick Mathewson
56933787d5
Turn circuitmux.c comments into module docs.
2016-10-18 11:17:34 -04:00
Nick Mathewson
35df48b189
Module docs for channel.c and channeltls.c
2016-10-18 10:53:12 -04:00
Nick Mathewson
b0f1241a1d
Bump to 0.2.8.9-dev
2016-10-17 16:32:11 -04:00
Nick Mathewson
702c1dcf7b
Bump master to 0.2.9.4-alpha-dev
2016-10-17 16:31:40 -04:00
Nick Mathewson
0fa3811c78
bump to 0.2.8.9
2016-10-17 14:57:26 -04:00
Nick Mathewson
66ecdcdd75
Update the buffer sentinel fix to work with our #20081 fix.
2016-10-17 14:52:44 -04:00
Nick Mathewson
1a74881063
Merge branch 'maint-0.2.8'
2016-10-17 14:51:45 -04:00
Nick Mathewson
1df114330e
Merge branch 'buf_sentinel_026_v2' into maint-0.2.8
2016-10-17 14:51:06 -04:00
Nick Mathewson
3cea86eb2f
Add a one-word sentinel value of 0x0 at the end of each buf_t chunk
...
This helps protect against bugs where any part of a buf_t's memory
is passed to a function that expects a NUL-terminated input.
It also closes TROVE-2016-10-001 (aka bug 20384).
2016-10-17 14:49:54 -04:00
Nick Mathewson
edcad379cf
Bump version to 0.2.9.4-alpha.
2016-10-17 14:05:42 -04:00
Nick Mathewson
f3174428e2
Fix a syntax problem
2016-10-17 10:25:13 -04:00
Nick Mathewson
fd9a1045d8
Merge branch 'module_docs_1'
2016-10-17 10:17:32 -04:00
Nick Mathewson
aae034d13e
Write a bunch of module documentation.
...
This commit adds or improves the module-level documenation for:
buffers.c circuitstats.c command.c connection_edge.c control.c
cpuworker.c crypto_curve25519.c crypto_curve25519.h
crypto_ed25519.c crypto_format.c dircollate.c dirserv.c dns.c
dns_structs.h fp_pair.c geoip.c hibernate.c keypin.c ntmain.c
onion.c onion_fast.c onion_ntor.c onion_tap.c periodic.c
protover.c protover.h reasons.c rephist.c replaycache.c
routerlist.c routerparse.c routerset.c statefile.c status.c
tor_main.c workqueue.c
In particular, I've tried to explain (for each documented module)
what each module does, what's in it, what the big idea is, why it
belongs in Tor, and who calls it. In a few cases, I've added TODO
notes about refactoring opportunities.
I've also renamed an argument, and fixed a few DOCDOC comments.
2016-10-17 10:16:59 -04:00
Nick Mathewson
df84536ac1
Add a logic-consistency test when parsing unix socket configs
...
Coverity couldn't tell that 'addrport' was always non-NULL at this
point in the function, so I'm adding an explicit check. This closes
CID 1374060.
2016-10-17 08:27:10 -04:00
Nick Mathewson
55c468c521
Whitespace cleaning
2016-10-14 10:40:31 -04:00
Nick Mathewson
ac707ae70a
Merge branch 'bug20176_v2'
2016-10-14 10:23:24 -04:00
Nick Mathewson
af70e43131
Merge remote-tracking branch 'public/spaces_in_unix_addrs'
2016-10-14 10:21:41 -04:00
Nick Mathewson
9615ad338f
Make the FreeBSD ersatz_socketpair test even more skippable.
...
(This is safe, since only windows actually -uses- erstaz_socketpair.)
2016-10-14 09:14:07 -04:00
Nick Mathewson
d2ab58c48d
Merge branch 'bug18357_v2'
2016-10-14 09:10:34 -04:00
Nick Mathewson
87865c8aca
Extract ExitPolicy-and-IPv6Exit check into a new function
...
(I've done this instead of changing the semantics of
router_compare_to_my_exit_policy, because dns.c uses
router_compare_to_my_exit_policy too, in a slightly weird way.)
2016-10-14 09:08:52 -04:00
Andrea Shepard
1c6f8841f4
Refactor to always allocate chosen_entry_guards in new guard_selection_new() function
2016-10-14 00:15:30 +00:00
Andrea Shepard
3b8a40f262
Use tor_memeq() instead of tor_memcmp() per code review
2016-10-13 23:48:49 +00:00
Andrea Shepard
fca605e763
Adjust comment per code review
2016-10-13 23:47:08 +00:00
Nick Mathewson
07f2e5748e
ersatz socketpair tests: work around freebsd jails.
2016-10-13 09:47:28 -04:00
Nick Mathewson
49d7feb8a0
Tweak patch for 18529.
...
- function doesn't need to be inline.
- rename function
- Make documentation more pedantically correct
- Remove needless "? 1 : 0."
2016-10-13 09:19:51 -04:00
Nick Mathewson
1fc3e29108
Remove duplicate code that checks for default authorities
...
Patch from ericho.
Fixes 18529. Simple refactoring.
2016-10-13 09:19:37 -04:00
Nick Mathewson
0e1b228aa6
Fix a bug in displaying IPv6 addrs in test_op_ipv6_ with --verbose
...
The test code, if it failed, or if it was run in verbose mode, would
use the wrong variable for its loop. Patch from rubiate uploaded to
19999.
2016-10-11 20:09:24 -04:00
Nick Mathewson
2e7e635c59
Switch from "AF_UNIX is always equal" to "always unequal" to avoid wacky bugs. See discussion on 20261
2016-10-11 11:11:21 -04:00
Nick Mathewson
d25fed5174
Merge remote-tracking branch 'yawning-schwanenlied/bug20261'
2016-10-11 11:08:20 -04:00