mirrors/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2025-02-25 07:07:52 +01:00
Code Issues Projects Releases Wiki Activity

dirauth: Remove some outdated config comments

Browse source 
Part of 32213.
This commit is contained in:
teor 2019-10-29 00:34:33 +10:00
parent 3881ac2c86
commit f70633d72d
1 changed files with 2 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
src/feature/dirauth/dirauth_config.c
View file

@ -142,26 +142,8 @@ options_validate_dirauth_schedule(const or_options_t *old_options,
if (options->V3AuthVoteDelay + options->V3AuthDistDelay >= if (options->V3AuthVoteDelay + options->V3AuthDistDelay >=
options->V3AuthVotingInterval/2) { options->V3AuthVotingInterval/2) {
/* REJECT("V3AuthVoteDelay plus V3AuthDistDelay must be less than half "
This doesn't work, but it seems like it should: "V3AuthVotingInterval");
what code is preventing the interval being less than twice the lead-up?
if (options->TestingTorNetwork) {
if (options->V3AuthVoteDelay + options->V3AuthDistDelay >=
options->V3AuthVotingInterval) {
REJECT("V3AuthVoteDelay plus V3AuthDistDelay must be less than "
"V3AuthVotingInterval");
} else {
COMPLAIN("V3AuthVoteDelay plus V3AuthDistDelay is more than half "
"V3AuthVotingInterval. This may lead to "
"consensus instability, particularly if clocks drift.");
}
} else {
*/
REJECT("V3AuthVoteDelay plus V3AuthDistDelay must be less than half "
"V3AuthVotingInterval");
/*
}
*/
} }
if (options->V3AuthVoteDelay < MIN_VOTE_SECONDS) { if (options->V3AuthVoteDelay < MIN_VOTE_SECONDS) {