mirrors/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2025-02-24 14:51:11 +01:00
Code Issues Projects Releases Wiki Activity

Remove XXXX009 comment telling us to do the last (circID-related) fix

Browse source 
svn:r2798
This commit is contained in:
Nick Mathewson 2004-11-10 20:19:45 +00:00
parent 954570486f
commit e69d9647ed
1 changed files with 0 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/or/circuitbuild.c
View file

@ -350,15 +350,6 @@ circuit_deliver_create_cell(circuit_t *circ, char *payload) {
tor_assert(circ->n_conn->type == CONN_TYPE_OR);
tor_assert(payload);
/* XXXX009 How can we keep a good upgrade path here? We should
* compare keys, not nicknames...but older servers will compare nicknames.
* Should we check server version from the most recent directory? Hm.
*
* This is important if anybody is unverified.
*
* Solution: switch to identity-based comparison, but if we get
* any circuits in the wrong half of the space, switch.
*/
circ->n_circ_id = get_unique_circ_id_by_conn(circ->n_conn);
if(!circ->n_circ_id) {
log_fn(LOG_WARN,"failed to get unique circID.");