mirrors/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2025-02-24 14:51:11 +01:00
Code Issues Projects Releases Wiki Activity

cc: Fix memleak when building extension response

Browse source 
Fixes #40575

Signed-off-by: David Goulet <dgoulet@torproject.org>
This commit is contained in:
David Goulet 2022-02-23 13:22:59 -05:00
parent 69f1a7aa59
commit d09e58d9bf
1 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/core/or/congestion_control_common.c
View file

@ -1303,6 +1303,7 @@ congestion_control_build_ext_response(const circuit_params_t *our_params,
ret = trn_extension_field_cc_encoded_len(cc_field);
if (BUG(ret <= 0)) {
trn_extension_field_free(field);
goto err;
}
size_t field_len = ret;
@ -1313,6 +1314,7 @@ congestion_control_build_ext_response(const circuit_params_t *our_params,
ret = trn_extension_field_cc_encode(field_array,
trn_extension_field_getlen_field(field), cc_field);
if (BUG(ret <= 0)) {
trn_extension_field_free(field);
goto err;
}
@ -1340,11 +1342,7 @@ congestion_control_build_ext_response(const circuit_params_t *our_params,
ret = 0;
err:
if (ext) {
trn_extension_free(ext);
} else {
trn_extension_field_free(field);
}
trn_extension_free(ext);
trn_extension_field_cc_free(cc_field);
return (int)ret;
}