mirrors/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-20 10:12:15 +01:00
Code Issues Projects Releases Wiki Activity

should_disable_dir_fetches() now returns 1 if DisableNetwork==1

Browse Source 
This change prevents LD_BUG warnings and bootstrap failure messages
when we try to do directory fetches when starting with
DisableNetwork == 1, a consensus present, but no descriptors (or
insufficient descriptors) yet.

Fixes bug 11200 and bug 10405.  It's a bugfix on 0.2.3.9-alpha.
Thanks to mcs for walking me through the repro instructions!
This commit is contained in:
Nick Mathewson 2014-03-14 10:42:49 -04:00
parent 102bb1c04f
commit d01cf18ecb
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
changes/bug11200 Normal file
View File

@ -0,0 +1,5 @@
- Minor bugfixes:
- Avoid generating spurious warnings and failure messages when
starting with DisableNetwork enabled. Fixes bug 11200 and bug
10405; bugfix on 0.2.3.9-alpha.

8
src/or/networkstatus.c
View File

@ -898,6 +898,14 @@ should_delay_dir_fetches(const or_options_t *options, const char **msg_out)
*msg_out = NULL;
}
if (options->DisableNetwork) {
if (msg_out) {
*msg_out = "DisableNetwork is set.";
}
log_info(LD_DIR, "Delaying dir fetches (DisableNetwork is set)");
return 1;
}
if (options->UseBridges) {
if (!any_bridge_descriptors_known()) {
if (msg_out) {