Merge remote-tracking branch 'public/bug11233_diagnose'

This commit is contained in:
Nick Mathewson 2014-05-01 12:37:16 -04:00
commit c472ac4fb8
2 changed files with 6 additions and 1 deletions

4
changes/bug11233 Normal file
View file

@ -0,0 +1,4 @@
o Minor features:
- When we encounter an unexpected CR in text that we're trying to
write to a file on Windows, log the name of the file. Should help
diagnosing bug 11233.

View file

@ -2004,7 +2004,8 @@ write_str_to_file(const char *fname, const char *str, int bin)
#ifdef _WIN32
if (!bin && strchr(str, '\r')) {
log_warn(LD_BUG,
"We're writing a text string that already contains a CR.");
"We're writing a text string that already contains a CR to %s",
escaped(fname));
}
#endif
return write_bytes_to_file(fname, str, strlen(str), bin);