Merge remote-tracking branch 'tor-gitlab/mr/154' into maint-0.4.4

This commit is contained in:
George Kadianakis 2020-10-07 13:32:17 +03:00
commit a914ac5d7c
3 changed files with 11 additions and 0 deletions

4
changes/bug40129 Normal file
View file

@ -0,0 +1,4 @@
o Minor bugfixes (compilation):
- Fix compiler warnings that would occur when building with
"--enable-all-bugs-are-fatal" and "--disable-module-relay"
at the same time. Fixes bug 40129; bugfix on 0.4.4.1-alpha.

View file

@ -14,6 +14,7 @@
#include "feature/dircache/dirserv.h" #include "feature/dircache/dirserv.h"
#include "feature/dircommon/dir_connection_st.h" #include "feature/dircommon/dir_connection_st.h"
DISABLE_GCC_WARNING("-Wmissing-noreturn")
int int
directory_handle_command(dir_connection_t *conn) directory_handle_command(dir_connection_t *conn)
{ {
@ -29,6 +30,7 @@ connection_dirserv_flushed_some(dir_connection_t *conn)
tor_assert_nonfatal_unreached_once(); tor_assert_nonfatal_unreached_once();
return -1; return -1;
} }
ENABLE_GCC_WARNING("-Wmissing-noreturn")
void void
dir_conn_clear_spool(dir_connection_t *conn) dir_conn_clear_spool(dir_connection_t *conn)

View file

@ -2488,6 +2488,10 @@ check_descriptor_bandwidth_changed(time_t now)
} }
} }
// This function can be "noreturn" if relay mode is disabled and
// ALL_BUGS_ARE_FATAL is set.
DISABLE_GCC_WARNING("-Wmissing-noreturn")
/** Note at log level severity that our best guess of address has changed from /** Note at log level severity that our best guess of address has changed from
* <b>prev</b> to <b>cur</b>. */ * <b>prev</b> to <b>cur</b>. */
void void
@ -2517,6 +2521,7 @@ log_addr_has_changed(int severity,
"Guessed our IP address as %s (source: %s).", "Guessed our IP address as %s (source: %s).",
addrbuf_cur, source); addrbuf_cur, source);
} }
ENABLE_GCC_WARNING("-Wmissing-noreturn")
/** Check whether our own address as defined by the Address configuration /** Check whether our own address as defined by the Address configuration
* has changed. This is for routers that get their address from a service * has changed. This is for routers that get their address from a service