Add spaces between the "and" when logging the "Your server has not managed to confirm reachability for its" on dual-stack relays

This commit is contained in:
Neel Chauhan 2021-08-26 13:38:48 -07:00
parent 29ec66fb39
commit 8ead53330c
2 changed files with 5 additions and 1 deletions

4
changes/bug40453 Normal file
View file

@ -0,0 +1,4 @@
o Minor bugfixes (logging, relay):
- Add spaces between the "and" when logging the "Your server has
not managed to confirm reachability for its" on dual-stack relays
Fixes bug 40453; bugfix on 0.4.5.1-alpha. Patch by Neel Chauhan.

View file

@ -219,7 +219,7 @@ reachability_warnings_callback(time_t now, const or_options_t *options)
tor_asprintf(&where4, "%s:%d", address4, me->ipv4_orport); tor_asprintf(&where4, "%s:%d", address4, me->ipv4_orport);
if (!v6_ok) if (!v6_ok)
tor_asprintf(&where6, "[%s]:%d", address6, me->ipv6_orport); tor_asprintf(&where6, "[%s]:%d", address6, me->ipv6_orport);
const char *opt_and = (!v4_ok && !v6_ok) ? "and" : ""; const char *opt_and = (!v4_ok && !v6_ok) ? " and " : "";
/* IPv4 reachability test worked but not the IPv6. We will _not_ /* IPv4 reachability test worked but not the IPv6. We will _not_
* publish the descriptor if our IPv6 was configured. We will if it * publish the descriptor if our IPv6 was configured. We will if it