From c61cd5775c137ef45f5449b9f996c05c63c21acf Mon Sep 17 00:00:00 2001 From: Nick Mathewson Date: Tue, 18 Dec 2018 08:09:43 -0500 Subject: [PATCH] Revert "Log bootstrap tag names" This reverts commit 1b855af5e33189d70d74273af03a535c343b63a5. --- changes/ticket28731 | 4 ---- src/feature/control/control.c | 6 +++--- 2 files changed, 3 insertions(+), 7 deletions(-) delete mode 100644 changes/ticket28731 diff --git a/changes/ticket28731 b/changes/ticket28731 deleted file mode 100644 index f8b116cc12..0000000000 --- a/changes/ticket28731 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor features (bootstrap): - - Add the bootstrap tag name to the log messages, so people - troubleshooting connection problems can look up a symbol instead - of a number. Closes ticket 28731. diff --git a/src/feature/control/control.c b/src/feature/control/control.c index 8208b80c23..795902e6f4 100644 --- a/src/feature/control/control.c +++ b/src/feature/control/control.c @@ -7153,7 +7153,7 @@ control_event_bootstrap_core(int loglevel, bootstrap_status_t status, status = progress; tor_log(loglevel, LD_CONTROL, - "Bootstrapped %d%% (%s): %s", status, tag, summary); + "Bootstrapped %d%%: %s", status, summary); tor_snprintf(buf, sizeof(buf), "BOOTSTRAP PROGRESS=%d TAG=%s SUMMARY=\"%s\"", status, tag, summary); @@ -7309,9 +7309,9 @@ control_event_bootstrap_problem(const char *warn, const char *reason, hostaddr = tor_strdup("?"); log_fn(severity, - LD_CONTROL, "Problem bootstrapping. Stuck at %d%% (%s): %s. (%s; %s; " + LD_CONTROL, "Problem bootstrapping. Stuck at %d%%: %s. (%s; %s; " "count %d; recommendation %s; host %s at %s)", - status, tag, summary, warn, reason, + status, summary, warn, reason, bootstrap_problems, recommendation, or_id, hostaddr);