mirrors/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2025-02-24 22:58:50 +01:00
Code Issues Projects Releases Wiki Activity

10365: Close connections if the VERSIONS cell has an odd length.

Browse source 
Fixes issue 10365.
This commit is contained in:
rl1987 2013-12-24 21:50:58 +02:00 • committed by Nick Mathewson
parent 8db8fda43f
commit 881c7c0f7d
2 changed files with 15 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
changes/bug10365 Normal file
View file

@ -0,0 +1,7 @@
o Minor bugfixes:
- When receving a VERSIONS cell with an odd number of bytes, close
the connection immediately. Fix for bug 10365; bugfix on
0.2.0.10-alpha. Spotted by "bobnomnom"; fix by "rl1987".

8
src/or/channeltls.c
View file

@ -1208,6 +1208,14 @@ channel_tls_process_versions_cell(var_cell_t *cell, channel_tls_t *chan)
tor_assert(chan); tor_assert(chan);
tor_assert(chan->conn); tor_assert(chan->conn);
if ((cell->payload_len % 2) == 1) {
log_fn(LOG_PROTOCOL_WARN, LD_OR,
"Received a VERSION cell with odd payload length %d; "
"closing connection.",cell->payload_len);
connection_or_close_for_error(chan->conn, 0);
return;
}
started_here = connection_or_nonopen_was_started_here(chan->conn); started_here = connection_or_nonopen_was_started_here(chan->conn);
if (chan->conn->link_proto != 0 || if (chan->conn->link_proto != 0 ||