mirrors/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2025-02-24 14:51:11 +01:00
Code Issues Projects Releases Wiki Activity

In updateFallbackDirs.py, say 'fallback list' instead of 'whitelist'

Browse source
This commit is contained in:
rl1987 2019-01-07 11:09:33 +02:00 • committed by Nick Mathewson
parent 41e3c760a4
commit 7fbe7a2563
2 changed files with 14 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
changes/bug24953 Normal file
View file

@ -0,0 +1,4 @@
o Minor bugfixes (fallback scripts):
- In updateFallbackDirs.py, call the filter file a "fallback list"
instead of a "whitelist" in check_existing mode.
Fixes bug 24953; bugfix on 0.3.0.3-alpha.

15
scripts/maint/updateFallbackDirs.py
View file

@ -1594,7 +1594,7 @@ class CandidateList(dict):
""" Apply the fallback whitelist_obj to this fallback list,
passing exact to is_in_whitelist(). """
excluded_count = 0
logging.debug('Applying whitelist')
logging.debug('Applying fallback list')
# parse the whitelist
whitelist = self.load_relaylist(whitelist_obj)
filtered_fallbacks = []
@ -1609,14 +1609,18 @@ class CandidateList(dict):
else:
# exclude
excluded_count += 1
log_excluded('Excluding %s: not in whitelist.',
log_excluded('Excluding %s: not in fallback list.',
f._fpr)
self.fallbacks = filtered_fallbacks
return excluded_count
@staticmethod
def summarise_filters(initial_count, excluded_count):
return '/* Whitelist excluded %d of %d candidates. */'%(
def summarise_filters(initial_count, excluded_count, check_existing):
list_type = 'Whitelist'
if check_existing:
list_type = 'Fallback list'
return '/* %s excluded %d of %d candidates. */'%(list_type,
excluded_count, initial_count)
# calculate each fallback's measured bandwidth based on the median
@ -2284,7 +2288,8 @@ def list_fallbacks(whitelist, exact=False):
# instead, there will be an info-level log during the eligibility check.
initial_count = len(candidates.fallbacks)
excluded_count = candidates.apply_filter_lists(whitelist, exact=exact)
print candidates.summarise_filters(initial_count, excluded_count)
print candidates.summarise_filters(initial_count, excluded_count,
whitelist['check_existing'])
eligible_count = len(candidates.fallbacks)
# calculate the measured bandwidth of each relay,