mirrors/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2025-02-25 23:21:38 +01:00
Code Issues Projects Releases Wiki Activity

test: Fix memory leak in hs_descriptor/decode_bad_signature

Browse source 
Fixes #23319

Cherry-picked from master; bug not in any released Tor.
This commit is contained in:
David Goulet 2017-08-24 16:21:44 -04:00 • committed by Nick Mathewson
parent 2d55620a9e
commit 7eaf055b28
3 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/or/hs_descriptor.c
View file

@ -167,7 +167,7 @@ desc_intro_point_free(hs_desc_intro_point_t *ip)
} }
/* Free the content of the plaintext section of a descriptor. */ /* Free the content of the plaintext section of a descriptor. */
static void STATIC void
desc_plaintext_data_free_contents(hs_desc_plaintext_data_t *desc) desc_plaintext_data_free_contents(hs_desc_plaintext_data_t *desc)
{ {
if (!desc) { if (!desc) {

2
src/or/hs_descriptor.h
View file

@ -235,6 +235,8 @@ STATIC int desc_sig_is_valid(const char *b64_sig,
STATIC void desc_intro_point_free(hs_desc_intro_point_t *ip); STATIC void desc_intro_point_free(hs_desc_intro_point_t *ip);
STATIC size_t decode_superencrypted(const char *message, size_t message_len, STATIC size_t decode_superencrypted(const char *message, size_t message_len,
uint8_t **encrypted_out); uint8_t **encrypted_out);
STATIC void desc_plaintext_data_free_contents(hs_desc_plaintext_data_t *desc);
#endif /* HS_DESCRIPTOR_PRIVATE */ #endif /* HS_DESCRIPTOR_PRIVATE */
#endif /* TOR_HS_DESCRIPTOR_H */ #endif /* TOR_HS_DESCRIPTOR_H */

3
src/test/test_hs_descriptor.c
View file

@ -574,7 +574,8 @@ test_decode_bad_signature(void *arg)
expect_log_msg_containing("Malformed signature line. Rejecting."); expect_log_msg_containing("Malformed signature line. Rejecting.");
teardown_capture_of_logs(); teardown_capture_of_logs();
done: ; done:
desc_plaintext_data_free_contents(&desc_plaintext);
} }
static void static void