Fix a crash bug when testing reachability

Fixes bug 25415; bugfix on 0.3.3.2-alpha.
This commit is contained in:
Nick Mathewson 2018-03-04 10:31:17 -05:00
parent e5a990fc5a
commit 699bb803ba
2 changed files with 6 additions and 1 deletions

4
changes/bug25415 Normal file
View File

@ -0,0 +1,4 @@
o Major bugfixes (directory authority):
- Avoid a crash when testing router reachability on a router that could
have an ed25519 ID, but which does not. Fixes bug 25415; bugfix on
0.3.3.2-alpha.

View File

@ -3392,7 +3392,8 @@ dirserv_single_reachability_test(time_t now, routerinfo_t *router)
tor_assert(node); tor_assert(node);
if (options->AuthDirTestEd25519LinkKeys && if (options->AuthDirTestEd25519LinkKeys &&
node_supports_ed25519_link_authentication(node, 1)) { node_supports_ed25519_link_authentication(node, 1) &&
router->cache_info.signing_key_cert) {
ed_id_key = &router->cache_info.signing_key_cert->signing_key; ed_id_key = &router->cache_info.signing_key_cert->signing_key;
} else { } else {
ed_id_key = NULL; ed_id_key = NULL;