mirrors/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2025-02-23 14:40:51 +01:00
Code Issues Projects Releases Wiki Activity

Don't use signed 1-bit bitfields

Browse source 
This was harmless, we never compared it to anything but itself or 0.
But Coverity complained, and it had a point.
This commit is contained in:
Sebastian Hahn 2011-06-08 21:27:32 +02:00
parent 9e56ac27da
commit 680646e0de
2 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
changes/coverity_maint
View file

@ -4,4 +4,5 @@
o Minor bugfixes: o Minor bugfixes:
- Add some forgotten return value checks during unit tests. Found - Add some forgotten return value checks during unit tests. Found
by coverity. by coverity.
- Don't use 1-bit wide signed bit fields. Found by coverity.

2
src/or/policies.c
View file

@ -45,7 +45,7 @@ typedef struct policy_summary_item_t {
uint16_t prt_max; /**< Highest port number to accept/reject. */ uint16_t prt_max; /**< Highest port number to accept/reject. */
uint64_t reject_count; /**< Number of IP-Addresses that are rejected to uint64_t reject_count; /**< Number of IP-Addresses that are rejected to
this port range. */ this port range. */
int accepted:1; /** Has this port already been accepted */ unsigned int accepted:1; /** Has this port already been accepted */
} policy_summary_item_t; } policy_summary_item_t;
/** Private networks. This list is used in two places, once to expand the /** Private networks. This list is used in two places, once to expand the