mirrors/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2025-02-25 15:10:48 +01:00
Code Issues Projects Releases Wiki Activity

Remove unused NULL check in hs_service_add_ephemeral(), mention we take ownership of auth_clients_v3

Browse source
This commit is contained in:
Neel Chauhan 2020-12-08 10:46:44 -08:00
parent 7d54734900
commit 65d60a16d9
1 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/feature/hs/hs_service.c
View file

@ -3700,9 +3700,10 @@ hs_service_upload_desc_to_dir(const char *encoded_desc,
/** Add the ephemeral service using the secret key sk and ports. Both max /** Add the ephemeral service using the secret key sk and ports. Both max
* streams parameter will be set in the newly created service. * streams parameter will be set in the newly created service.
* *
* Ownership of sk and ports is passed to this routine. Regardless of * Ownership of sk, ports, and auth_clients_v3 is passed to this routine.
* success/failure, callers should not touch these values after calling this * Regardless of success/failure, callers should not touch these values
* routine, and may assume that correct cleanup has been done on failure. * after calling this routine, and may assume that correct cleanup has
* been done on failure.
* *
* Return an appropriate hs_service_add_ephemeral_status_t. */ * Return an appropriate hs_service_add_ephemeral_status_t. */
hs_service_add_ephemeral_status_t hs_service_add_ephemeral_status_t
@ -3754,9 +3755,7 @@ hs_service_add_ephemeral(ed25519_secret_key_t *sk, smartlist_t *ports,
} }
if (auth_clients_v3) { if (auth_clients_v3) {
if (service->config.clients == NULL) { service->config.clients = auth_clients_v3;
service->config.clients = auth_clients_v3;
}
} }
/* Build the onion address for logging purposes but also the control port /* Build the onion address for logging purposes but also the control port