mirrors/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2025-02-25 07:07:52 +01:00
Code Issues Projects Releases Wiki Activity

relay: Emit log warning if Address is internal and can't be used

Browse source 
Signed-off-by: David Goulet <dgoulet@torproject.org>
This commit is contained in:
David Goulet 2021-03-25 10:15:50 -04:00 • committed by Nick Mathewson
parent 6c14f9076f
commit 6281c90885
2 changed files with 15 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
changes/ticket40290 Normal file
View file

@ -0,0 +1,3 @@
o Minor bugfix (logging, relay):
- Emit a warning if an Address is found to be internal and tor can't use it.
Fixes bug 40290; bugfix on 0.4.5.1-alpha.

12
src/app/config/resolve_addr.c
View file

@ -343,6 +343,18 @@ get_address_from_config(const or_options_t *options, int warn_severity,
* used, custom authorities must be defined else it is a fatal error. * used, custom authorities must be defined else it is a fatal error.
* Furthermore, if the Address was resolved to an internal interface, we * Furthermore, if the Address was resolved to an internal interface, we
* stop immediately. */ * stop immediately. */
if (ret == ERR_ADDRESS_IS_INTERNAL) {
static bool logged_once = false;
if (!logged_once) {
log_warn(LD_CONFIG, "Address set with an internal address. Tor will "
"not work unless custom directory authorities "
"are defined (AlternateDirAuthority). It is also "
"possible to use an internal address if "
"PublishServerDescriptor is set to 0 and "
"AssumeReachable(IPv6) to 1.");
logged_once = true;
}
}
tor_free(*hostname_out); tor_free(*hostname_out);
return FN_RET_BAIL; return FN_RET_BAIL;
} }