mirrors/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2025-02-24 06:48:05 +01:00
Code Issues Projects Releases Wiki Activity

Provide large enough buffer in test_util_sscanf()

Browse source 
This was causing crashes during unit test runs, as stack smashing
protections got triggered. Issue spotted by weasel
This commit is contained in:
Sebastian Hahn 2012-03-27 14:04:15 +02:00
parent 4121e7f861
commit 582f747049
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
changes/bug5449 Normal file
View file

@ -0,0 +1,6 @@
o Minor bugfixes:
- In the testsuite, provide a large enough buffer in the tor_sscanf
unit test. We'd otherwise overrun that buffer and crash during the
unit tests. Fixes bug 5449; bugfix on 0.2.3.12-alpha. Thanks weasel
for spotting the bug.

2
src/test/test_util.c
View file

@ -1376,7 +1376,7 @@ static void
test_util_sscanf(void)
{
unsigned u1, u2, u3;
char s1[10], s2[10], s3[10], ch;
char s1[20], s2[10], s3[10], ch;
int r;
/* Simple tests (malformed patterns, literal matching, ...) */