mirrors/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2025-02-24 14:51:11 +01:00
Code Issues Projects Releases Wiki Activity

Consider 301 as an error like 404

Browse source 
Tor does not follow redirects when bootstraping so we encountered an
error.

Fixes #40053
This commit is contained in:
Guinness 2020-10-17 12:12:05 +02:00 • committed by Nick Mathewson
parent bb249a221f
commit 5248d08ede
2 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
changes/ticket40053 Normal file
View file

@ -0,0 +1,5 @@
o Minor features (logging):
- Consider 301 as an error like a 404 when processing the response to a
request for a group of server descriptors or an extrainfo documents.
Closes ticket 40053.

7
src/feature/dirclient/dirclient.c
View file

@ -2505,9 +2505,12 @@ handle_response_fetch_desc(dir_connection_t *conn,
}
if (status_code != 200) {
int dir_okay = status_code == 404 ||
(status_code == 400 && !strcmp(reason, "Servers unavailable."));
(status_code == 400 && !strcmp(reason, "Servers unavailable.")) ||
status_code == 301;
/* 404 means that it didn't have them; no big deal.
* Older (pre-0.1.1.8) servers said 400 Servers unavailable instead. */
* Older (pre-0.1.1.8) servers said 400 Servers unavailable instead.
* 301 is considered as an error since Tor does not follow redirects,
* which means we failed to reach the server we wanted. */
log_fn(dir_okay ? LOG_INFO : LOG_WARN, LD_DIR,
"Received http status code %d (%s) from server %s "
"while fetching \"/tor/server/%s\". I'll try again soon.",