mirrors/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2025-02-24 22:58:50 +01:00
Code Issues Projects Releases Wiki Activity

Fix a rare memory leak in rend_cache_store

Browse source 
When we rejected a descriptor for not being the one we wanted, we
were letting the parsed descriptor go out of scope.

Found by Coverity; CID # 30.

Bugfix on 0.2.1.26.

(No changes file yet, since this is not in any 0.2.1.x release.)
This commit is contained in:
Nick Mathewson 2011-07-01 11:52:39 -04:00
parent 010b8dd4f6
commit 46297bc7bd
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/or/rendcommon.c
View file

@ -1077,6 +1077,7 @@ rend_cache_store(const char *desc, size_t desc_len, int published,
log_warn(LD_REND, "Received service descriptor for service ID %s; " log_warn(LD_REND, "Received service descriptor for service ID %s; "
"expected descriptor for service ID %s.", "expected descriptor for service ID %s.",
query, safe_str(service_id)); query, safe_str(service_id));
rend_service_descriptor_free(parsed);
return -2; return -2;
} }
now = time(NULL); now = time(NULL);