mirrors/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2025-02-23 14:40:51 +01:00
Code Issues Projects Releases Wiki Activity

(size_t)-1 is never < 0; fix an XXXX008 by changing the interface for dirserv_get_runningrouters

Browse source 
svn:r2165
This commit is contained in:
Nick Mathewson 2004-08-06 20:00:16 +00:00
parent fb3e15b668
commit 3ca2728eb2
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/or/directory.c
View file

@ -533,7 +533,7 @@ directory_handle_command_get(connection_t *conn, char *headers,
return 0;
}
dlen = dirserv_get_runningrouters(&cp);
if(dlen < 0) { /* we failed to create cp */
if(!dlen) { /* we failed to create cp */
connection_write_to_buf(answer503, strlen(answer503), conn);
return 0;
}

6
src/or/dirserv.c
View file

@ -741,14 +741,14 @@ static int generate_runningrouters(crypto_pk_env_t *private_key)
}
/** Set *<b>rr</b> to the most recently generated encoded signed
* running-routers list, generating a new one as necessary. */
* running-routers list, generating a new one as necessary. Return the
* size of the directory on success, and 0 on failure. */
size_t dirserv_get_runningrouters(const char **rr)
/* XXX008 Bug: size_t is unsigned, but we're returning -1 to mean error */
{
if (runningrouters_is_dirty) {
if(generate_runningrouters(get_identity_key())) {
log_fn(LOG_ERR, "Couldn't generate running-routers list?");
return -1;
return 0;
}
}
*rr = runningrouters_string;