sendme: Turn log warning into debug

When sending the stream level SENDME, it is possible the cirucit was marked
for close or any other failures that can occur. These events can occur
naturally.

Fixes #40142

Signed-off-by: David Goulet <dgoulet@torproject.org>
This commit is contained in:
David Goulet 2020-11-17 13:23:29 -05:00
parent 07006785fd
commit 16351d655d
2 changed files with 5 additions and 2 deletions

3
changes/ticket40142 Normal file
View file

@ -0,0 +1,3 @@
o Minor bugfixes (logging, flow control):
- Turn a SENDME failure log warning into a debug. It can actually happen
naturally. Fixes bug 40142; bugfix on 0.4.1.1-alpha.

View file

@ -398,8 +398,8 @@ sendme_connection_edge_consider_sending(edge_connection_t *conn)
conn->deliver_window += STREAMWINDOW_INCREMENT; conn->deliver_window += STREAMWINDOW_INCREMENT;
if (connection_edge_send_command(conn, RELAY_COMMAND_SENDME, if (connection_edge_send_command(conn, RELAY_COMMAND_SENDME,
NULL, 0) < 0) { NULL, 0) < 0) {
log_warn(LD_BUG, "connection_edge_send_command failed while sending " log_debug(LD_CIRC, "connection_edge_send_command failed while sending "
"a SENDME. Circuit probably closed, skipping."); "a SENDME. Circuit probably closed, skipping.");
goto end; /* The circuit's closed, don't continue */ goto end; /* The circuit's closed, don't continue */
} }
} }