mirrors/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2025-02-25 07:07:52 +01:00
Code Issues Projects Releases Wiki Activity

Remove a needless check in channel_tls_handle_incoming

Browse source 
This patch removes an "if (chan)" that occurred at a place where
chan was definitely non-NULL.  Having it there made some static
analysis tools conclude that we were up to shenanigans.

This resolves #9979.
This commit is contained in:
Nick Mathewson 2014-02-07 12:01:16 -05:00
parent ef4eb823f3
commit 040b478692
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/or/channeltls.c
View file

@ -287,8 +287,8 @@ channel_tls_handle_incoming(or_connection_t *orconn)
if (is_local_addr(&(TO_CONN(orconn)->addr))) channel_mark_local(chan); if (is_local_addr(&(TO_CONN(orconn)->addr))) channel_mark_local(chan);
channel_mark_incoming(chan); channel_mark_incoming(chan);
/* If we got one, we should register it */ /* Register it */
if (chan) channel_register(chan); channel_register(chan);
return chan; return chan;
} }