mirrors/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2025-02-24 14:51:11 +01:00
Code Issues Projects Releases Wiki Activity

Fix an (unreachable) memory leak in rendcache.c

Browse source 
The 0.2.8 unit tests provoke this leak, though I don't think it can
happen IRL.
This commit is contained in:
Nick Mathewson 2015-10-21 10:27:19 -04:00
parent 5b2070198a
commit 03eb999d42
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/or/rendcache.c
View file

@ -353,7 +353,7 @@ cache_failure_intro_add(const uint8_t *identity, const char *service_id,
rend_intro_point_failure_t failure)
{
rend_cache_failure_t *fail_entry;
rend_cache_failure_intro_t *entry;
rend_cache_failure_intro_t *entry, *old_entry;
/* Make sure we have a failure object for this service ID and if not,
* create it with this new intro failure entry. */
@ -364,7 +364,10 @@ cache_failure_intro_add(const uint8_t *identity, const char *service_id,
strmap_set_lc(rend_cache_failure, service_id, fail_entry);
}
entry = rend_cache_failure_intro_entry_new(failure);
digestmap_set(fail_entry->intro_failures, (char *) identity, entry);
old_entry = digestmap_set(fail_entry->intro_failures,
(char *) identity, entry);
/* This _should_ be NULL, but in case it isn't, free it. */
rend_cache_failure_intro_entry_free(old_entry);
}
/** Using a parsed descriptor <b>desc</b>, check if the introduction points