tor/changes/ticket18873

  o Code simplification and refactoring:
    - Refactor circuit_predict_and_launch_new for readability and
      testability. Closes ticket 18873.
    - Extract magic numbers in circuituse.c into defined variables.
    - Refactor circuit_is_available_for_use to remove unnecessary check.

  o Minor features (unit tests):
    - Extract dummy_origin_circuit_new so it can be used by other test
      functions.
    - Add unit tests circuit_predict_and_launch_new.
moving useful test helper to test_helpers.h 2016-10-16 06:40:37 -05:00			`o Code simplification and refactoring:`
Fix a few warnings from lintChanges 2016-12-12 08:31:05 -05:00			`- Refactor circuit_predict_and_launch_new for readability and`
			`testability. Closes ticket 18873.`
			`- Extract magic numbers in circuituse.c into defined variables.`
			`- Refactor circuit_is_available_for_use to remove unnecessary check.`

			`o Minor features (unit tests):`
			`- Extract dummy_origin_circuit_new so it can be used by other test`
moving useful test helper to test_helpers.h 2016-10-16 06:40:37 -05:00			`functions.`
Fix a few warnings from lintChanges 2016-12-12 08:31:05 -05:00			`- Add unit tests circuit_predict_and_launch_new.`