mirrors/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2025-02-25 07:07:52 +01:00
Code Issues Projects Releases Wiki Activity
tor/changes/ticket33804

8 lines
463 B
Text
Raw Normal View History

client: Revert setting PreferIPv6 on by default This change broke torsocks that by default is expecting an IPv4 for hostname resolution because it can't ask tor for a specific IP version with the SOCKS5 extension. PreferIPv6 made it that sometimes the IPv6 could be returned to torsocks that was expecting an IPv4. Torsocks is probably a very unique case because the runtime flow is that it hijacks DNS resolution (ex: getaddrinfo()), gets an IP and then sends it back for the connect() to happen. The libc has DNS resolution functions that allows the caller to request a specific INET family but torsocks can't tell tor to resolve the hostname only to an IPv4 or IPv6 and thus by default fallsback to IPv4. Reverting this change into 0.4.3.x series but we'll keep it in the 0.4.4.x series in the hope that we add this SOCKS5 extension to tor for DNS resolution and then change torsocks to use that. Fixes #33804 Signed-off-by: David Goulet <dgoulet@torproject.org>
2020-04-07 09:04:01 -04:00
o Minor bugfixes (client, SocksPort, IPv6):
- Revert PreferIPv6 set by default on the SocksPort because it brokes the
torsocks use case. Tor doesn't have a way for an application to request
the hostname to be resolved for a specific IP version but torsocks
requires that. Up until now, IPv4 was used by default so it is expecting
that, and can't handle a possible IPv6 being returned. Fixes bug 33804;
bugfix on 0.4.3.1-alpha.
Reference in a new issue Copy permalink