mirrors/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2025-02-24 22:58:50 +01:00
Code Issues Projects Releases Wiki Activity
tor/changes/bug32673

6 lines
315 B
Text
Raw Normal View History

buf_read_from_tls: Return ERROR_MISC, not WANTWRITE, on BUG(). Fixes bug 32673; bugfix on 0.3.0.4-alpha. We introduced these checks in ee5471f9aab5526 to help diagnose 21369, but we used "-1" when "TOR_TLS_ERROR_MISC" would have been correct. Found by opara. I don't think that this is actually getting triggered in the wild, but if it were, it could cause nasty behavior: spurious WANTREAD/WANTWRITE returns have a way of turning into CPU-eating busy-loops.
2020-01-29 08:49:01 -05:00
o Minor bugfixes (TLS bug handling):
- When encountering a bug in buf_read_freom_tls(), return a
"MISC" error code rather than "WANTWRITE". This change might
help avoid some CPU-wasting loops if the bug is ever triggered.
Bug reported by opara. Fixes bug 32673; bugfix on 0.3.0.4-alpha.
Reference in a new issue Copy permalink