rust-lightning/ci
Matt Corallo feffaf8bbc Return owned Strings for onion message message types
Returning a reference from a trait method is relatively difficult
to map in bindings and is currently handled by storing the object
in the trait instance, returning a reference to the local field.

This is fine when the object we're returning only needs to live as
long as the trait, but when it needs to be `'static` (as is the
case for onion message `msg_type`s), there's not really a good way
to map them at all.

Instead, here, condition on `#[cfg(c_bindings)]` we return a fully
owned `String`. This is obviously relatively less effecient, but
the extra allocation and `memcpy` isn't the end of the world,
especially given it should be released relatively quickly.

Note that this breaks doctests in with `c_bindings`.
2024-08-27 00:05:12 +00:00
..
check-compiles.sh Fix misc shellcheck complaints 2024-08-13 08:50:30 +02:00
check-each-commit.sh Fix misc shellcheck complaints 2024-08-13 08:50:30 +02:00
ci-tests.sh Return owned Strings for onion message message types 2024-08-27 00:05:12 +00:00
rustfmt.sh Fix misc shellcheck complaints 2024-08-13 08:50:30 +02:00