Matt Corallo f1b9bd34b8 Do not execute the default_value expr until we need it in TLV deser ... This fixes an insta-panic in `ChannelMonitor` deserialization where we always `unwrap` a previous value to determine the default value of a later field. However, because we always ran the `unwrap` before the previous field is read, we'd always panic. The fix is rather simple - use a `OptionDeserWrapper` for `default_value` fields and only fill in the default value if no value was read while walking the TLV stream. The only complexity comes from our desire to support `read_tlv_field` calls that use an explicit field rather than an `Option` of some sort, which requires some statement which can assign both an `OptionDeserWrapper<T>` variable and a `T` variable. We settle on `x = t.into()` and implement `From<T> for OptionDeserWrapper<T>` which works, though it requires users to specify types explicitly due to Rust determining expression types prior to macro execution, completely guessing with no knowlege for integer expressions (see https://github.com/rust-lang/rust/issues/91369).		2022-07-05 17:32:21 +00:00
..
src	Do not execute the default_value expr until we need it in TLV deser	2022-07-05 17:32:21 +00:00
Cargo.toml	Bump crate versions to 0.0.109/invoice 0.17	2022-07-01 16:05:33 +00:00