Matt Corallo 6f023f8f08 Req the counterparty node id when claiming against a closed chan ... Currently we store in-flight `ChannelMonitorUpdate`s in the per-peer structure in `ChannelManager`. This is nice and simple as we're generally updating it when we're updating other per-peer data, so we already have the relevant lock(s) and map entries. Sadly, when we're claiming an HTLC against a closed channel, we didn't have the `counterparty_node_id` available until it was added in 0.0.124 (and now we only have it for HTLCs which were forwarded in 0.0.124). This means we can't look up the per-peer structure when claiming old HTLCs, making it difficult to track the new `ChannelMonitorUpdate` as in-flight. While we could transition the in-flight `ChannelMonitorUpdate` tracking to a new global map indexed by `OutPoint`, doing so would result in a major lock which would be highly contended across channels with different peers. Instead, as we move towards tracking in-flight `ChannelMonitorUpdate`s for closed channels we'll keep our existing storage, leaving only the `counterparty_node_id` issue to contend with. Here we simply accept the issue, requiring that `counterparty_node_id` be available when claiming HTLCs against a closed channel. On startup, we explicitly check for any forwarded HTLCs which came from a closed channel where the forward happened prior to 0.0.124, failing to deserialize, or logging an warning if the channel is still open (implying things may work out, but panics may occur if the channel closes prior to HTLC resolution). While this is a somewhat dissapointing resolution, LDK nodes which forward HTLCs are generally fairly well-upgraded, so it is not anticipated to be an issue in practice.		2024-11-13 01:24:06 +00:00
..
.empty_folder	Update release notes for 0.0.111	2022-09-12 22:33:37 +00:00
3243-remove-balance_msat.txt	Remove AvailableBalances::balance_msat	2024-09-09 19:37:03 +02:00
3259-no-downgrade.txt	Add missing pending changelog for downgrade on unsafe funding	2024-08-27 19:31:25 +00:00
3322-a.txt	Pass info about claimed payments, incl HTLCs to ChannelMonitors	2024-10-24 17:44:33 +00:00
3322-b.txt	Stop relying on ChannelMonitor persistence after manager read	2024-10-24 17:44:33 +00:00
matt-no-upgrade-skip.txt	Req the counterparty node id when claiming against a closed chan	2024-11-13 01:24:06 +00:00
matt-persist-preimage-on-upgrade.txt	Doc the on-upgrade ChannelMonitor startup persistence semantics	2024-10-24 17:44:33 +00:00