mirror of
https://github.com/lightningdevkit/rust-lightning.git
synced 2025-02-25 15:20:24 +01:00
Previously, we were requiring any `UPDATE` onion errors to include a `channel_update`, as the spec mandates[1]. If we see an onion error which is missing one we treat it as a misbehaving node that isn't behaving according to the spec and simply remove the node. Sadly, it appears at least some versions of CLN are such nodes, and opt to not include `channel_update` at all if they're returning a `temporary_channel_failure`. This causes us to completely remove CLN nodes from our graph after they fail to forward our HTLC. While CLN is violating the spec here, there's not a lot of reason to not allow it, so we go ahead and do so here, treating it simply as any other failure by letting the scorer handle it. [1] The spec says `Please note that the channel_update field is mandatory in messages whose failure_code includes the UPDATE flag` however doesn't repeat it in the requirements section so its not crazy that someone missed it when implementing. |
||
---|---|---|
.. | ||
src | ||
Cargo.toml |