Commit graph

1732 commits

Author SHA1 Message Date
Matt Corallo
d0b4f521e1
Merge pull request #669 from joemphilips/fix_capacity-is-always-zero-bug_in_list_channels
Fix bug in Channel
2020-08-13 14:06:39 -07:00
Matt Corallo
7dca3a9e29
Merge pull request #668 from lightning-signer/nit
fix typo
2020-08-13 10:08:21 -07:00
joe.miyamoto
54916db957
Fix bug in Channel
Before this commit, `fn get_inbound_outbound_available_balance_msat` always returns 0.
It is because using `cmp::min` instead of `cmp::max` .
2020-08-13 17:10:24 +09:00
Devrandom
c3a90a2d56 fix typo 2020-08-13 09:58:55 +02:00
Matt Corallo
1d2d393258
Merge pull request #662 from lightning-signer/compat5
Export various fields and structures
2020-08-11 09:10:05 -07:00
Devrandom
fd2db4028a check the input shape in LocalCommitmentTransaction.new_missing_local_sig 2020-08-11 11:00:32 +02:00
Devrandom
f60026387e make LocalCommitmentTransaction constructor public
Allows calling of InMemoryChannelKeys methods
2020-08-11 09:23:31 +02:00
Devrandom
31b4d89cde make SimpleManyChannelMonitor.monitors public 2020-08-11 09:23:31 +02:00
Devrandom
ce0cecd50a export "unsafe_revoked_tx_signing" feature
Allows unsafe signing in dev code, such as functional testing of
justice transactions outside our crate.
2020-08-11 09:23:31 +02:00
Matt Corallo
22a0dd5f33
Merge pull request #666 from TheBlueMatt/2020-08-license-change
Relicense as dual Apache-2.0 + MIT
2020-08-10 18:30:38 -07:00
Matt Corallo
4395b92cc8 Relicense as dual Apache-2.0 + MIT
This changes the LICENSE file and adds license headers to most files
to relicense under dual Apache-2.0 and MIT. This is helpful in that
we retain the patent grant issued under Apache-2.0-licensed work,
avoiding some sticky patent issues, while still allowing users who
are more comfortable with the simpler MIT license to use that.

See https://github.com/rust-bitcoin/rust-lightning/issues/659 for
relicensing statements from code authors.
2020-08-10 21:12:44 -04:00
Matt Corallo
093fcaba68
Merge pull request #664 from lightning-signer/tx-creation-keys
Wrap transaction creation keys
2020-08-10 13:25:03 -07:00
Devrandom
8058202c4c nit 2020-08-10 22:09:03 +02:00
Devrandom
6f635c6bc3 Expose TxCreationKeys in LocalCommitmentTransaction via a method
This makes it obvious to signer implementers that the pre-derived keys are a local cache and should not be trusted in a validating signer.
2020-08-10 20:22:01 +02:00
Devrandom
d2e6f2ac18 Make TxCreationKeys public and wrap it in PreCalculatedTxCreationKeys
Allows calling of InMemoryChannelKeys methods.

The wrapping makes it obvious to signer implementers that the pre-derived keys are a local cache and should not be trusted in a validating signer.
2020-08-10 20:21:07 +02:00
Matt Corallo
99eef23f4e
Merge pull request #640 from valentinewallace/test-holding-cell-edge-case
Fail back HTLCs that fail to be freed from the holding cell
2020-08-08 14:20:09 -07:00
Valentine Wallace
523cab8ef7
Holding cell: if we fail to free an HTLC, fail it backwards
Plus add a test.
2020-08-08 16:32:15 -04:00
Matt Corallo
d735a24e6a
Merge pull request #663 from TheBlueMatt/2020-08-codecov
Set codecov upload token
2020-08-03 14:25:56 -07:00
Matt Corallo
7b0483eba8 Set codecov upload token
Docs seem to indicate this should only be required for private
repos, but we have builds failing claiming this needs to be
specified, so just set it manually.
2020-08-03 17:09:27 -04:00
Matt Corallo
1d28a71c15
Merge pull request #658 from lightning-signer/self-delay
ChannelKeys - provide to_self_delay alongside the remote channel pubkeys
2020-07-29 12:08:13 -07:00
Devrandom
48d73b3264 ChannelKeys - provide to_self_delay alongside the remote channel pubkeys
In the phase 2 signer, we will construct the commitment transaction inside the signer.
In preparation, provide needed channel related data.
2020-07-29 20:43:39 +02:00
Matt Corallo
779ff6721b
Merge pull request #651 from naumenkogs/2020-06-routing-data-improvements
Routing improvements
2020-07-27 10:18:13 -07:00
Gleb Naumenko
dd0e4f4034 Check htlc_maximum_msat on channel update 2020-07-27 14:06:20 +03:00
Gleb Naumenko
3a57cfc7c6 Store channel capacity if available 2020-07-27 14:06:20 +03:00
Gleb Naumenko
8b4f6e8861 Add htlc_maximum_msat field 2020-07-27 14:06:16 +03:00
Gleb Naumenko
b8fc761dc1 Update comment for test_msg_hole 2020-07-24 10:19:45 +03:00
Matt Corallo
ed84b02a0a
Merge pull request #655 from lightning-signer/per-commitment
ChannelKeys - separate commitment revocation from getting the per-commitment point
2020-07-22 13:11:45 -07:00
Devrandom
b19d4475cb ChannelKeys - separate commitment revocation from getting the per-commitment point
The commitment secret is sensitive - it can be used by an attacker to
steal funds if the node also signs the same transaction. Therefore,
only release the secret from ChannelKeys when we are revoking a
transaction.
2020-07-22 11:47:10 -07:00
Gleb Naumenko
a66b8017c0 Improve routing announcement test 2020-07-22 16:21:04 +03:00
Gleb Naumenko
430d57c610 Fix formatting 2020-07-22 16:21:04 +03:00
Gleb Naumenko
5309197150 Use constant for max msats 2020-07-22 16:21:04 +03:00
Gleb Naumenko
7838727a5c Update get_route comment to reflect new parameters 2020-07-22 16:20:19 +03:00
Matt Corallo
50df4cf464
Merge pull request #644 from joemphilips/improve_error_message
Improve error message.
2020-07-21 20:04:44 -07:00
Matt Corallo
5a1c0ccbf8
Merge pull request #623 from LNP-BP/feat-msgsizelimit
Making message size limit an exportable constant
2020-07-21 20:03:37 -07:00
joe.miyamoto
407e306a99
slightly refactor internal_announcement_signatures
For making debugging easy.
If the user gives a different node_secret for transport
layer (`PeerManager`) and for routing msg, internal_announcement_signatures
is the first place it causes an error.
By giving a detailed error message, user will be able to
fix the bug quickly.
2020-07-22 10:34:47 +09:00
joe.miyamoto
1fc6d6b5ee
Improve error message.
... for ChannelError and APIMisuseError
Before this commit, When rl returns error, we don't know
The actual parameter which caused the error.
By returning parameterised `String` instead of predefined `&'static str`,
We can give a caller improved error message.

TestLogger now has two additional methods
1. `assert_log_contains` which checks the logged messsage
  has how many entry which includes the specified string as a substring.
2. `aasert_log_regex` mostly the same with `assert_log_contains`
  but it is more flexible that caller specifies regex which has
  to be satisfied instead of just a substring.
For regex, tests now includes `regex` as dev-dependency.
2020-07-22 10:34:47 +09:00
Dr. Maxim Orlovsky
4bb5955be9 Moving LN_MAX_MSG_LEN const to the actual use place 2020-07-21 18:53:55 +02:00
Dr. Maxim Orlovsky
0e5dfadf64 Removing spec quotation from LN_MAX_MSG_LEN definition 2020-07-21 18:10:58 +02:00
Dr. Maxim Orlovsky
eae748a7b2 Removing duplicated code in message decryption test cases 2020-07-21 18:10:58 +02:00
Dr. Maxim Orlovsky
caed31a1e6 Test cases for message encryption/decryption size limits 2020-07-21 18:10:58 +02:00
Dr. Maxim Orlovsky
bcb50a65ae Fixing panic messages for decryption procedures 2020-07-21 18:10:58 +02:00
Dr. Maxim Orlovsky
eb8bcaae87 Making message size limit an exportable constant 2020-07-21 18:10:58 +02:00
Matt Corallo
d6d01bab84
Merge pull request #656 from erasmospunk/typo
Fix typo
2020-07-16 10:00:32 -07:00
John L. Jegutanis
1945f6c6c3 Fix typo 2020-07-15 16:43:18 +03:00
Matt Corallo
bb369b5c18
Merge pull request #652 from lightning-signer/commitment-secret
ChannelKeys provides individual commitment secrets
2020-07-02 11:31:31 -07:00
Devrandom
1d37f56f8a ChannelKeys provides individual commitment secrets 2020-07-01 11:54:56 -07:00
Matt Corallo
cd13364d44
Merge pull request #650 from TheBlueMatt/2020-06-fix-build
Fix silent merge conflict between bcd65be and 940d7ac
2020-06-28 18:01:43 +00:00
Matt Corallo
4ed148a64d Fix unused-parentheses warnings newer rustcs have added 2020-06-28 13:21:45 -04:00
Matt Corallo
94c37c6c0e Fix silent merge conflict between bcd65bed7b and 940d7ac8d8 2020-06-28 13:19:40 -04:00
Matt Corallo
0133739e9e
Merge pull request #647 from valentinewallace/test-remote-fee-spike-buffer-violation
Test remote fee spike buffer violation
2020-06-27 00:41:35 +00:00