Commit graph

4 commits

Author SHA1 Message Date
Duncan Dean
ec579f0303
ci: silence unnecessary_map_or lint as solution requires MSRV >= 1.70
Rust 1.84.0 was recently released along with some new clippy lints, one
of which is `unnecessary_map_or`. Unfortunately this lint suggests using
`Option::is_some_and` as a fix, but this is only available in Rust
 version >= 1.70, while we still have an MSRV of 1.63. So we silence that
lint for now.

We'd still like our lint CI to use stable Rust so that we can benefit from
new lint checks which may be helpful and don't require an MSRV bump, but
sometimes new lints (like in this case) do.

See:
  https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
  https://doc.rust-lang.org/std/option/enum.Option.html#method.is_some_and
2025-01-10 08:02:12 +02:00
Arik Sosman
1ff77aef60
Allow manual_div_ceil
Until our MSRV reaches 1.73.0, we're gonna need
to keep allowing it.
2024-12-05 00:48:35 -08:00
Matt Corallo
4741653f76 Allow clippy::unwrap-or-default because its usually wrong
`or_default` is generally less readable than writing out the thing
we're writing, as `Default` is opaque but explicit constructors
generally are not. Thus, we ignore the clippy lint (ideally we
could invert it and ban the use of `Default` in the crate entirely
but alas).
2024-10-23 16:15:00 +00:00
Arik Sosman
46c2c815bf
Create script file for easy local linting 2024-10-08 14:00:43 -07:00