mirrors/rust-lightning
1
0
Fork 0
mirror of https://github.com/lightningdevkit/rust-lightning.git synced 2025-02-26 15:42:52 +01:00
Code Issues Projects Releases Packages Wiki Activity
579 commits 27 branches 46 tags 98 MiB
Commit graph

385 commits

Author SHA1 Message Date
Matt Corallo
4f36f379e7 Move all-events check into framework instead of per-test 2018-09-14 16:24:30 -04:00
Matt Corallo
adee6719c4 Split up send_commitment into a const and non-const version 2018-09-14 16:24:30 -04:00
Matt Corallo
9252ddbb1d Remove unused import and uneccessary mut 2018-09-14 16:24:30 -04:00
Matt Corallo
68be3c0353 Test that we do not fail-backwards HTLCs that the remote on-chained 2018-09-14 15:27:54 -04:00
Matt Corallo
f48fe4bd8c Make the commitment signed dance a macro in ChannelManager tests 2018-09-14 15:27:53 -04:00
Matt Corallo
5ef88cea34 Do not fail-backwards LocalAnnounced HTLCs upon force-close. 
This is completely unsafe as we have provided the remote side with
a commitment_signed which they can broadcast, including the HTLC
transaction, and then could claim it on-chain after we've failed it
backwards!
 2018-09-14 15:27:53 -04:00
Matt Corallo
a55355e641 Ignore HTLC txn we dont know how to claim instead of unwrap()ing 
This fixes a crash introduced in 3e149b1fb6
and introduces a test which will tickle the bug.
 2018-09-14 15:27:39 -04:00
Matt Corallo
66d5d764aa Clean up and clarify tx broadcast checks in channelmonitor tests 
This effecitlvey reverts the refactors in 383bd90a48,
however keeps the actully new test code.

It also writes documentation for the super confusing tx test func
and makes it a bit less permissive.
 2018-09-13 14:24:37 -04:00
Matt Corallo
e9e27f277a There can only be one input in matched txn in ChannelMonitor 
This lets us simplify a few tidbits of loop.
 2018-09-13 14:05:08 -04:00
Matt Corallo
27d5a3a94f Optimize check_spend_remote HTLC a tad by avoiding indirections 
Instead of hopping a pointer, we're only ever going to return one
Transaction at max, so skip the Vec. Also avoid
re-pubkey-converting the revocation key.
 2018-09-13 14:05:08 -04:00
Matt Corallo
01c8e4f56f
Merge pull request #163 from ariard/claim_revoked_htlc_tx 
Implement claiming of revoked HTLC transactions by ChannelMonitor
 2018-09-13 13:53:47 -04:00
Matt Corallo
77c2622615
Merge pull request #175 from TheBlueMatt/2018-09-173-whitespace-err 
raise APIError from send_payment (#173 without whitespace nit)
 2018-09-13 13:11:51 -04:00
Yuntai Kyong
ec743351b1 raise APIError from send_payment 
add APIError::RouteError
 2018-09-13 11:18:03 -04:00
Yuntai Kyong
b6cbcc9f40 verify incoming sig first and fail earlier 2018-09-13 22:31:51 +09:00
Antoine Riard
383bd90a48 Add test of claiming HTLC-Timeout outputs based on a revoked commitment 
tx
 2018-09-12 23:51:02 +00:00
Antoine Riard
3e149b1fb6 Implement claiming of revoked HTLC transactions by ChannelMonitor 
Refactor check_spend_remote_transaction in part to check_spend_remote_htlc to
avoid lock mess in block_connected. We need
remote_commitment_txn_on_chain to match remote HTLC tx
 2018-09-12 23:50:58 +00:00
Antoine Riard
d84c084df7 Implement set_their_delayed_payment_base_key in ChannelMonitor 
Needed to build redeemscript on HTLC-Success/HTLC-Timeout tx from
remote revoked commitment tx
 2018-09-12 23:17:20 +00:00
Matt Corallo
f27c74b35c
Merge pull request #167 from TheBlueMatt/2018-09-dup-htlc 
Allow duplicate-payment_hash HTLCs for HTLC forwards
 2018-09-12 13:07:13 -04:00
Matt Corallo
0a65255bd9 Add simple test for duplicate-payment_hash HTLC tracking 2018-09-12 11:15:51 -04:00
Matt Corallo
6b3cc8bb4d Avoid cross-test statics in ChannelManager network tests 2018-09-12 11:15:51 -04:00
Matt Corallo
da5d707f49 Allow duplicate-payment_hash HTLCs for HTLC forwards 
This is required by BOLT 2 to ensure that no attacker can simply
relay every public node a duplicate-payment_hash HTLC for each HTLC
it receives to deduce where an HTLC came from.

Note that this makes the claim logic much less incentive-compatible
as we will not claim all available HTLCs with the same payment_hash
even if we know the preimage! This is OK because, most likely, any
attackers trying to map the network will use small-value payments
and, hopefully, we will move away from constant hashes across an
entire payment at some point in the near future.

This further simplifies the payment transition state a bit, so
hopefully at least we got some readability out of all of this
 2018-09-12 11:15:47 -04:00
Yuntai Kyong
28a612f9f3 Migrate fuzz router/channel target to Readable 
and be more specific about DecodeError::InvalidValue
 2018-09-12 10:19:36 -04:00
Yuntai Kyong
3e89106163 migrate peer_handler to use Writeable 
added inplace byte_utils
 2018-09-12 10:19:36 -04:00
Yuntai Kyong
89475381bb Implement Writeable for messages 2018-09-12 10:18:52 -04:00
Yuntai Kyong
1b8504a3f3 Implement Writer/Reader 
with additional variants in DecodeError
 2018-09-12 10:18:02 -04:00
Matt Corallo
3b49837862 Split HTLC tracking into separate Inbound/Outbound types 
This isnt as simplifying as I'd hoped, but still increases
compile-time checking, which is nice, and removes one of two
panic!()s.
 2018-09-11 15:02:10 -04:00
Matt Corallo
a2d4889e32 panic on invalid calls to Channel::send_commitment instead of Err 2018-09-09 11:36:00 -04:00
Matt Corallo
33fa278f33 Do not allow sending HTLCs when the first hop is disconnected 2018-09-09 11:36:00 -04:00
Matt Corallo
8cad2ffa9b Sync get_update_fail_htlc, get_update_fulfill_htlc state err result 
Both get_update_fail_htlc and get_update_fulfill_htlc should never
be called before any HTLC could have been accepted (ie
pre-ChannelFunded) nor should they ever be called
post-ShutdownComplete as the Channel object should be destroyed at
that point. Previously get_update_fulfill_htlc would panic, but
get_update_fail_htlc would return an Err. For now make them both
panic but we can revisit this if we want to have fewer panics in
the future.
 2018-09-09 11:36:00 -04:00
Matt Corallo
e9fed4973b Disallow duplicate Init messages from peers 2018-09-08 14:43:42 -04:00
Matt Corallo
bf46a5f721 Fix PeerManager::get_peer_node_ids to filter according to docs 2018-09-08 13:59:39 -04:00
Matt Corallo
6dab6b185d Disconnect duplicate node_id connections after Noise handshake 2018-09-08 13:59:39 -04:00
Matt Corallo
c2bbeb5814 Update add_update_monitor docs to indicate registration req. 
It wasn't entirely clear from the existing docs that it is the
responsibility of the implementor of ManyChannelMonitor to
register the relevant outpoint.
 2018-09-08 10:33:32 -04:00
Matt Corallo
beee006365 Document Channel::get_funding_redeemscript precondition 2018-09-08 10:30:10 -04:00
Antoine Riard
4b9adea006 Add registration of commitment tx's outputs from 
check_spend_remote_transaction

Fixup more descriptive var names by Matt Corallo <git@bluematt.me>
 2018-09-08 02:30:28 +00:00
Matt Corallo
90b545ffe3 Narrow ChainWatchInterface::install_watch_script 2018-09-08 02:30:28 +00:00
Antoine Riard
f1a26e6aea Refactor handle_update_fee to wrapper error handling function 2018-09-07 21:59:45 +00:00
Antoine Riard
d6726d6f26 Refactor handle_revoke_and_ack to wrapper error handling function 2018-09-07 21:57:06 +00:00
Antoine Riard
88e561be85 Refactor handle_commitment_signed to wrapper error handling function 2018-09-07 21:51:58 +00:00
Antoine Riard
5662edaf9f Refactor handle_update_fail_malformed_htlc to wrapper error handling function 2018-09-07 21:46:47 +00:00
Antoine Riard
8544d6f9dd Refactor handle_update_fail_htlc to wrapper error handling function 2018-09-07 21:42:07 +00:00
Antoine Riard
27869ad0ce Refactor handle_update_fulfill_htlc to wrapper error handling function 2018-09-07 21:36:55 +00:00
Antoine Riard
321534020e Refactor handle_update_add_htlc to wrapper error handling function 2018-09-07 21:30:00 +00:00
Antoine Riard
699fb3b64e Refactor handle_closing_signed to wrapper error handling function 2018-09-07 21:21:05 +00:00
Matt Corallo
6016ca1870
Merge pull request #160 from ariard/channel_manager_refactor_all 
Channel manager refactor all
 2018-09-07 10:19:28 -04:00
Antoine Riard
4b5b48cb57 Refactor handle_shutdown to wrapper error handling function 2018-09-07 03:10:10 +00:00
Antoine Riard
8dfc3c34bc Refactor handle_funding_locked to wrapper error handling function 2018-09-07 02:58:01 +00:00
Antoine Riard
cdbd7ce71d Refactor handle_funding_signed to wrapper error handling function 2018-09-07 02:45:07 +00:00
Matt Corallo
ed650ec530 Ensure funding_created always returns Some(_) HandleError::action 2018-09-06 11:38:48 -04:00
Antoine Riard
e67b715e52 Refactor handle_funding_created to wrapper error handling function 2018-09-06 11:07:44 -04:00