Elias Rohrer
0d59417473
Fix unrelated warnings
...
Just two trivial compiler warnings that are unrelated to the changes
made here.
2023-04-19 10:25:04 +02:00
Matt Corallo
2ebbe6f304
Merge pull request #2138 from swilliamson5/replace-our-max-htlcs-constant
...
Replace `OUR_MAX_HTLCS` with config knob
2023-04-17 21:58:07 +00:00
Matt Corallo
68149a204f
Merge pull request #2196 from wpaulino/ci-ignore-master-cancel-prev
...
Prevent unnecessary CI workflow runs
2023-04-17 21:54:55 +00:00
Matt Corallo
bd25a8192f
Merge pull request #2195 from TheBlueMatt/2023-04-115-bindings-upstream
2023-04-17 21:25:37 +00:00
Wilmer Paulino
d63006dcc0
Cancel in-progress jobs on updated push
...
At times, PRs can go through multiple pushes in a short amount of time,
spawning a workflow run for each. Most of the time, there's no need to
let the previous jobs running if the code itself has changed (e.g., via
a force push), and we'd benefit from having those slots be used by other
PRs/branches instead.
2023-04-17 11:32:53 -07:00
Wilmer Paulino
f471a1b9da
Ignore workflow runs on master branch
...
This master branch is just an alias to the main branch for legacy
reasons, so there's no need to run workflows on both branches.
2023-04-17 11:30:30 -07:00
Matt Corallo
b709bb3e35
Mark the invoice Network getter no-export
...
...as it is redundant with the `currency` getter if we're not using
the rust-bitcoin types natively.
2023-04-17 17:44:19 +00:00
Wilmer Paulino
15050895fd
Merge pull request #2177 from TheBlueMatt/2023-04-test-function-generics
...
Genericize Test Functions
2023-04-17 09:56:18 -07:00
Matt Corallo
c977def259
Merge pull request #2191 from TheBlueMatt/2023-04-fix-bucket-deser
...
Fix deserialization of u16 arrays
2023-04-17 15:11:53 +00:00
Matt Corallo
ac004a91aa
Merge pull request #2187 from benthecarman/invoice-serde-no-std
2023-04-17 13:28:49 +00:00
Steven Williamson
f65660945d
Replace OUR_MAX_HTLCS constant with config knob
...
holder_max_accepted_htlcs. Set upper bound of 483
Writes an even TLV if the value isn't 50
2023-04-16 19:28:49 -04:00
Matt Corallo
7775356c39
Fix deserialization of u16 arrays
...
u16 arrays are used in the historical liquidity range tracker.
Previously, we read them without applying the stride multiple,
reading bytes repeatedly and at an offset, corrupting data as we
go.
This applies the correct stride multiplayer fixing the issue.
2023-04-16 21:59:35 +00:00
benthecarman
36f610c4cf
Add CI test for compile no-std serde lightning-invoice
2023-04-16 13:44:14 -05:00
benthecarman
778c752a0b
Fix compiling lightning-invoice for no-std + serde
2023-04-15 15:38:53 -05:00
Matt Corallo
e1e38196e2
Merge pull request #2172 from TheBlueMatt/2023-04-fix-panicy-debug-assert
...
Remove a race-y debug assertion in new channel update handling
2023-04-14 15:00:12 +00:00
Matt Corallo
accfdae541
Merge pull request #2180 from benthecarman/impl-pk-to-node-id
...
Implement to and from for PublicKey and NodeId
2023-04-14 14:56:51 +00:00
benthecarman
7a37e2cd23
Impl FromStr for NodeId
2023-04-13 14:53:23 -05:00
Matt Corallo
b3ab1cb801
Merge pull request #2179 from benthecarman/use-node-alias-type
...
Use NodeAlias type in NodeAnnouncement
2023-04-13 19:46:30 +00:00
Matt Corallo
cfb9eb9639
Move some additional test macros into functions
...
This marginally reduces the quantity of code compiled in tests
further.
2023-04-13 18:40:46 +00:00
Matt Corallo
d55623601f
Introduce traits to make test utils generic across the CM Holder
...
In our test utilities, we generally refer to a `Node` struct which
holds a `ChannelManager` and a number of other structs. However, we
use the same utilities in benchmarking, where we have a different
`Node`-like struct. This made moving from macros to functions
entirely impossible, as we end up needing multiple types in a given
context.
Thus, here, we take the pain and introduce some wrapper traits
which encapsulte what we need from `Node`, swapping some of our
macros to functions.
2023-04-13 18:40:46 +00:00
benthecarman
f78e6b956c
Use NodeAlias type in NodeAnnouncement
2023-04-13 13:09:03 -05:00
benthecarman
5ed6732b87
Implement to and from for PublicKey and NodeId
2023-04-13 12:59:42 -05:00
Matt Corallo
fb86fc2744
DRY the event handling in ChannelManager
...
In the coming commits we'll add some additional complexity to the
event handling flows, so best to DRY them up before we get there.
2023-04-12 17:01:45 +00:00
valentinewallace
157af6ec1c
Merge pull request #2142 from alecchendev/2023-03-expose-fail-reason-in-payment-failure
...
Expose a failure reason in `PaymentFailed`
2023-04-11 17:26:16 -04:00
Alec Chen
23c70642b8
Add reason to Event::PaymentFailed
...
This includes adding a reason to `PendingOutboundPayment::Abandoned` and
using that reason when pushing an `Event::PaymentFailed`.
2023-04-10 17:13:47 -05:00
valentinewallace
34686692e9
Merge pull request #2173 from benthecarman/convert-currency-to-netowkr
...
Convert Network to and from Currency
2023-04-10 12:21:16 -04:00
benthecarman
841dd1ea3a
Convert Network to and from Currency
2023-04-08 21:24:17 -05:00
Matt Corallo
29f80269b5
Remove a race-y debug assertion in new channel update handling
...
In 6090d9e6a8
2023-04-09 01:43:39 +00:00
Arik
74328bd6e7
Merge pull request #2161 from benthecarman/prune-stale-channels-rgs
...
Prune stale channels from network graph after RGS sync.
2023-04-07 23:26:19 -07:00
valentinewallace
186cd047f8
Merge pull request #2158 from TheBlueMatt/2023-04-handle_err_more-check
...
Test for extra locks held in `handle_error` unconditionally
2023-04-07 16:19:27 -04:00
Jeffrey Czyz
1ceb41e08b
Merge pull request #2023 from futurepaul/fallback-to-address
...
add `Fallback` getter that returns `Address`
2023-04-07 14:39:32 -05:00
Alec Chen
432f0e678e
Create PaymentFailureReason enum
2023-04-07 13:45:11 -05:00
Matt Corallo
f30dc859e7
Merge pull request #2170 from TheBlueMatt/2023-04-silent-merge-conflict
...
Fix silent merge conflict between new test and payment refactor
2023-04-07 18:27:33 +00:00
Wilmer Paulino
a5ecb85171
Merge pull request #2162 from jkczyz/2023-04-invoice-hash
2023-04-07 10:11:36 -07:00
Matt Corallo
8a743693ba
Fix silent merge conflict between new test and payment refactor
2023-04-07 16:30:25 +00:00
Matt Corallo
568a20b832
Merge pull request #2148 from TheBlueMatt/2023-04-claim-from-closed
...
Allow claiming a payment if a channel with an HTLC has closed
2023-04-07 16:17:25 +00:00
Matt Corallo
1016e1f605
Merge pull request #2139 from TheBlueMatt/2023-03-metadata-prefactors
...
Add a new `RecipientOnionFields` and replace `PaymentSecret` with it
2023-04-07 16:14:30 +00:00
Matt Corallo
c8441d2f2d
Merge pull request #2165 from wpaulino/fix-bp-channel-pending-panic-flake
...
Use signal for handling ChannelPending in test_background_event_handling
2023-04-07 16:08:34 +00:00
Matt Corallo
9e6e20ff61
Split up comically long error return
2023-04-07 04:54:07 +00:00
Jeffrey Czyz
39befa16b4
Expose a BOLT 12 Invoice's signable_hash
...
This is useful as an identifier for downstream clients like VLS.
2023-04-06 23:15:31 -05:00
Jeffrey Czyz
821c79da98
Expose a BOLT 11 Invoice's signable_hash
...
Otherwise, an Invoice must first be converted to a SignedRawInvoice to
obtain the hash.
2023-04-06 23:15:25 -05:00
Jeffrey Czyz
854d650b5b
Linkify lightning-invoice docs
2023-04-06 23:13:05 -05:00
benthecarman
b336b2e92a
Lift std check to function definition
2023-04-06 20:36:17 -05:00
Wilmer Paulino
5037298361
Use signal for handling ChannelPending in test_background_event_handling
...
This fixes two potential panics within the test if the
`BackgroundProcessor` for `nodes[0]` consumed the `ChannelPending` event
prior to us consuming it manually in `end_open_channel`. The first panic
would happen within the event handler, since `ChannelPending` was not
being handled. The second panic would happen upon expecting the
`ChannelPending` event after handling `nodes[1]`'s `funding_signed` if
the `BackgroundProcessor` handled the event first. To ensure we still
reliably receive a `ChannelPending` event once possible, we let the
`BackgroundProcessor` consume the event and notify it.
2023-04-06 15:10:12 -07:00
Matt Corallo
5c6a39bd5b
Merge pull request #2163 from TheBlueMatt/2023-04-less-lock
...
Avoid holding a `per_peer_state` lock while claiming from a monitor
2023-04-06 21:53:49 +00:00
benthecarman
cff1b4bce3
Prune stale channels from network graph after RGS sync
2023-04-06 14:09:13 -05:00
Matt Corallo
4a8d01dd19
Add a claim_deadline field to PaymentClaimable with guarantees
...
Now that we guarantee `claim_payment` will always succeed we have
to let the user know what the deadline is. We still fail payments
if they haven't been claimed in time, which we now expose in
`PaymentClaimable`.
2023-04-06 18:12:36 +00:00
Matt Corallo
b189df579f
Avoid holding a per_peer_state lock while claiming from a monitor
...
There's no reason to hold a lock on `per_peer_state` while we're
claiming from a since-closed channel via a `ChannelMonitorUpdate`,
which we stop doing here.
2023-04-06 18:10:06 +00:00
Matt Corallo
ba1349982b
Merge pull request #2101 from TheBlueMatt/2023-03-one-less-sig
...
Support future removal of redundant per-HTLC signatures in `CMU`s
2023-04-06 18:07:55 +00:00
Paul Miller
cf0a90b8c0
Fallback: add Address getter and use bitcoin types
2023-04-06 10:49:14 -05:00
