Prefer implementing From over Into

.. as the std library docs state that implementing Into should be avoided:
"One should avoid implementing Into and implement From instead.
Implementing From automatically provides one with an implementation of
Into thanks to the blanket implementation in the standard library."
This commit is contained in:
Elias Rohrer 2024-03-01 11:42:54 +01:00
parent bf3bc420c7
commit fe50a507ab
No known key found for this signature in database
GPG key ID: 36153082BDF676FD

View file

@ -112,9 +112,9 @@ impl core::fmt::Display for PaymentPreimage {
}
/// Converts a `PaymentPreimage` into a `PaymentHash` by hashing the preimage with SHA256.
impl Into<PaymentHash> for PaymentPreimage {
fn into(self) -> PaymentHash {
PaymentHash(Sha256::hash(&self.0).to_byte_array())
impl From<PaymentPreimage> for PaymentHash {
fn from(value: PaymentPreimage) -> Self {
PaymentHash(Sha256::hash(&value.0).to_byte_array())
}
}